From: "Baxter, Jim" <jim_baxter@mentor.com>
To: Peter Rosin <peda@axentia.se>, <linux-i2c@vger.kernel.org>
Cc: Peter Korsgaard <peter.korsgaard@barco.com>,
Wolfram Sang <wsa@the-dreams.de>, <linux-kernel@vger.kernel.org>,
"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>,
jiwang <Jiada_Wang@mentor.com>
Subject: Re: [PATCH v1 0/2] i2c: Stop i2c modules being unloaded while in use.
Date: Tue, 13 Sep 2016 17:55:50 +0100 [thread overview]
Message-ID: <91828685-c7ba-b5b2-f128-240fdf9ebb44@mentor.com> (raw)
In-Reply-To: <51c45bae-aa5d-bfad-e9d0-d95deb3dc380@axentia.se>
Hi Peter,
> nitpick: Patch subjects for the second patch is wrong.
>
> "reparented" is a bit dual when dealing with i2c adapter trees.
> i2c_mux_add_owned_adapter is perhaps clearer?
Agreed, I will update that.
>
>
> Aside from that, I'm not using modules much and need some enlightenment
> as to why the i2c_del_mux_adapter() call in i2c_mux_gpio_remove() is not
> sufficient and what exactly the problem is? Why would someone/something
> unload the i2c-mux module prematurely?
It is not a normal operation to remove the i2c gpio mux, however systemd
could unload modules out of order if users are restarting services
incorrectly and cause unintended side-effects. This change would stop an
i2c-mux that maybe controlling a voltage regulator from being unloaded
and disabling power to parts of the system unexpectedly.
>
>
> Would it be an alternative to make i2c-mux a proper kernel object of
> some kind? I mean, why do not all other mux users also need to modify
> the owner? Why is i2c-mux-gpio special?
>
i2c-mux-gpio is not special, the code inserted by
[PATCH v1 1/2] i2c-mux: add i2c_mux_add_reparented_adapter api could be
used by other muxes if required.
Best regards
Jim
next prev parent reply other threads:[~2016-09-13 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 20:05 jim_baxter
2016-09-07 20:05 ` [PATCH v1 1/2] i2c-mux: add i2c_mux_add_reparented_adapter api jim_baxter
2016-09-07 20:05 ` [PATCH v1 2/2] i2c-mux-gpio: call i2c_add_reparented_mux_adapter jim_baxter
2016-09-09 20:40 ` [PATCH v1 0/2] i2c: Stop i2c modules being unloaded while in use Peter Rosin
2016-09-13 16:55 ` Baxter, Jim [this message]
2016-09-14 12:57 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91828685-c7ba-b5b2-f128-240fdf9ebb44@mentor.com \
--to=jim_baxter@mentor.com \
--cc=Jiada_Wang@mentor.com \
--cc=Joshua_Frkuska@mentor.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®