From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755612AbbEUIgy (ORCPT ); Thu, 21 May 2015 04:36:54 -0400 Received: from mail.eperm.de ([89.247.134.16]:58158 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbbEUIgu (ORCPT ); Thu, 21 May 2015 04:36:50 -0400 From: Stephan Mueller To: Herbert Xu Cc: pebolle@tiscali.nl, andreas.steffen@strongswan.org, tytso@mit.edu, sandyinchina@gmail.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: random: Wake up all getrandom(2) callers when pool is ready Date: Thu, 21 May 2015 10:36:47 +0200 Message-ID: <9183463.XNhR7e5TNc@tauon> User-Agent: KMail/4.14.6 (Linux/3.19.5-200.fc21.x86_64; KDE/4.14.6; x86_64; ; ) In-Reply-To: <20150521081953.GA22301@gondor.apana.org.au> References: <3340545.QDDPvU7BuN@tachyon.chronox.de> <9182932.rX0DhQWPrJ@tachyon.chronox.de> <20150521081953.GA22301@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 21. Mai 2015, 16:19:54 schrieb Herbert Xu: Hi Herbert, >On Thu, May 21, 2015 at 09:55:17AM +0200, Stephan Mueller wrote: >> So, I will create a 2nd wait queue in random.c for uninterruptible waits, >> change the get_blocking_random_bytes back to void and use wait_event to >> wait >> for the initialization. > >Hold your horses. You don't need a second queue, you just need to >change wake_up_interruptible to wake_up. A simple change to wake_up is not working -- I already checked. But the proposed wake_up_all does the trick. Ciao Stephan