From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB0CC2B9F8 for ; Tue, 25 May 2021 08:08:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2C916135F for ; Tue, 25 May 2021 08:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232225AbhEYIKL (ORCPT ); Tue, 25 May 2021 04:10:11 -0400 Received: from mga18.intel.com ([134.134.136.126]:10206 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231303AbhEYIJI (ORCPT ); Tue, 25 May 2021 04:09:08 -0400 IronPort-SDR: XbI7sfyIXhe/M2EiqiuDPyct2Wy8ycXiD1xpFNVRCfMRx+ieR8hgWYgDk1q0hnhAfUglxjrWXS PSrO8BE6nERg== X-IronPort-AV: E=McAfee;i="6200,9189,9994"; a="189506748" X-IronPort-AV: E=Sophos;i="5.82,327,1613462400"; d="scan'208";a="189506748" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 00:40:56 -0700 IronPort-SDR: dzhWYPGoftcRZ2QCpNxYw6Gycu/nflkmMjp6EE0Ar1TE/P6h7ZgsyDZGkCrQMX4H5fO2xvLkFO JGGe8QM2zWbw== X-IronPort-AV: E=Sophos;i="5.82,327,1613462400"; d="scan'208";a="476287866" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.11]) ([10.239.13.11]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 00:40:52 -0700 Subject: Re: [kbuild-all] Re: [PATCH] kvm: fix boolreturn.cocci warnings To: Peter Zijlstra , kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org References: <202105251316.O1igBtAa-lkp@intel.com> <20210525055940.GA7291@9b81fe870f96> From: Rong Chen Message-ID: <91885328-dc7f-3d12-3ddb-53a403bb8c60@intel.com> Date: Tue, 25 May 2021 15:39:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/21 3:11 PM, Peter Zijlstra wrote: > On Tue, May 25, 2021 at 01:59:40PM +0800, kernel test robot wrote: >> From: kernel test robot >> >> arch/arm64/kvm/mmu.c:1203:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool >> arch/arm64/kvm/mmu.c:1173:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool >> arch/arm64/kvm/mmu.c:1216:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool >> arch/arm64/kvm/mmu.c:1159:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool >> >> Return statements in functions returning bool should use >> true/false instead of 1/0. >> Generated by: scripts/coccinelle/misc/boolreturn.cocci > Per 2b076054e524 ("remove boolinit.cocci"), I have a very dim view of > this sort of thing. Hi Peterz, Sorry for the noise, we'll disable the check. > >> Fixes: 63b3f96e1a98 ("kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT") > *how* ?!? The bot is stupid, it used the commit that first found the issues, we'll take a look at it. Best Regards, Rong Chen