From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3203AFD0D for ; Mon, 8 Jun 2026 08:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907901; cv=none; b=i63ZkCrI0GURaGmfVIJw2eJqxSK4O50ErhWIJu53edDpby7zrjox5cYIf/qfnKIjcbohoE2iga+UjGeIrAD+KvYKyo3JsUtF91bovBmk1Fc/gGNwZYBedblHd68rx0ngnoCg2rUtA2z9UH3HIjaHB3D4sqXzJivf4QWX+etW5Ic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780907901; c=relaxed/simple; bh=BXaZfFdflynFOGogrQYYCO11NJz9qF4gKEWS8jDZf8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ui2/lZreyMA5bGe/dMv5xhy2rOLu4A+vQ5BEqKooUGGw51NvJJF70M5MFOdFT6qNvmYy22TBmk2g6Xs2FR9HjtTG5XwgMzErtPrcTaSlgJaM/D0DttQeVTXgj1put+ZBMppmD7gV/vRd422Sn08ZHeFH3LPWJ/CDX9smNk2r1xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TjA82VPn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=grbw7E3j; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TjA82VPn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="grbw7E3j" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780907899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wwQyRM0soCCwqjRtQ3TNBnEtxbXipQm56goEaNWxWT0=; b=TjA82VPn9Jw9Gio6M2bAUY1lHGFCMViTHntESvJvjPq25VAfIGEz2kP6KwByziV8tp2fae e8x4RAB66moneWaUoXHB2lmbPS4x3nBIOq4WFW50cbZi0O47cb2nDs182tTu2n2qwd7y31 FIPLHXieDOON3uA9ZfCAMNK4yrLULPY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-aKwU4ot5M1K6nAFzmta7UQ-1; Mon, 08 Jun 2026 04:38:17 -0400 X-MC-Unique: aKwU4ot5M1K6nAFzmta7UQ-1 X-Mimecast-MFC-AGG-ID: aKwU4ot5M1K6nAFzmta7UQ_1780907897 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-46010392f89so3681649f8f.2 for ; Mon, 08 Jun 2026 01:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780907897; x=1781512697; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wwQyRM0soCCwqjRtQ3TNBnEtxbXipQm56goEaNWxWT0=; b=grbw7E3jXr4kr/DKFq+XiAXo9JQxi7KxWPvZ509AEkNPpYlBt4fQtuEL8T/XSkXHKC ucXWHQzf7N7ZX7VkCnB/VehxChH4ttHvoL4mglaa+HEL6OYt7OjoLhTeGvda7fB4Qd6H 8P3THxNfZmTSl1D34AixLmmdP92teFWoPeUCfRnJxVPLz7GJ9DjhSpQbE5x3BtROU2uv iZTAU73abKR4ZcUR9ZMDHUEY8ReCpXC6uEjj4dMji5ASMgFCt0xM/66O0OyaCucqJ/p3 tXQsSp0eTfh59oAnYlPpciSJlXFq7DMsOvgTnD+Sr3sKvlnbxoPx9owN8tSlj1vL4+v3 7yNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780907897; x=1781512697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wwQyRM0soCCwqjRtQ3TNBnEtxbXipQm56goEaNWxWT0=; b=dskdD9E8yEQ1dy0KpXdFwRjf3PlZY7n40vF6vHhK+ehxVI9/aDAxG+nsr/HpG58t/5 ujbsj0ieWvVFSZ4vx9s/Mex+nxk7zuWMqo3KsaV/6vzrxCviY2eSFqmNzDThrmruGgNQ sPsw2yH88cnCvxbFBftZiFg6FW5wMJf5Y+YYBrdi0L177Msh7df9vrkFsNVFnDo8djFk ZIv0Mu3bTZJgrIUrNksW4+7HWTj4G/m7aTrB2cBDTsHSOeRyJk2YP/pUjVqlYuDxaksr eWSbhBi9cZ3NUsolVQa9V3YE9771A1iCVJI5cjO7Ik8ZOi/l3V3uTDYZO6YwNxx5UZ8Q xZAA== X-Gm-Message-State: AOJu0Yxah9C6lUg+4M66HrB3ZXQQFUDwVvXe+3c9n7JSJEn6YzOPGNNK DZUJJN0mBEL/M1vrlohuy+VMlYqOyDSXkwSVm3qaABARogiQt7QCnJdtVfpCzfTD4UbHBssJWp9 QWtRgl5qGMLWNeduPkLs96ch6+Hec4Z0rX93YIuSQAGx5tXVKzUDHYpVDQn9BlsizJDxfR2Szqv FKEWKTgr8XI44V+wGqAYKLuWgRsuDPE1oSh/35LDMeNts= X-Gm-Gg: Acq92OEJizB8VBqcdrNZqjn8R0l4aJyLLyoJ0BcMJwydmRtEowOuVVjxuW+ZVk0w3oX Jr6yqN9hiNCcdj8DV2dZ3zgWu0KErKyYTgmzcGobDZJ4TjAnMR6Ewkv6CnjcaTd20kh+QksJO6Y cfkijXkuLGv3H6Jw7DNuXivDU9xLdkgV39t+Q7ui7P+lK2SGjPlDw1UAOAErB3kMvjxOOXKtxJV GGbNjxwBjrGK5YZMNIjBSbOcS1ygUr9vcC/boEtxHUfcGZ8lk3nuv/m0wwkcrb8MwyOlkTtrPT5 Nyezm2g7pUmTC8UdqzPH2LqWpbGKtrcjpsgWRazpckTT7YZVwLXtfo9/ru21775nMlD3tg+GE4Q aWNsKaZ8L21HgaCWNe/cOXCM= X-Received: by 2002:a5d:624a:0:b0:452:3677:3fb3 with SMTP id ffacd0b85a97d-460304ebbe1mr15950868f8f.1.1780907896453; Mon, 08 Jun 2026 01:38:16 -0700 (PDT) X-Received: by 2002:a5d:624a:0:b0:452:3677:3fb3 with SMTP id ffacd0b85a97d-460304ebbe1mr15950779f8f.1.1780907895867; Mon, 08 Jun 2026 01:38:15 -0700 (PDT) Received: from redhat.com ([31.152.37.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f344541sm47271286f8f.22.2026.06.08.01.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 01:38:15 -0700 (PDT) Date: Mon, 8 Jun 2026 04:38:08 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: [PATCH v10 19/37] mm: page_alloc: clear PG_zeroed on buddy merge if not both zero Message-ID: <918897302a4cab9f476625adc238ec65a688d1d7.1780906288.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.51.2.2891.g4157995a80.dirty X-Mutt-Fcc: =sent When two buddy pages merge in __free_one_page(), preserve PG_zeroed on the merged page only if both buddies have the flag set. Otherwise clear it. The merged page would inherit PG_zeroed, and a later __GFP_ZERO allocation would skip zeroing stale data in the non-zero half. Signed-off-by: Michael S. Tsirkin Reviewed-by: Gregory Price Assisted-by: Claude:claude-opus-4-6 Assisted-by: cursor-agent:GPT-5.4-xhigh --- include/linux/page-flags.h | 1 + mm/page_alloc.c | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 91f8ddb1d512..9365d59ac1d6 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -680,6 +680,7 @@ FOLIO_FLAG_FALSE(idle) * uses this to skip redundant zeroing in post_alloc_hook(). */ __PAGEFLAG(Zeroed, zeroed, PF_NO_COMPOUND) +CLEARPAGEFLAG(Zeroed, zeroed, PF_NO_COMPOUND) #define __PG_ZEROED (1UL << PG_zeroed) /* diff --git a/mm/page_alloc.c b/mm/page_alloc.c index edfc83571985..a90bca5317c1 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -941,10 +941,14 @@ static inline void __free_one_page(struct page *page, unsigned long buddy_pfn = 0; unsigned long combined_pfn; struct page *buddy; + bool buddy_zeroed; + bool page_zeroed; bool to_tail; VM_BUG_ON(!zone_is_initialized(zone)); - VM_BUG_ON_PAGE(page->flags.f & PAGE_FLAGS_CHECK_AT_PREP, page); + /* PG_zeroed (aliased to PG_private) is valid on free-list pages */ + VM_BUG_ON_PAGE(page->flags.f & + (PAGE_FLAGS_CHECK_AT_PREP & ~__PG_ZEROED), page); VM_BUG_ON(migratetype == -1); VM_BUG_ON_PAGE(pfn & ((1 << order) - 1), page); @@ -979,6 +983,8 @@ static inline void __free_one_page(struct page *page, goto done_merging; } + buddy_zeroed = PageZeroed(buddy); + /* * Our buddy is free or it is CONFIG_DEBUG_PAGEALLOC guard page, * merge with it and move up one order. @@ -997,10 +1003,17 @@ static inline void __free_one_page(struct page *page, change_pageblock_range(buddy, order, migratetype); } + page_zeroed = PageZeroed(page); + __ClearPageZeroed(page); + __ClearPageZeroed(buddy); + combined_pfn = buddy_pfn & pfn; page = page + (combined_pfn - pfn); pfn = combined_pfn; order++; + + if (page_zeroed && buddy_zeroed) + __SetPageZeroed(page); } done_merging: -- MST