mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Chester Lin" <chester62515@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Matthias Brugger" <mbrugger@suse.com>,
	"NXP S32 Linux Team" <s32@nxp.com>,
	"Tim Harvey" <tharvey@gateworks.com>,
	"Alexander Stein" <alexander.stein@ew.tq-group.com>,
	"Gregor Herburger" <gregor.herburger@ew.tq-group.com>,
	"Marek Vasut" <marex@denx.de>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Joao Paulo Goncalves" <joao.goncalves@toradex.com>,
	"Markus Niebel" <Markus.Niebel@ew.tq-group.com>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Matthias Schiffer" <matthias.schiffer@tq-group.com>,
	"Stefan Wahren" <stefan.wahren@chargebyte.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Josua Mayer" <josua@solid-run.com>,
	"Philippe Schenker" <philippe.schenker@toradex.com>,
	"Li Yang" <leoyang.li@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Document missing s32g3 board
Date: Wed, 20 Mar 2024 08:47:41 +0100	[thread overview]
Message-ID: <918b1700-17d7-4475-a39c-c317472da0b4@linaro.org> (raw)
In-Reply-To: <20240319221614.56652-3-wafgo01@gmail.com>

On 19/03/2024 23:16, Wadim Mueller wrote:
> The nxp, s32g399a-rdb3 board is not documented.

Use full name of the board.

Subject: How is it missing? There is no such board in the kernel, so
binding is not missing. Also, you touch here serial...

> 
>  * Add entry for S32G3 based boards with nxp,s32g399a-rdb3 item
>  * Add nxp,s32g3-linflexuart documentation
> 
> Signed-off-by: Wadim Mueller <wafgo01@gmail.com>

Bindings go before users.

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml              | 6 ++++++
>  .../devicetree/bindings/serial/fsl,s32-linflexuart.yaml     | 3 +++

Split the patches. They will go via different subsystems.

>  2 files changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 228dcc5c7d6f..23bf1d7f95b1 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1503,6 +1503,12 @@ properties:
>                - nxp,s32g274a-rdb2
>            - const: nxp,s32g2
>  
> +      - description: S32G3 based Boards
> +        items:
> +          - enum:
> +              - nxp,s32g399a-rdb3
> +          - const: nxp,s32g3


Best regards,
Krzysztof


      reply	other threads:[~2024-03-20  7:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 22:16 [PATCH v2 0/2] NXP S32G3 SoC initial bring-up Wadim Mueller
2024-03-19 22:16 ` [PATCH v2 1/2] arm64: dts: S32G3: Introduce device tree for S32G-VNP-RDB3 Wadim Mueller
2024-03-20  7:00   ` Ghennadi Procopciuc
2024-03-20  7:49     ` Krzysztof Kozlowski
2024-03-20  8:24       ` Ghennadi Procopciuc
2024-03-20  9:24         ` Krzysztof Kozlowski
2024-03-19 22:16 ` [PATCH v2 2/2] dt-bindings: arm: fsl: Document missing s32g3 board Wadim Mueller
2024-03-20  7:47   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=918b1700-17d7-4475-a39c-c317472da0b4@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Markus.Niebel@ew.tq-group.com \
    --cc=afaerber@suse.de \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=bhelgaas@google.com \
    --cc=chester62515@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregor.herburger@ew.tq-group.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=joao.goncalves@toradex.com \
    --cc=josua@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=marex@denx.de \
    --cc=matthias.schiffer@tq-group.com \
    --cc=mbrugger@suse.com \
    --cc=philippe.schenker@toradex.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s32@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan.wahren@chargebyte.com \
    --cc=tharvey@gateworks.com \
    --cc=wafgo01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®