From: Randy Dunlap <rdunlap@infradead.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, rafael@kernel.org
Cc: pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] block: Fix non-kernel-doc comment
Date: Mon, 14 Feb 2022 09:14:38 -0800 [thread overview]
Message-ID: <918fe170-51ef-e214-4620-3a82b425965c@infradead.org> (raw)
In-Reply-To: <20220214091522.100669-1-jiapeng.chong@linux.alibaba.com>
Hi--
On 2/14/22 01:15, Jiapeng Chong wrote:
> Fixes the following W=1 kernel build warning:
>
> kernel/power/swap.c:120: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
The diff looks OK to me, but the Subject is quite misleading.
There are no "block:" patch contents here, just "PM:" or
"PM: hibernate:" according to
$ git log --oneline kernel/power/swap.c
> ---
> kernel/power/swap.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 6c4f983cbacc..91fffdd2c7fb 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -88,7 +88,7 @@ struct swap_map_page_list {
> struct swap_map_page_list *next;
> };
>
> -/**
> +/*
> * The swap_map_handle structure is used for handling swap in
> * a file-alike way
> */
> @@ -116,7 +116,7 @@ struct swsusp_header {
>
> static struct swsusp_header *swsusp_header;
>
> -/**
> +/*
> * The following functions are used for tracing the allocated
> * swap pages, so that they can be freed in case of an error.
> */
> @@ -170,7 +170,7 @@ static int swsusp_extents_insert(unsigned long swap_offset)
> return 0;
> }
>
> -/**
> +/*
> * alloc_swapdev_block - allocate a swap page and register that it has
> * been allocated, so that it can be freed in case of an error.
> */
> @@ -189,7 +189,7 @@ sector_t alloc_swapdev_block(int swap)
> return 0;
> }
>
> -/**
> +/*
> * free_all_swap_pages - free swap pages allocated for saving image data.
> * It also frees the extents used to register which swap entries had been
> * allocated.
thanks.
--
~Randy
next prev parent reply other threads:[~2022-02-14 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 9:15 Jiapeng Chong
2022-02-14 17:14 ` Randy Dunlap [this message]
2022-03-02 7:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918fe170-51ef-e214-4620-3a82b425965c@infradead.org \
--to=rdunlap@infradead.org \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®