From: YueHaibing <yuehaibing@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <balbi@kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare_buffer()
Date: Sat, 29 May 2021 20:54:06 +0800 [thread overview]
Message-ID: <91983b80-1818-536d-5ea3-5a38c1cb5443@huawei.com> (raw)
In-Reply-To: <YLIveGTHK5RjxtS+@kroah.com>
On 2021/5/29 20:11, Greg KH wrote:
> On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote:
>> A coccicheck run provided information like the following.
>>
>> ./drivers/usb/gadget/function/f_fs.c:3832:9-16:
>> WARNING: ERR_CAST can be used with data
>>
>> ffs_prepare_buffer() should return an ERR_PTR() encoded error
>> code on failure.
>
> It does return such a pointer today, so this statement does not make
> much sense :(
Yes, it does. This is just to remove explicit casts.
>
> And is this a v2 patch? What changed from the previous version?
Sorry, I forget to add version info.
>
> thanks,
>
> greg k-h
> .
>
prev parent reply other threads:[~2021-05-29 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 12:04 YueHaibing
2021-05-29 12:11 ` Greg KH
2021-05-29 12:54 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91983b80-1818-536d-5ea3-5a38c1cb5443@huawei.com \
--to=yuehaibing@huawei.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®