From: Arnd Bergmann <arnd@arndb.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: tglx@linutronix.de, john.stultz@linaro.org,
heenasirwani@gmail.com, pang.xunlei@linaro.org,
peterz@infradead.org, rafael.j.wysocki@intel.com,
linux-kernel@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [PATCH v3 15/22] time/posix-timers:Convert to the 64bit methods for k_clock callback functions
Date: Tue, 12 May 2015 10:51:38 +0200 [thread overview]
Message-ID: <9198494.K1zFNegC4D@wuerfel> (raw)
In-Reply-To: <1431343239-29961-1-git-send-email-baolin.wang@linaro.org>
On Monday 11 May 2015 19:20:39 Baolin Wang wrote:
> diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h
> index 89beb62..c3345d5 100644
> --- a/include/linux/timekeeping.h
> +++ b/include/linux/timekeeping.h
> @@ -250,9 +250,9 @@ static inline void get_monotonic_boottime64(struct timespec64 *ts)
> *ts = ktime_to_timespec64(ktime_get_boottime());
> }
>
> -static inline void timekeeping_clocktai(struct timespec *ts)
> +static inline void timekeeping_clocktai(struct timespec64 *ts)
> {
> - *ts = ktime_to_timespec(ktime_get_clocktai());
> + *ts = ktime_to_timespec64(ktime_get_clocktai());
> }
>
> /*
>
I believe Thomas has already mentioned before that the change to the
timekeeping_clocktai() function is not obvious here. I'd suggest you
split out the changes here along with the posix_get_tai() that
calls it into its own patch with a good description, and leave all
the simple changes to kernel/time/posix-timers.c in a second patch.
I don't think it's necessary to split up the other changes from
this patch any further. If Thomas or someone else disagrees with this
and wants it more fine-grained, it would be good to say that now.
Arnd
prev parent reply other threads:[~2015-05-12 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 11:20 Baolin Wang
2015-05-12 8:51 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9198494.K1zFNegC4D@wuerfel \
--to=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=heenasirwani@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®