From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367E43921D7 for ; Wed, 25 Feb 2026 18:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772044863; cv=none; b=lIqfs6LuVfz1Im3eU660YBdjHAooQ7j9fcz8KcDiHv9X7W5I8bIJhj6+2N9XweASV5wKcmmuUPD/eOKe7xpAwlj3jPX4I22V1zWtR5SU5tEtVpK0BRIVsivIeKxhnBKQ6AyEW+QDosteTs3mrNTWdeXIXbtC01GODIZSN5RNPtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772044863; c=relaxed/simple; bh=Z1YVB7a1wal1i6joh40lx4ydjh81aD0+AtvxrKUUIUQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=lJ/HwNHMn+LcWkbj0JGC7SqsLPpNTmeS9sECzXmWoDA0LGcrGbiqUl5o3khVt11byO9LD+9tP/tprmQbNERwpPIrbYMHgLsv/4cMTZlGFZoR7oTPqZSNGH+FLHcJS8Pl5ihWqkppHIKVojHVcpZVV2a7Jn0OvhZMS47i9GmS79s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iJC0sWSQ; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iJC0sWSQ" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4398ebdf520so772673f8f.0 for ; Wed, 25 Feb 2026 10:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772044861; x=1772649661; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=h0CMShhitdpQ//FqeZ9cEIzrxTRnPPpN5zlMplF2C/0=; b=iJC0sWSQCnYGgWU8nrm43TgIGqmuPGCnaHUOos2GJxSntNk/f+wVwtRh7r9tKpOKhW lIBJoUYN2pfSlIuCgTaHXKEoPpyaEhl8aros6NySnJW1OSgF2hc+MNELaW0A/LWzn475 iHUmx6Fvy44NELVfM96hL8WUmYT9LPbw0dgqQyL+Kzfk3l99WvllLOYI8ULfkHGAtwzF cdqZKeF4eZyak/y2bs8RrCXswKKTi8RcJlP7Y5gY9cx5ybbLo6s03wRwnVzUcsscUPYX owKydPBRskrjoQLq/Wg773ODBXDrTwla+GOHZqku0cC5vTdfJVqIW9zS1D/z4U7LQFwU 8IkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772044861; x=1772649661; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h0CMShhitdpQ//FqeZ9cEIzrxTRnPPpN5zlMplF2C/0=; b=rxCVyI66X8HqjRM0xB3B4/sSkasGtXzaXfsJP1JYr2ywDUVNWCv8BhOpMJbknWR6b8 hw3HsjuCDWLjEN6ZgiKiIES+K7TwuWZYu/0MSrehqqVgoCADDuw51eBPKFO7Pgvi7pLY SNi2vOI8MW0boPmLo9rnYdf0VsFQF7g4p5o7yGvAac1YUcDWuwnJNas1WfC9wRLWU0Vr A/BozuacAwGTfj3CQqZ6RCeK4/wHaZDgLA9CnfTIv+lV+oD2R3S8hBZ/yNLFfOxKS9NU EeFOj9QSYSxCI7QHOhHXBu9UpMI4CDKAJ+glW7J68P6v6SfEjLXYGMMoRolsFLdMH5hf no1w== X-Forwarded-Encrypted: i=1; AJvYcCVkDc3XewcKbTY+CvrMbYANTZoUex4JvI+08qMXPAf6aZsd6lUogunFd9T0QQGUYLaHr600bOhC7b/1b9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzS9SBuj66nj5p5V6udjtDamJ5GnnQrsOgDDa5DylnF3Wpn2yPH FWp9wGDFvAN1XxjlqV5rwNDw9UgR8QPqUIMw0JBsE6wzQXTi/qPh8/JV X-Gm-Gg: ATEYQzyX79KVDzm8Ftlhnj8xC+4svAzB3Aet2F0lQXNg6MgO9LHxiiClcSDpph9ABnz Fy9yceKjNT9NXcQ/JqXLvsRFK20sCg3cFFjyYxOvUi941AYnPWiBXA+37HZiMXDLTcY5GnYBMc7 IrV53Og2QLuOQQvzyxO7TNDz5xCwjByBeO29xebc67lsebj5WSLPIjsaJBh2JcxM5li8E508M7L EvPKsc/Lz0jm9rYYnk2wQVVfJhUJq7vFXugXIF9bXkAKejLHbcA+TuHaZ5zI3zY6qw1EIY0J8B/ cAKyq+Vv0EUAnGS1DgXA/lf2ZYt5KJ77PLJa4pKfcAKySUumvmOoyX0anlowzbRKYuXUTrz4QDS 3edez57igt99k12/+vfWOoMKpLvqyHQIOhpS54Qig+FtptzOPo4dWe3mSKWunZ7fsjEsWT+v3UT 0l776Ppe84j7LTZclaeDZ0G2MvuErrtbumqTBE X-Received: by 2002:a05:6000:290d:b0:439:96fc:e593 with SMTP id ffacd0b85a97d-4399716a3d9mr204358f8f.0.1772044860354; Wed, 25 Feb 2026 10:41:00 -0800 (PST) Received: from [192.168.100.3] ([105.163.157.182]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d4c977sm38378745f8f.32.2026.02.25.10.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 10:40:59 -0800 (PST) Message-ID: <91997f8f105ca2ef150c605e1045e010524d1135.camel@gmail.com> Subject: Re: [PATCH RFT] drm/bridge: dw-hdmi: Replace calls to deprecated HDMI/audio detection functions From: Erick Karanja To: Maxime Ripard Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Dmitry Baryshkov , Luca Ceresoli , Shengjiu Wang , Andy Yan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 25 Feb 2026 21:40:44 +0300 In-Reply-To: <20260225-lush-dexterous-chimpanzee-ebdb6a@houat> References: <20260225093051.12031-1-karanja99erick@gmail.com> <20260225-lush-dexterous-chimpanzee-ebdb6a@houat> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-02-25 at 11:11 +0100, Maxime Ripard wrote: > Hi, >=20 > On Wed, Feb 25, 2026 at 12:30:50PM +0300, Erick Karanja wrote: > > Replace calls to the deprecated drm_detect_hdmi_monitor() and > > drm_detect_monitor_audio() functions. Calling > > drm_edid_connector_update() > > updates connector->display_info.is_hdmi and connector- > > >display_info.has_audio. > > The driver should read these fields from connector->display_info > > instead of > > calling the deprecated functions directly. > >=20 > > Signed-off-by: Erick Karanja > > --- > > =C2=A0drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +++-------------- > > =C2=A01 file changed, 3 insertions(+), 14 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > index 3b77e73ac0ea..ddc4ae40d94e 100644 > > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > @@ -2472,7 +2472,6 @@ static const struct drm_edid > > *dw_hdmi_edid_read(struct dw_hdmi *hdmi, > > =C2=A0 struct > > drm_connector *connector) > > =C2=A0{ > > =C2=A0 const struct drm_edid *drm_edid; > > - const struct edid *edid; > > =C2=A0 > > =C2=A0 if (!hdmi->ddc) > > =C2=A0 return NULL; > > @@ -2482,19 +2481,9 @@ static const struct drm_edid > > *dw_hdmi_edid_read(struct dw_hdmi *hdmi, > > =C2=A0 dev_dbg(hdmi->dev, "failed to get edid\n"); > > =C2=A0 return NULL; > > =C2=A0 } > > - > > - /* > > - * FIXME: This should use connector->display_info.is_hdmi > > and > > - * connector->display_info.has_audio from a path that has > > read the EDID > > - * and called drm_edid_connector_update(). > > - */ > > - edid =3D drm_edid_raw(drm_edid); > > - > > - dev_dbg(hdmi->dev, "got edid: width[%d] x height[%d]\n", > > - edid->width_cm, edid->height_cm); > > - > > - hdmi->sink_is_hdmi =3D drm_detect_hdmi_monitor(edid); > > - hdmi->sink_has_audio =3D drm_detect_monitor_audio(edid); > > + drm_edid_connector_update(connector, drm_edid); > > + hdmi->sink_is_hdmi =3D connector->display_info.is_hdmi; > > + hdmi->sink_has_audio =3D connector->display_info.has_audio; >=20 > You should get rid of sink_is_hdmi and sink_has_audio, and you'll > don't > need to call any function anymore, deprecated or otherwise. Thank you, sending v2 >=20 > Maxime