mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ren Zhijie <renzhijie2@huawei.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: <njavali@marvell.com>, <GR-QLogic-Storage-Upstream@marvell.com>,
	<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<aeasi@marvell.com>, <himanshu.madhani@oracle.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] scsi: qla2xxx: Fix build error implicit-function-declaration
Date: Mon, 19 Sep 2022 21:20:37 +0800	[thread overview]
Message-ID: <919a7e27-2f61-ad58-b366-078ff058ddef@huawei.com> (raw)
In-Reply-To: <20220919071721.upsccdkhzp3zanui@carbon.lan>


在 2022/9/19 15:17, Daniel Wagner 写道:
> On Mon, Sep 19, 2022 at 11:08:10AM +0800, Ren Zhijie wrote:
>> +#ifdef CONFIG_TRACING
>>   static void
>>   qla_trace_init(void)
>>   {
>> @@ -2868,7 +2871,7 @@ qla_trace_uninit(void)
>>   		return;
>>   	trace_array_put(qla_trc_array);
>>   }
>> -
>> +#endif
> FWIW, the qla2xxx driver uses a different pattern for ifdefs
>
> 	static void
> 	qla_trace_init(void)
> 	{
> 	#ifdef CONFIG_TRACING
> 	[...]
>          #endif
>          }
>
> This avoid to updated the callside with ifdefs.

Thanks, I will send patch v2.

Ren

> .
.

      reply	other threads:[~2022-09-19 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19  3:08 Ren Zhijie
2022-09-19  7:17 ` Daniel Wagner
2022-09-19 13:20   ` Ren Zhijie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=919a7e27-2f61-ad58-b366-078ff058ddef@huawei.com \
    --to=renzhijie2@huawei.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=aeasi@marvell.com \
    --cc=dwagner@suse.de \
    --cc=himanshu.madhani@oracle.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®