From: Mark Asselstine <mark.asselstine@windriver.com>
To: "André Lopes" <andre.neo.net@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
askulysh@image.kiev.ua
Subject: Re: [PATCH] oss: Remove void casts
Date: Mon, 25 May 2009 20:20:04 -0400 [thread overview]
Message-ID: <919fe2b30905251720n24837f56xf24a93ca7bdf89ae@mail.gmail.com> (raw)
In-Reply-To: <5c43c2d40905220627g4036fd80n6f0ef8469e48aa1f@mail.gmail.com>
2009/5/22 André Lopes <andre.neo.net@gmail.com>:
> This trivial patch just remove void cats from sound/oss/sh_dac_audio.c
darn cats got out again :P
s/void cats/void pointer casts/
Regards,
Mark
>
> Signed-off-by: André Lopes <andre.neo.net@gmail.com>
>
> ---
> sound/oss/sh_dac_audio.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/oss/sh_dac_audio.c b/sound/oss/sh_dac_audio.c
> index 78cfb66..7247ea1 100755
> --- a/sound/oss/sh_dac_audio.c
> +++ b/sound/oss/sh_dac_audio.c
> @@ -200,21 +200,21 @@ static ssize_t dac_audio_write(struct file
> *file, const char *buf, size_t count,
> if (count > free)
> count = free;
> if (buffer_begin > buffer_end) {
> - if (copy_from_user((void *)buffer_end, buf, count))
> + if (copy_from_user(buffer_end, buf, count))
> return -EFAULT;
>
> buffer_end += count;
> } else {
> nbytes = data_buffer + BUFFER_SIZE - buffer_end;
> if (nbytes > count) {
> - if (copy_from_user((void *)buffer_end, buf, count))
> + if (copy_from_user(buffer_end, buf, count))
> return -EFAULT;
> buffer_end += count;
> } else {
> - if (copy_from_user((void *)buffer_end, buf, nbytes))
> + if (copy_from_user(buffer_end, buf, nbytes))
> return -EFAULT;
> if (copy_from_user
> - ((void *)data_buffer, buf + nbytes, count - nbytes))
> + (data_buffer, buf + nbytes, count - nbytes))
> return -EFAULT;
> buffer_end = data_buffer + count - nbytes;
> }
> @@ -322,7 +322,7 @@ static void __exit dac_audio_exit(void)
> free_irq(TIMER1_IRQ, 0);
>
> unregister_sound_dsp(device_major);
> - kfree((void *)data_buffer);
> + kfree(data_buffer);
> }
>
> module_init(dac_audio_init);
> --
> 1.5.6.5
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-05-26 0:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 13:27 André Lopes
2009-05-26 0:20 ` Mark Asselstine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=919fe2b30905251720n24837f56xf24a93ca7bdf89ae@mail.gmail.com \
--to=mark.asselstine@windriver.com \
--cc=andre.neo.net@gmail.com \
--cc=askulysh@image.kiev.ua \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®