From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757127AbbCMQnh (ORCPT ); Fri, 13 Mar 2015 12:43:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41632 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbbCMQnd convert rfc822-to-8bit (ORCPT ); Fri, 13 Mar 2015 12:43:33 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v4 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts From: Kumar Gala In-Reply-To: <20150313162516.GA9603@leverpostej> Date: Fri, 13 Mar 2015 11:43:28 -0500 Cc: "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "devicetree@vger.kernel.org" , "heiko@sntech.de" Content-Transfer-Encoding: 8BIT Message-Id: <91E83B79-5004-48C5-948B-7A9FD7F13BFE@codeaurora.org> References: <1426182985-10425-1-git-send-email-galak@codeaurora.org> <20150313105207.GB3592@leverpostej> <04AD8E46-277D-4652-88AF-D16538C2AA87@codeaurora.org> <20150313162516.GA9603@leverpostej> To: Mark Rutland X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 13, 2015, at 11:25 AM, Mark Rutland wrote: > On Fri, Mar 13, 2015 at 03:50:42PM +0000, Kumar Gala wrote: >> >> On Mar 13, 2015, at 5:52 AM, Mark Rutland wrote: >> >>>> +/ { >>>> + chosen { >>>> + stdout-path = &blsp1_uart2; >>>> + }; >>> >>> It would be good if we had the configuration too (see >>> Documentation/devicetree/bindings/chosen.txt), as that avoids any >>> reliance on kernel defaults. >>> >>> You can refer to an alias, so this could be: >>> >>> aliases { >>> serial0 = &blsp1_uart2; >>> }; >>> >>> chosen { >>> stdout-path = "serial0:115200n8"; >>> }; >>> >>> ...assuming that 115200n8 is correct for your UART, of course. >>> >>> >>> […] >> >> Where is the code that actually handles this parsing? I’m not see it >> in early_init_dt_scan_chosen_serial and I don’t believe >> fdt_path_offset does anything special with ‘:' > > Take a look at commit 7914a7c5651a5161 ("of: support passing console options with > stdout-path"). > > Early on of_alias_scan will find the options and in of_console_check > we'll call add_preferred_console as appropriate. That'll be called in > uart_add_one_port. Ok, but earlycon dt code doesn’t utilize this, as its setup is before we unflatten the dt. So it breaks earlycon parsing right now, I’ll look at fixing that. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project