From: Hans de Goede <hdegoede@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable
Date: Tue, 26 Jun 2018 20:29:07 +0200 [thread overview]
Message-ID: <91a98281-979f-9479-a31a-363243948372@redhat.com> (raw)
In-Reply-To: <20180626104740.0067bd5e@gandalf.local.home>
Hi,
On 26-06-18 16:47, Steven Rostedt wrote:
> On Tue, 26 Jun 2018 15:55:34 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
>
>> Replace comments about places where the console lock should be held with
>> calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held.
>
> Why replace the comments? I prefer them, even with the WARN. The reason
> is, when using functions, I don't tend to look inside the function I'm
> about to use, but instead, I expect the comment above the function to
> have basic information I need to use it. Especially what locks are
> expected to be held.
>
> Please keep the comments in place, but the WARNs are fine. They are not
> a replacement for the comments.
>
> Nack on removing comments.
Ok, I will submit a v4 with the comments left in place.
Regards,
Hans
next prev parent reply other threads:[~2018-06-26 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:55 [PATCH v3 0/3] console/fbcon: Add support for deferred console takeover Hans de Goede
2018-06-26 13:55 ` [PATCH v3 1/3] printk: Export is_console_locked Hans de Goede
2018-06-26 13:55 ` [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable Hans de Goede
2018-06-26 14:00 ` Daniel Vetter
2018-06-26 14:47 ` Steven Rostedt
2018-06-26 18:29 ` Hans de Goede [this message]
2018-06-26 13:55 ` [PATCH v3 3/3] console/fbcon: Add support for deferred console takeover Hans de Goede
2018-06-26 17:12 ` Andy Shevchenko
2018-06-26 17:13 ` Andy Shevchenko
2018-06-26 18:29 ` Hans de Goede
2018-06-26 18:49 ` Andy Shevchenko
2018-06-26 18:36 [PATCH v4 0/3] " Hans de Goede
2018-06-26 18:36 ` [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable Hans de Goede
2018-06-27 1:09 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91a98281-979f-9479-a31a-363243948372@redhat.com \
--to=hdegoede@redhat.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®