From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1099D2594B9 for ; Thu, 21 May 2026 08:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779351441; cv=none; b=Z62n10e8i4eiY3lG5tBNtfVYUoMGxJ6W8d2D2sCsr2x6zDEGKQf/i+I6SPrKHXshak1cwfShY9dhvBkR1TPoxDOJVYNSx/6D2aDSk7cQGoNiDcEXvtHkDxl+Nh4D6PGjrYo/g/T/qUElSpN5+Q9cuw4Nz5GBm+XjiCz5qCrg1YA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779351441; c=relaxed/simple; bh=5P5hjZxDYwO2q9ZLPBJEGR5LdLHCMWb9MUIe9M9mId0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=KmOe8gMEA3urRepRPwa+LL/TlaM7dbz2wM/SUVGY+e2Xl+S3SLXWzwplujk4qXnffeKQm1u9g89JLyDyd15MV134v5REsghHG8be0mGJlIKKEn543nDSDftg5U8pzSak7Cco9yo1mSvHjBibPRaxLE5/CjFhO3tVQTgaphOObrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lj61f9X0; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lj61f9X0" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-441209fb77eso3686997f8f.1 for ; Thu, 21 May 2026 01:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779351438; x=1779956238; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Ugf5QDKMZMTAiOA1ypuevR075zMsv/NRbxAQvzE+1ik=; b=lj61f9X0aZjytBNIvJLCVTnul3hxtUmLNoGldmBECSWbMpOzcOXir+rOZG6Q1qsx/H HweLGH0dTeWWifFQkBDEcNJPd1KaRHzt2xR06xgN7y3lgaYc6KZUS2QnRd4h3Skj7E3B ftB8oi193cWRFzKnfCvWbYCazmzFWTUPEtMPIwXiPIwNthMuVWPqlFna2nELSA+yjyvd hJbp1IVgJswBP0OGf9zv5e3rvsZddzN1aTFgMPvlaoQG7XstgDTrmK8piio9CovmkZ6T K3WKEcuAJ0q0xwJaeq/EOf+Cq6mk5NfAWMVr0Wv+ci/wCAgi+9FtyQr8+sT9orJ4tYt4 yGwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779351438; x=1779956238; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ugf5QDKMZMTAiOA1ypuevR075zMsv/NRbxAQvzE+1ik=; b=BT/TCmChq8IeDQ2Mk8Tq+CocWcKOGdd4GcEjkVmoLcSqW99uQZc5Bf8YeAJOtjJxuQ fv/G5YP6nygRG/ZXz92iOGS3aiHpNEwGMfYYCei5oxO9SLSeYHsyapN173xZg0O19OO7 Nsio9pAOpm9V4jTl72PzV6BK9oR+YK6tTFxLL1ivZTw02GUtSslK3smEHnehNRmZQrD5 UM5M6jTsozWX85zn9ECMch2sQUeNkKsR1y1+UA0Y8y+WNFwqqTTnepS9TsouDOh+I3r8 tZMSRu/cvdZaUkNmfE5AuC+wHoqROScpS+taG6r9F3RH5PR/bHtvS74FOPjAsk7sLPAZ BEiA== X-Gm-Message-State: AOJu0YzWuEgzqOae8+E7qH3Aoois7GbNB9813YfcCvs1AT1ef9/IMn3p pDG3gvSAiG7yr+O/E72ZLDo0VbHaEGJ7sZsMW/btBOYOaGjl/i2upb2ME9OYRsulddY= X-Gm-Gg: Acq92OH9KSiWj2J6olrzEHfeQ7UOez1hJ0ZWnAyqABqO+qwzjWvGhPfb4ll+GEfdwOd MJzDom6TjizSrDdQD0RmxXd88512sxIZEv3avysjDSrmkUSp5xJwzUmg0ayXObB7orKM0FX/hfM cQXcgNo1n93zH2NhkFuP+g0p3m+0+7QxcDQ3WfzDXILTI2qafpBJIyc9Vcun0bj4TuMCOY2nRTz V1LZ4UkQK2PV208Oy0aXkTeZICSdcry7Y4rm8dOpvNHyYh3EUMVrOy/4s9lpZVY02jRq85HN43I I/2CuWY/L0f+Or4EsPfx8CME9w46GKicTk0rCus868oMP3gLngkoKx8WqixKjOecop+oNGi/B6h bYW21aTsbn8PRyJqLebPuHQzamJaecOpmqP3+bV7cMIy9KSCT3vZ+O6HJpWwsNEfc+Tni/1YFCh hOUJGSHayJX16uSHJVFLd2271kHcNXXDx9qLKLanfGT9fIG8FhZl6K+pdtpPeV9rVYOQYdYcTaN sXewNW+GkJokGhdsOCHzXlOXQJd X-Received: by 2002:a05:6000:2798:b0:45e:733a:a0ff with SMTP id ffacd0b85a97d-45ea31290bcmr1657841f8f.3.1779351438367; Thu, 21 May 2026 01:17:18 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:e038:7e8a:7467:8c6c? ([2a01:e0a:106d:1080:e038:7e8a:7467:8c6c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eaa93ce5fsm895798f8f.33.2026.05.21.01.17.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 01:17:17 -0700 (PDT) Message-ID: <91ace2b7-a0c7-485f-a464-d7db397e0df7@linaro.org> Date: Thu, 21 May 2026 10:17:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v4 2/2] regulator: add SGM3804 Dual Output driver To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, KancyJoe References: <20260506-topic-sm8650-ayaneo-pocket-s2-sgm3804-v4-0-7495e7905693@linaro.org> <20260506-topic-sm8650-ayaneo-pocket-s2-sgm3804-v4-2-7495e7905693@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260506-topic-sm8650-ayaneo-pocket-s2-sgm3804-v4-2-7495e7905693@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Mark, On 5/6/26 09:34, Neil Armstrong wrote: > From: KancyJoe > > Add support for the SG Micro SGM3804 Single Inductor Dual Output > Buck/Boost Converter used to power LCD panels a provide positive > and negative power rails with configurable voltage and active > discharge function for each output. > > The SGM3804 is powered by the enable GPIO pins inputs and only > supports I2C write messages. > In order to add flexibility and simplify the driver, the > regmap cache is enabled and populated with default values > since we can't write registers when the 2 GPIOs are down. > > Signed-off-by: KancyJoe > Signed-off-by: Neil Armstrong > --- > drivers/regulator/Kconfig | 7 + > drivers/regulator/Makefile | 1 + > drivers/regulator/sgm3804-regulator.c | 308 ++++++++++++++++++++++++++++++++++ > 3 files changed, 316 insertions(+) > I checked the Sahiko review and the reported issues are all false issues that won't happen in real life. Do you see any parts I'll need to improve ? Thanks, Neil