From: "rae l" <crquan@gmail.com>
To: "Jan Engelhardt" <jengelh@computergmbh.de>
Cc: "Rusty Russell" <rusty@rustcorp.com.au>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Dave Young" <hidave.darkstar@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/params.c: fix the module name length in param_sysfs_builtin
Date: Wed, 23 Jan 2008 09:53:16 +0800 [thread overview]
Message-ID: <91b13c310801221753n4e2ca523k877fe758bed54445@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801230011300.9183@fbirervta.pbzchgretzou.qr>
On Jan 23, 2008 7:13 AM, Jan Engelhardt <jengelh@computergmbh.de> wrote:
> But nf..dada_compat.c gets linked into nf_conntrack_ipv4.ko,
> and that is what is used in /sys/module - and it fits the 20.
> Any place where nf_conntrack_l3proto_ipv4_compat would still be used?
there is a module named nf_conntrack_proto_icmp.ko, length 23. and you
can find all them by:
$ make allmodconfig && make modules
$ find -name '*.ko' -printf '%f\n' |gawk '{print length($0), $0}' |sort -n
...
24 dvb-usb-af9005-remote.ko
24 dvb-usb-dibusb-common.ko
25 nf_conntrack_proto_gre.ko
26 nf_conntrack_netbios_ns.ko
26 nf_conntrack_proto_sctp.ko
29 nf_conntrack_proto_udplite.ko
so currently tha max length of module name is 26 (in
nf_conntrack_proto_udplite), but still no any length limit to module
names in Documentation/, so we have to prepare reserved space for
modules later, or mark MODULE_NAME_LEN as the modules' name length
limit in Documentation/?
Simply speaking, MODULE_NAME_LEN does the better job.
>
--
Denis Cheng
next prev parent reply other threads:[~2008-01-23 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 9:08 Denis Cheng
2008-01-21 11:16 ` Rusty Russell
2008-01-22 23:13 ` Jan Engelhardt
2008-01-23 1:53 ` rae l [this message]
2008-01-23 1:54 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2008-01-21 9:20 Denis Cheng
2008-01-19 5:46 rae l
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b13c310801221753n4e2ca523k877fe758bed54445@mail.gmail.com \
--to=crquan@gmail.com \
--cc=gregkh@suse.de \
--cc=hidave.darkstar@gmail.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®