mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 2/4] staging: rtl8723bs: refactor rtw_macaddr_cfg()
Date: Tue, 26 Jun 2018 21:19:28 +0200	[thread overview]
Message-ID: <91b18a3f-260b-44a6-466b-5074f78f3cbd@gmail.com> (raw)
In-Reply-To: <CAHp75Ve7tKAQU9sfCUvWnwHaYkFXHiMS6PTbLdqh-AJOfYQpCw@mail.gmail.com>

On 06/26/18 19:29, Andy Shevchenko wrote:
> On Tue, Jun 26, 2018 at 11:14 AM, Michael Straube
> <straube.linux@gmail.com> wrote:
>> Using is_broadcast_ether_addr() and is_zero_ether_addr() instead of
>> testing each byte of the mac[] array for 0xff and 0x00 shortens the
>> code and improves readability.
>>
>> If np == NULL, of_get_property() returns NULL, hence the "np" check
>> is not needed.
>>
>> Instead of a fixed default mac address use a random one to reduce the
>> likelihood of mac address collision.
>>
> 
>> Thanks to Joe Perches and Dan Carpenter.
> 
> I guess you may use Suggested-by tag as well.
> 

Thanks for the hint, I will add it.

Regards
Michael

  reply	other threads:[~2018-06-26 19:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  8:14 [PATCH v3 1/4] staging: rtl8723bs: fix comparsion to NULL - coding style Michael Straube
2018-06-26  8:14 ` [PATCH v3 2/4] staging: rtl8723bs: refactor rtw_macaddr_cfg() Michael Straube
2018-06-26 17:29   ` Andy Shevchenko
2018-06-26 19:19     ` Michael Straube [this message]
2018-06-26  8:14 ` [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr_cfg() Michael Straube
2018-06-26 17:32   ` Andy Shevchenko
2018-06-26 19:44     ` Michael Straube
2018-06-26 20:17       ` Joe Perches
2018-06-26 20:32         ` Michael Straube
2018-06-26 21:36           ` Joe Perches
2018-06-27  8:33           ` Dan Carpenter
2018-06-27 12:56             ` Michael Straube
2018-06-27 13:11               ` Dan Carpenter
2018-06-27 16:14                 ` Andy Shevchenko
2018-06-27 16:42                   ` Joe Perches
2018-06-27 18:35                     ` Dan Carpenter
2018-06-26  8:14 ` [PATCH v3 4/4] staging: rtl8723bs: use mac_pton() " Michael Straube
2018-06-26 17:34   ` Andy Shevchenko
2018-06-26 20:48     ` Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b18a3f-260b-44a6-466b-5074f78f3cbd@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®