From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DB7C4167B for ; Thu, 10 Dec 2020 23:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73BC923B85 for ; Thu, 10 Dec 2020 23:07:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404362AbgLJWb3 (ORCPT ); Thu, 10 Dec 2020 17:31:29 -0500 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:39302 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2405080AbgLJWU4 (ORCPT ); Thu, 10 Dec 2020 17:20:56 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id D8DAB180374C4; Thu, 10 Dec 2020 22:20:14 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: pipe78_48138e9273fb X-Filterd-Recvd-Size: 1865 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Thu, 10 Dec 2020 22:20:13 +0000 (UTC) Message-ID: <91b4b2f3591e6e8ce2d61daae31f2218d1a12b9e.camel@perches.com> Subject: Re: [RFC PATCH v2] checkpatch: rewrite Kconfig parsing From: Joe Perches To: Nicolai Fischer , linux-kernel@vger.kernel.org Cc: apw@canonical.com, johannes.czekay@fau.de, linux-kernel@i4.cs.fau.de Date: Thu, 10 Dec 2020 14:20:12 -0800 In-Reply-To: References: <97fb4ba0-68b3-8faf-1d98-e4990b2e63e3@fau.de> <776550b7fac3870e65e903f0d8cb917dec58f7c2.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-12-09 at 15:24 +0100, Nicolai Fischer wrote: > We understand that checkpatch may not be the ideal place for all of these checks. So please work on an ideal thing. > However the current implementation has some problems we would like to fix. > Would you be interested in a patch series addressing just the check for the number of lines? > Specifically: > 1) > > > > > > > > I believe all the '---help---' lines have been converted to just 'help' > > > so the '(?:---)?' bits here could be removed. > > > > Yes. > > > 2) add string, hex and int types to the $is_start regex sure > 3) improve the help message to include the number of present and expected lines no. The concept of a required paragraph is still dubious. > 4) Warn if help text is not followed by a blank line or endif How often is it now not followed by a blank line or endif?