mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
To: Mukesh Ojha <mojha@codeaurora.org>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, kstewart@linuxfoundation.org,
	gregkh@linuxfoundation.org, jeremie.galarneau@efficios.com,
	shawn@git.icu, tstoyanov@vmware.com, tglx@linutronix.de,
	alexey.budankov@linux.intel.com, adrian.hunter@intel.com,
	songliubraving@fb.com, ravi.bangoria@linux.ibm.com
Subject: Re: [PATCH V1]Perf: Return error code for perf_session__new function on failure
Date: Thu, 22 Aug 2019 16:11:33 +0530	[thread overview]
Message-ID: <91b4e3c1-d2b3-c8a0-088d-1ff6466873ca@linux.vnet.ibm.com> (raw)
In-Reply-To: <a35bc9b3-f9af-1cfc-160c-b5951d5d994b@codeaurora.org>


On 21/08/19 1:07 AM, Mukesh Ojha wrote:
>
> On 8/20/2019 4:51 PM, Mamatha Inamdar wrote:
>> This Patch is to return error code of perf_new_session function
>> on failure instead of NULL
>> ----------------------------------------------
>> Test Results:
>>
>> Before Fix:
>>
>> $ perf c2c report -input
>> failed to open nput: No such file or directory
>>
>> $ echo $?
>> 0
>> ------------------------------------------
>> After Fix:
>>
>> $ ./perf c2c report -input
>> failed to open nput: No such file or directory
>>
>> $ echo $?
>> 254
>>
>> Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
>> Acked-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>> Reported-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
>> Tested-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
>
> Looks good to me.
>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
> Thanks,
> Mukesh
>
Mukesh,

Thanks for reviewing the patch..


  reply	other threads:[~2019-08-22 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 11:21 Mamatha Inamdar
2019-08-20 19:37 ` Mukesh Ojha
2019-08-22 10:41   ` Mamatha Inamdar [this message]
2019-08-21  7:05 ` Jiri Olsa
2019-08-22  7:03   ` Mamatha Inamdar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b4e3c1-d2b3-c8a0-088d-1ff6466873ca@linux.vnet.ibm.com \
    --to=mamatha4@linux.vnet.ibm.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremie.galarneau@efficios.com \
    --cc=jolsa@redhat.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mojha@codeaurora.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=shawn@git.icu \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=tstoyanov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome