From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] slimbus: core: check get_addr before removing laddr ida
Date: Fri, 25 Sep 2020 13:42:25 +0100 [thread overview]
Message-ID: <91b5383a-4d10-24eb-8db4-9cdc75982102@linaro.org> (raw)
In-Reply-To: <20200925124101.GB2732292@kroah.com>
On 25/09/2020 13:41, Greg KH wrote:
> On Fri, Sep 25, 2020 at 10:55:18AM +0100, Srinivas Kandagatla wrote:
>> logical address can be either assigned by the SLIMBus controller or the core.
>> Core uses IDA in cases where get_addr callback is not provided by the
>> controller.
>> Core already has this check while allocating IDR, however during absence
>> reporting this is not checked. This patch fixes this issue.
>>
>> Fixes: 46a2bb5a7f7ea("slimbus: core: Add slim controllers support")
>
> Nit, you need a ' ' before the '(' character...
>
Not sure how I missed that :-)
> Also, you don't need all of those characters, you have 1 more than
> necessary :)
>
> I'll go fix it up.
Thankyou very much for fixing this up!
--srini
>
> greg k-h
>
next prev parent reply other threads:[~2020-09-25 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 9:55 [PATCH 0/3] slimbus: fixes for 5.10 Srinivas Kandagatla
2020-09-25 9:55 ` [PATCH 1/3] slimbus: core: check get_addr before removing laddr ida Srinivas Kandagatla
2020-09-25 12:41 ` Greg KH
2020-09-25 12:42 ` Srinivas Kandagatla [this message]
2020-09-25 9:55 ` [PATCH 2/3] slimbus: core: do not enter to clock pause mode in core Srinivas Kandagatla
2020-09-25 9:55 ` [PATCH 3/3] slimbus: qcom-ngd-ctrl: disable ngd in qmi server down callback Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b5383a-4d10-24eb-8db4-9cdc75982102@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®