From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Jordan Rife <jrife@google.com>
Cc: acme@kernel.org, alexander.shishkin@linux.intel.com,
andrii.nakryiko@gmail.com, ast@kernel.org, bpf@vger.kernel.org,
joel@joelfernandes.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, mhiramat@kernel.org, mingo@redhat.com,
mjeanson@efficios.com, namhyung@kernel.org, paulmck@kernel.org,
peterz@infradead.org, rostedt@goodmis.org, tglx@linutronix.de,
yhs@fb.com
Subject: Re: [RFC PATCH v4 4/4] tracing: Add might_fault() check in __DO_TRACE() for syscall
Date: Wed, 30 Oct 2024 10:42:43 -0400 [thread overview]
Message-ID: <91b9202c-6124-44ec-9d44-4556fa21dd41@efficios.com> (raw)
In-Reply-To: <20241029002814.505389-1-jrife@google.com>
On 2024-10-28 20:28, Jordan Rife wrote:
>> I can test this later today. Considering there needs to be a fix on
>> the BPF side to fully resolve the use-after-free issue reported by
>> syzbot, I may combine your v4 patch with the bandaid fix which chains
>> call_rcu->call_rcu_tasks_trace I made earlier while running the
>> reproducer locally.
>
> Testing this way, the series LGTM. Here's what I did starting from
> linux-next tag next-20241028.
[...]
> Tested-by: Jordan Rife <jrife@google.com>
>
Thanks! I'll add your tested-by tags and send a v5 non-RFC.
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2024-10-30 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 19:09 [RFC PATCH v4 0/4] Faultable syscall tracepoints updates Mathieu Desnoyers
2024-10-28 19:09 ` [RFC PATCH v4 1/4] tracing: Introduce tracepoint extended structure Mathieu Desnoyers
2024-10-28 19:09 ` [RFC PATCH v4 2/4] tracing: Introduce tracepoint_is_faultable() Mathieu Desnoyers
2024-10-28 20:19 ` Andrii Nakryiko
2024-10-28 20:24 ` Mathieu Desnoyers
2024-10-28 19:09 ` [RFC PATCH v4 3/4] tracing: Fix syscall tracepoint use-after-free Mathieu Desnoyers
2024-10-28 19:09 ` [RFC PATCH v4 4/4] tracing: Add might_fault() check in __DO_TRACE() for syscall Mathieu Desnoyers
2024-10-28 19:58 ` Mathieu Desnoyers
2024-10-28 20:20 ` Andrii Nakryiko
2024-10-28 20:25 ` Mathieu Desnoyers
2024-10-28 20:40 ` Jordan Rife
2024-10-29 0:28 ` Jordan Rife
2024-10-30 14:42 ` Mathieu Desnoyers [this message]
2024-10-30 14:59 ` Alexei Starovoitov
2024-10-30 17:34 ` Jordan Rife
2024-10-30 17:39 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b9202c-6124-44ec-9d44-4556fa21dd41@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=joel@joelfernandes.org \
--cc=jrife@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mjeanson@efficios.com \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®