From: Joe Perches <joe@perches.com>
To: Oded Gabbay <oded.gabbay@gmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/15] habanalabs: print pointer using %p
Date: Fri, 01 Mar 2019 17:00:20 -0800 [thread overview]
Message-ID: <91b9cfc4a87bfd7a220f558f514e322f4864b13e.camel@perches.com> (raw)
In-Reply-To: <20190228095545.30842-2-oded.gabbay@gmail.com>
On Thu, 2019-02-28 at 11:55 +0200, Oded Gabbay wrote:
> Don't cast pointer to u64 to print it. Instead, print the pointer using
> %p.
You might want to use %px here if you _really_
want the actual address and not the hashed output
%p normally produces.
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
[]
> @@ -4276,9 +4276,8 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev,
> return 0;
>
> dev_err(hdev->dev,
> - "Internal CB address 0x%llx + 0x%x is not in SRAM nor in DRAM\n",
> - (u64) (uintptr_t) parser->user_cb,
> - parser->user_cb_size);
> + "Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n",
> + parser->user_cb, parser->user_cb_size);
next prev parent reply other threads:[~2019-03-02 1:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 9:55 [PATCH v2 08/15] habanalabs: add comments in uapi/misc/habanalabs.h Oded Gabbay
2019-02-28 9:55 ` [PATCH 11/15] habanalabs: print pointer using %p Oded Gabbay
2019-02-28 12:01 ` Greg KH
2019-02-28 12:59 ` Oded Gabbay
2019-03-02 1:00 ` Joe Perches [this message]
2019-03-02 9:36 ` Oded Gabbay
-- strict thread matches above, loose matches on Subject: below --
2019-02-28 8:46 [PATCH 00/15] habanalabs fixes for merge window Oded Gabbay
2019-02-28 8:46 ` [PATCH 11/15] habanalabs: print pointer using %p Oded Gabbay
2019-02-28 9:31 ` Greg KH
2019-02-28 9:47 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b9cfc4a87bfd7a220f558f514e322f4864b13e.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®