From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB03CC04A94 for ; Tue, 8 Aug 2023 18:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234207AbjHHSrl convert rfc822-to-8bit (ORCPT ); Tue, 8 Aug 2023 14:47:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbjHHSrN (ORCPT ); Tue, 8 Aug 2023 14:47:13 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 760F718C27 for ; Tue, 8 Aug 2023 09:54:07 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTN3N-0007vq-GY; Tue, 08 Aug 2023 15:47:17 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qTN3M-001znp-S1; Tue, 08 Aug 2023 15:47:16 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1qTN3M-000DVl-1E; Tue, 08 Aug 2023 15:47:16 +0200 Message-ID: <91b9f4b385e4fbeda391a7216bb778ffada2a4fa.camel@pengutronix.de> Subject: Re: [PATCH] reset: ath79: remove unneeded call to platform_set_drvdata() From: Philipp Zabel To: Andrei Coardos , linux-kernel@vger.kernel.org Cc: Alexandru Ardelean Date: Tue, 08 Aug 2023 15:47:16 +0200 In-Reply-To: <20230803104102.29647-1-aboutphysycs@gmail.com> References: <20230803104102.29647-1-aboutphysycs@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Do, 2023-08-03 at 13:41 +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Reviewed-by: Alexandru Ardelean > Signed-off-by: Andrei Coardos Thank you, applied to reset/next. regards Philipp