From: Joe Perches <joe@perches.com>
To: Kees Cook <keescook@chromium.org>,
Andy Whitcroft <apw@canonical.com>,
yashsri421@gmail.com
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Don't count URLs for "line too long"
Date: Mon, 26 Sep 2022 22:40:50 -0700 [thread overview]
Message-ID: <91bb341a01ad5cfe4269ef6857387cf3db9619d0.camel@perches.com> (raw)
In-Reply-To: <20220927021517.1952202-1-keescook@chromium.org>
On Mon, 2022-09-26 at 19:15 -0700, Kees Cook wrote:
> URLs (not in a Link: field) should be ignored for "line too long"
> warnings. Allow any line containing "https://" or "http://".
More generally, this should be for any URI
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3175,6 +3175,8 @@ sub process {
> # file delta changes
> $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ ||
> # filename then :
> + $line =~ /https?:\/\// ||
> + # URLs
> $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
> # A Fixes: or Link: line or signature tag line
> $commit_log_possible_stack_dump)) {
And I don't recollect why this wasn't applied, but I think it's a rather better,
more complete, patch:
https://lore.kernel.org/lkml/20210114073513.15773-2-yashsri421@gmail.com/
I believe I did ack it and forward it to Andrew Morton, but I don't
see it on a lore list.
next prev parent reply other threads:[~2022-09-27 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 2:15 Kees Cook
2022-09-27 5:40 ` Joe Perches [this message]
2022-09-27 14:07 ` Kees Cook
2022-09-27 20:39 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91bb341a01ad5cfe4269ef6857387cf3db9619d0.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®