From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0D331A7E1 for ; Tue, 10 Feb 2026 11:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770723278; cv=none; b=uL0uro7icN4/7UTfIYcdTizDUZT33rHU0/6kH86v91mniMFHD9VjYMFSc5rjYEVWb+vrWzuAS0NcoV9a0MZjDQJCdq6aJlwTK0r7TzU15RK9ti+dL3qIqIvev5fFPE7uQruiopelMLGUac2ISKxieQJG/kN8Kmvgo8gr900yJls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770723278; c=relaxed/simple; bh=0XlU4UF/dEnFM5DVWlqZdEpM8W27PO+fZX0aFMTUInQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=nLwnQO6h4aQFD3QTfqbe+MFFgjUxVn/YtXeAAEav21637wQfl3EOz4ImjrVMAG0qpw2WoPMPIiEFJXHSzu7KLtvPTqyNqJFqCMNlgjWMe2N74s4IMNXCEqw/H/4JHklBI13XFgi2adreY9gevTPDzBpYIl46CxdYpuOsXMMo9R8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=O1yrQihm; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O1yrQihm" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so10956045e9.0 for ; Tue, 10 Feb 2026 03:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770723275; x=1771328075; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Z07aATYx5EWzbVAHnzDe0erl/Knn/2f3Dl8/hpKRvCU=; b=O1yrQihmpXN62Az98JsyW1mqAdTR1IxjmohOqJ/9qlE7owGC5y1ORA2ma3avBARpZe Ng8lrPkffsgNRt8CGlhp5qbEue+aNKC5RiIIbNjb0vw/FOK6FDFOG245+y/GfNMjGzvW H1KhoUNXJ2Ta8qIdU97RyTPEhBGt18XiJVpoly3DSeZ8hZkvnLEQylKbdTwkNjCvYFOt bUUKaN9rD910GrjX3w8Es5CHf0EO9PYWULmoKSnND+LuVlLki717/JPj8IG+wX9/jBnk FumInm41OzxGMPYyY/z9d9bcQnH/w68QYe/i7mHwnpnpKQVteBLVRdNKOzFOOokZJjsY YSdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770723275; x=1771328075; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z07aATYx5EWzbVAHnzDe0erl/Knn/2f3Dl8/hpKRvCU=; b=U6Zl7V2uEw2kxAcSQqt3u3KEBNUDY8ikq0VTLAaOWvnKK0sjegnoZppiOmBVpX6jqh 8qEh8gWMTnFA98idGRUuobldf3AODYTXjQ+OdxVs55iIcgotRhD+5b/r30eTJ2W5cYnb S8rTiYQg0HK0Y23F3Rs7dLZVLHoaPHkGiFAdHnXaCUqFGZ6EX3yNOqlwHp9pE4Juxwtn IK5cfF6cka/GCEOwKN6upmSWMUdfzvAQzkujb3dHpEtBVmwSOzMk6gkrHte1zuLf8HJY s7iaLcW9oBr7sqWxFPe1d4DieR+DJOVTnR+/RghheivQaZghgpsWqZBuL68nnn04IWM2 FcdQ== X-Gm-Message-State: AOJu0Yw1pQ8oOPSXdw1xwKO39jN3yxfci3yKh/X3tV3eCQJMclmkvT3P 1QcK11biIk6kVRAPr5BcyYhY8r7TOwSKEyfPofA/9nNmJy7yGc1qXlNjgFrlBcirTkA= X-Gm-Gg: AZuq6aLbwzV847YKWNNZrAtMVForm6BcJ8xGvnCh9D9eAMO1g/pFLzjb4HfY3FHYJoa Zxye8Mm6AroHgTjtrgHvMHjXoPC/oDWQYjhsktInkXL23DGUjqSLhrLxcj/gzJ+KEy7txTaNZV1 7KCoMVim6uvdSuysh184YcuFkHSZuulwQluyhZ3WB7dQJXaLgjDhoobgQ8Oz7kKDa/7L61D4kX9 DrMNNVTZQCmMFunFht9891HdD9YQFdsWdwPhqWw0NP1xX5xBZaOfbRzTJCjigR4WlQdEBPnacXB x5aVRp6FgAaUgk0kf5yHIwClly9PXVt5pAINTxvFU/GlWUJYmdrEKqwAMzNVnYkWZ4Kgeu6kKMs kuauiW9zMMdVsSHDJviTkp0iXHI+LVPtEuMfoScbj3uQqBAc2lvJk2k8kxXyWVRhS7RoqJFfN2/ 5QQL3hMAMdKokO8aycsq52/oLKylTcGg== X-Received: by 2002:a05:600c:3b83:b0:483:4a95:66da with SMTP id 5b1f17b1804b1-4834a956702mr52464855e9.13.1770723274782; Tue, 10 Feb 2026 03:34:34 -0800 (PST) Received: from draszik.lan ([212.129.79.225]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4832911312esm113766395e9.5.2026.02.10.03.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 03:34:33 -0800 (PST) Message-ID: <91c191bf483512ae10850648a23037e0ca23e3d4.camel@linaro.org> Subject: Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb() From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Dan Carpenter Date: Tue, 10 Feb 2026 11:35:01 +0000 In-Reply-To: <1300929e-7b47-45d2-a863-778fd3012a76@kernel.org> References: <20260209-s2mpg1x-regulators-fixes-v1-0-ead348e64e14@linaro.org> <20260209-s2mpg1x-regulators-fixes-v1-1-ead348e64e14@linaro.org> <170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org> <4f1b1d857c0ee17436cd61e97219f508bd89f917.camel@linaro.org> <1e8ee0ae-a74d-418a-80b1-4d2379614548@kernel.org> <0ee40d36397bfd4c04aea6ead07e42848203e9d6.camel@linaro.org> <1300929e-7b47-45d2-a863-778fd3012a76@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-02-10 at 11:51 +0100, Krzysztof Kozlowski wrote: > On 10/02/2026 10:37, Andr=C3=A9 Draszik wrote: > > Hi Krzysztof, > >=20 > > On Tue, 2026-02-10 at 08:28 +0100, Krzysztof Kozlowski wrote: > >=20 > >=20 > > > I also wonder why you left the second - ext_control_s2mpg11 - untouch= ed. > >=20 > > Could you point me to it please? I'm not sure I see what you mean. >=20 > There is exact same line, which you touch here, ~20 lines below. At > least in linux-next from 5th Feb. So you mean https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/dr= ivers/regulator/s2mps11.c#n506 ? It is part of the patch: diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 2d5510acd0780ab6f9296c48ddcde5efe15ff488..2d67c5c16f487506a2e9e4b119f= 33faa846269f7 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -478,8 +478,6 @@ static int s2mpg10_of_parse_cb(struct device_node *np, return -EINVAL; } =20 - if (ext_control > ARRAY_SIZE(ext_control_s2mpg10)) - return -EINVAL; ext_control =3D ext_control_s2mpg10[ext_control]; break; =20 @@ -503,8 +501,6 @@ static int s2mpg10_of_parse_cb(struct device_node *np, return -EINVAL; } =20 - if (ext_control > ARRAY_SIZE(ext_control_s2mpg11)) - return -EINVAL; ext_control =3D ext_control_s2mpg11[ext_control]; break; =20 Otherwise I still don't see it :-) Cheers, Andre'