From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23678C433B4 for ; Mon, 10 May 2021 18:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAF4E6146E for ; Mon, 10 May 2021 18:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232117AbhEJSx3 (ORCPT ); Mon, 10 May 2021 14:53:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47352 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbhEJSx1 (ORCPT ); Mon, 10 May 2021 14:53:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620672742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7j+izsokRqpT308sJPWfxVQOB87GOP9BtFazVppLoQ=; b=JHZkCTl9S7E9Q64u7dqEEJyzhvgUoT/t5/iUQPDnElNlt3ORpL15iz7sloP7M6IOnzM7CK roNTysVtV8/GsTH3DjBNb95DwL15q/t5CLOxt1vb29ZVaGlJD0fKgllkwQdbHpkFSfzY4s txGYYD7jJVr5UMzITeK1DREeig9J8ok= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-z31LuRnTOEm6OyHadIYgrg-1; Mon, 10 May 2021 14:52:18 -0400 X-MC-Unique: z31LuRnTOEm6OyHadIYgrg-1 Received: by mail-qk1-f199.google.com with SMTP id d201-20020ae9efd20000b02902e9e9d8d9dcso12353773qkg.10 for ; Mon, 10 May 2021 11:52:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=g7j+izsokRqpT308sJPWfxVQOB87GOP9BtFazVppLoQ=; b=YGbgCJuS2HruPTXo0IGSbHK+XPjH+hjmLQdZrVhPkRhBsBiO/LtHh1dk/Dv+z7F9LY BxO2A/oxA4L2ArwE8pJXodi2jHIW8LjWBL0Kw163M0fAGTpTTHjKBJDFczBU3Ks2RAFU rRhIsnFU9P7EaUKuJRoDp1bpUJUoHT/Qc7TRVZ6anaWYvEFCiUmPxd2DUSsh1FwLXiaD oz5y/PU6pWwOhpWgT63tu8qUaG9yn7je8PZEfm5rAZAOTYkMuOsjfGSsF+21gG1uC+Kj kX4zyKNC6TGpVHSIyu/K75mAwVhB1FQkefAKg0jDdRhJqR873Je99P2zD4tLTAYNMbzq gTwg== X-Gm-Message-State: AOAM532zGGyAJsuqNuJqSWwVyEVF0fwHuWngSf4fdWYKlDspqgHwtUb9 6OJ/NNrU16x8Rt2Iu5EZPaKKQei3m7C6TXqK00BSaeRwTGAyQmXSVa8PuAXZyOEYH0/hES8FIXc mZIvSt67UP0HGvX0Z3aupPuCw X-Received: by 2002:a05:620a:2912:: with SMTP id m18mr24874752qkp.475.1620672737973; Mon, 10 May 2021 11:52:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzslxJCI13N/HGEQf/0CdbPdBfh/ACVbIw9n9wIQ9PcwW2U4mKsFsbmO04LbWfLWQIMFWZd5A== X-Received: by 2002:a05:620a:2912:: with SMTP id m18mr24874733qkp.475.1620672737751; Mon, 10 May 2021 11:52:17 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id u9sm12338360qtf.76.2021.05.10.11.52.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 11:52:17 -0700 (PDT) Subject: Re: [PATCH v12 0/7] FPGA Security Manager Class Driver To: Moritz Fischer Cc: Russ Weight , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com, matthew.gerlach@intel.com, richard.gong@intel.com References: <20210503213546.316439-1-russell.h.weight@intel.com> <6f3ce0db-883e-2c5b-e671-9ccc363ee532@redhat.com> From: Tom Rix Message-ID: <91d29fc4-ac04-270a-f73a-e1dd3ba2965f@redhat.com> Date: Mon, 10 May 2021 11:52:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/21 10:37 AM, Moritz Fischer wrote: > On Mon, May 10, 2021 at 07:12:57AM -0700, Tom Rix wrote: >> On 5/3/21 2:35 PM, Russ Weight wrote: >>> The FPGA Security Manager class driver provides a common >>> API for user-space tools to manage updates for secure FPGA >>> devices. Device drivers that instantiate the FPGA Security >>> Manager class driver will interact with a HW secure update >>> engine in order to transfer new FPGA and BMC images to FLASH so >>> that they will be automatically loaded when the FPGA card reboots. >> Russ, >> >> These have my Reviewed-by, but since it has been a while, I am looking these >> over again. >> >> If you do not hear anything from me in the next couple of days, please >> assume everything is fine. >> >> Tom >> > I'll do one more one-over, if it looks good will apply end of the week, FWIW, my pass was fine. Thanks, Tom > > - Moritz >