From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18CC2254849 for ; Tue, 23 Dec 2025 11:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766489295; cv=none; b=rKCtF3GurqtwFF7Fqc4Uo5O5bMcwVuS+0fn+R3YJPYthxfPE9yuwxJjPkeIe1eylz+XFkC+4OQIuxDxsymioWSmuMjspE39jObgtiAs8LgjH4A8srP0AbyaFgdXw1/tcmak+0wN4vPQtj+WHUBvGXuoaB+mH9/SBLO6VCiirc84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766489295; c=relaxed/simple; bh=RgW/8V+hhXXLMxh2ZD0gO3zj5swpvL2VBQs3M7Qz7hA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XNNlVvNGis3fI7Rc12i4kHv3o9eVC4FmHIZekUsW9Nn6LYeAjOf+zC3rtNkwxCdS/mzt4e9nLUu2muwSMnSr4sTYn2hMCyN2rIhkkEs7wMCEQiRZPctrnVPNbuCxeMA1zbA4IPula0tLjt7ckYmSK44iBc9c1vrc1E4A8UhnJ1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WShNkOmw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=JX3pmpJp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WShNkOmw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="JX3pmpJp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766489291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=onfWSIfZZxCxgUeBk1t87PeUwtH8Jr8hx54o4pMbZFY=; b=WShNkOmw9Su57EnKDXjzTBRLf51Uzc830MB5Nfp8dUT4RuCFr6svxR75aEXZG5LYQLMnub t6j0TT5nM/E3RQgawjuSwfUhBakDBTBULGsjlcESnKAUpYyOZCyT4oeFCoaSWQf8PWQAS5 zzOCcu34qeNvpHyYigxQpH2Pcypbvyg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155--NxnPCnAM0KFd8TNtEGPBw-1; Tue, 23 Dec 2025 06:28:10 -0500 X-MC-Unique: -NxnPCnAM0KFd8TNtEGPBw-1 X-Mimecast-MFC-AGG-ID: -NxnPCnAM0KFd8TNtEGPBw_1766489289 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47788165c97so27875545e9.0 for ; Tue, 23 Dec 2025 03:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766489289; x=1767094089; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=onfWSIfZZxCxgUeBk1t87PeUwtH8Jr8hx54o4pMbZFY=; b=JX3pmpJp57LqdPpJ09R13Dr9G8gR8ljK5HPzrgJ91UXeODwTDZb9cLG1e8+qEG3l27 AHwZVAan1ppLMX0WQdQpBtjBJ2fT9wRRgGmwAS3eKiP8BbnZPM9a9J7lLw7k+Zs6DjsZ S5XAP1p3i4CH5kOmxuko0pK3Ig7ZQ29qflGJSo7WiFDN1llirllbyR7De6Wyxkd/B8t3 nEjuJjgeaDcqQyhrhUWmM1wI5vhJOZIsYzrbokaJ3dpBGU6boyUaQWs9otmX59R4Yf3N SRrs+Da8H6aSUI6EPKIXnKpiNrqfhbSezX6+ZJ3mp4G2Tl2gbxvezG9BRh/qUM3ZWUxz Of3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766489289; x=1767094089; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=onfWSIfZZxCxgUeBk1t87PeUwtH8Jr8hx54o4pMbZFY=; b=bFEWOjKK9qSVwY5xCXy+sQuBRedmcNdMl/GEbzWz4kWqD7IhRyljiO4m4+JRB9OND0 l+C4JoPt9WRIUa6UhNmOdhbS+E6Bdj1h7xE0JkkivNS5xvHxT/YXVAoqCZasx7LrUYKK MaetwjaFwTmW14WB3nd8cYgZ8g8QxcbyTXZn/YUblIDs6K0bXWtwa7ooG8I0M97RLOOt Qcv9VMXKNKxgFPAQPDCx1jt3hjAYlPvQYffKIIDGAmlQGKfM+dlgYigjeMwjJK2azUFe aSmMQtvZ/zn6CaysiyOufAtayyzD8P5HX3mzSqOuSx4LrWaFELSV4+40vqYxKufjiuoT agKg== X-Forwarded-Encrypted: i=1; AJvYcCUcr1bOVIsEix8ZbiXk/PRtJpH0Y688V2uC/9yj1S66M5SsBva+M9dAFHPRkbZ4p+x9wjXA1WO3ltJn6Sc=@vger.kernel.org X-Gm-Message-State: AOJu0YyT92AgW2dnmXA7c9PfgaHbmsAiFTvRj3t0ihzkR5A+3NCvTIN5 dFTSeYwnPAeFAuvGlU+x0wkdswOt8P+vxi9T7l3R2681Qeko/EI2X4L5K1hC7h831A2//HDgbR9 kQKqEXKoQF/wBgLd9ie7/KEOpeMw0aSzPr1pSQyoENo7JjqTUwPaVxk09AkExXoy17g== X-Gm-Gg: AY/fxX4NTpiA3CcEouER9RdnvD1bRTbfe7GIV/COwl9ptnA5Q3XD7u2oLunwaszcr7l cMIj6v9rlhl0Jk2IkJ3YoiQb9NjYRxr6Fqbsmxap2N4LHLlGiEt450hlqFLmYmizM7oLjs22hxy iFcHOrdvXcD5gmZ+yjD0VSa7wPJwLq9hWD03eFb+ptsGb6XN+fCftITF/niTiOT3eIjrZ9bMUxx 5tzcPOUlbRLZHO6QgwagJp7bR0uk6xA38IggXfck68/XLtnCpP4oW4AEPfc/jXq0gwbhZHD/yyY xIAtFSOtVrjqUoQ5354OGPT15hzmFm/2AkPfsdg/C5anVCQgJH4MuQnFixKzYtxjY2IIxF2gxqT /XEirpRvg6mZ+ X-Received: by 2002:a05:600c:470e:b0:46e:506b:20c5 with SMTP id 5b1f17b1804b1-47d19589469mr139632745e9.26.1766489288924; Tue, 23 Dec 2025 03:28:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4LeHi3yY22vGkPD7kF27exlEuU9vK2kNrrWTIhwglW3gPfsUmNL29FuUOPiEYjgWzdUA9Aw== X-Received: by 2002:a05:600c:470e:b0:46e:506b:20c5 with SMTP id 5b1f17b1804b1-47d19589469mr139632345e9.26.1766489288407; Tue, 23 Dec 2025 03:28:08 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.164]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27c2260sm282256475e9.15.2025.12.23.03.28.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 03:28:07 -0800 (PST) Message-ID: <91d7740a-b340-449d-98e3-d3cf0aae5f78@redhat.com> Date: Tue, 23 Dec 2025 12:28:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v1] net: phy: mxl-86110: Add power management and soft reset support To: Stefano Radaelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stefano Radaelli , Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski References: <20251216162534.141825-1-stefano.r@variscite.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251216162534.141825-1-stefano.r@variscite.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/16/25 5:25 PM, Stefano Radaelli wrote: > Implement soft_reset, suspend, and resume callbacks using > genphy_soft_reset(), genphy_suspend(), and genphy_resume() > to fix PHY initialization and power management issues. > > The soft_reset callback is needed to properly recover the PHY after an > ifconfig down/up cycle. Without it, the PHY can remain in power-down > state, causing MDIO register access failures during config_init(). > The soft reset ensures the PHY is operational before configuration. > > The suspend/resume callbacks enable proper power management during > system suspend/resume cycles. > > Fixes: b2908a989c59 ("net: phy: add driver for MaxLinear MxL86110 PHY") > Signed-off-by: Stefano Radaelli You need to add a suitable From: tag at the body start, or use the same email address as the sender, whatever you prefer. Also the resume/callback bits are IMHO more new features than fixes, but I will not push back hard against them. Thanks, Paolo