mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Laura Abbott <labbott@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Michael Ellerman <mpe@ellerman.id.au>
Cc: kvm@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: compilation failure with CONFIG_VFIO_PCI_NVLINK2
Date: Mon, 7 Jan 2019 13:58:00 +1100	[thread overview]
Message-ID: <91da4363-fed8-a09e-b657-6c10f2b6c33a@ozlabs.ru> (raw)
In-Reply-To: <2e4484ae-06b7-0de3-db8e-3a6989fac1f7@redhat.com>



On 04/01/2019 02:08, Laura Abbott wrote:
> On 1/3/19 5:49 AM, Alexey Kardashevskiy wrote:
>>
>>
>> On 03/01/2019 03:37, Laura Abbott wrote:
>>> Hi,
>>>
>>> I got a compilation failure when building with CONFIG_VFIO_PCI_NVLINK2
>>> enabled:
>>>
>>> + make -s 'HOSTCFLAGS=-O2 -g -pipe -Wall -Werror=format-security
>>> -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
>>> -fstack-protector-strong -grecord-gcc-switches
>>> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
>>> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mcpu=power8
>>> -mtune=power8 -fasynchronous-unwind-tables -fstack-clash-protection'
>>> 'HOSTLDFLAGS=-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
>>> -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--build-id=uuid'
>>> ARCH=powerpc -j4 modules
>>> BUILDSTDERR: In file included from drivers/vfio/pci/trace.h:102,
>>> BUILDSTDERR:                  from
>>> drivers/vfio/pci/vfio_pci_nvlink2.c:29:
>>> BUILDSTDERR: ./include/trace/define_trace.h:89:42: fatal error:
>>> ./trace.h: No such file or directory
>>> BUILDSTDERR:  #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>>> BUILDSTDERR:                                           ^
>>> BUILDSTDERR: compilation terminated.
>>> BUILDSTDERR: make[3]: *** [scripts/Makefile.build:277:
>>> drivers/vfio/pci/vfio_pci_nvlink2.o] Error 1
>>> BUILDSTDERR: make[2]: *** [scripts/Makefile.build:492: drivers/vfio/pci]
>>> Error 2
>>> BUILDSTDERR: make[1]: *** [scripts/Makefile.build:492: drivers/vfio]
>>> Error 2
>>> BUILDSTDERR: make: *** [Makefile:1053: drivers] Error 2
>>> BUILDSTDERR: make: *** Waiting for unfinished jobs....
>>>
>>> I don't know enough about ftrace building to make a guess here.
>>> Config is attacked.
>>
>> What gcc is this and what is the exact sha1 of the tree? gcc8 prints
>> other error with your config in drivers/scsi/esas2r/esas2r_ioctl.c but
>> not this one so I am curious.
>>
> 
> gcc (GCC) 8.2.1 20181215 (Red Hat 8.2.1-6)
> 
> sha 8e143b90e4d45cca3dc53760d3cfab988bc74571


Your config and this sha1 still make "make oldconfig" ask few questions
and then it compiles just fine, are you sure about the config?

These are questions on "make oldconfig":

Kernel Live Patching (LIVEPATCH) [N/y/?] (NEW)
Stack Protector buffer overflow detection (STACKPROTECTOR) [Y/n/?] (NEW)
  Strong Stack Protector (STACKPROTECTOR_STRONG) [Y/n/?] (NEW)
    Do NOT protect notrace function from kprobe events
(KPROBE_EVENTS_ON_NOTRACE) [N/y/?] (NEW)



>>>
>>> Also, would it be possible to switch this option from def_bool to
>>> bool? I can't turn it off directly when it's def_bool.
>>
>> Why? Honestly I'd rather fix the compile error.
>>
>>
> 
> It's not just about this error, there may be other situations where
> it would be good to have this turned off.

Oh well I think I misunderstood what "def_bool" actually does (it does
not make much sense without "if" conditions). I'll post a patch.



-- 
Alexey

  reply	other threads:[~2019-01-07  2:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 16:37 Laura Abbott
2019-01-03 13:49 ` Alexey Kardashevskiy
2019-01-03 15:08   ` Laura Abbott
2019-01-07  2:58     ` Alexey Kardashevskiy [this message]
2019-01-07  7:25       ` Alexey Kardashevskiy
2019-01-07  9:39         ` Out-of-tree build works, in-tree build fails due to tracing (was Re: compilation failure with CONFIG_VFIO_PCI_NVLINK2) Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91da4363-fed8-a09e-b657-6c10f2b6c33a@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®