mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Li <yang.li@amlogic.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc WCN chips
Date: Mon, 8 Jul 2024 14:32:45 +0800	[thread overview]
Message-ID: <91e42fbc-712e-44b4-8200-23aaf1fade43@amlogic.com> (raw)
In-Reply-To: <726a0561-b3fc-46bb-a834-3ed8b0e993e1@kernel.org>


在 2024/7/8 14:11, Krzysztof Kozlowski 写道:
> [ EXTERNAL EMAIL ]
>
> On 08/07/2024 08:04, Yang Li wrote:
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +  - clocks
>>>> +  - clock-names
>>>> +  - amlogic,chip-enable-gpios
>>>> +  - amlogic,bt-enable-gpios
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    #include <dt-bindings/gpio/gpio.h>
>>>> +    wcn_pwrseq {
>>> No underscores in node names, generic node names.
>>>
>>> There is no device as "pwrseq". I also do not get what "wcn" means here.
>> Yes, I understand.
>>
>> Can I change "wcn_pwrseq" to "pmu", and do I need to change the binding
> What is pmu for your device? What is this device in the first place you
> are documenting? Where is the datasheet?

^_^ Well, You are right, the "pmu" wasn't really fit in here.

I'd like to explain the current usage first, and could you please give 
me a suggestion?

This module(pwrseq) used to power on Bluetooth & Wi-Fi combo chip, both 
Bluetooth and

Wi-Fi driver need to control "chip-en-gpios" pins, so we introduced the 
power sequence module.

What should we call it in this case?

>> file name to "amlogic,w155s2-pmu"
> Yes, compatible should also match proper device.
>
>
> Best regards,
> Krzysztof
>

  reply	other threads:[~2024-07-08  6:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 11:13 [PATCH 0/3] Add power sequence for Amlogic " Yang Li via B4 Relay
2024-07-05 11:13 ` [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc " Yang Li via B4 Relay
2024-07-05 13:34   ` Bartosz Golaszewski
2024-07-08  6:12     ` Yang Li
2024-07-07 12:59   ` Krzysztof Kozlowski
2024-07-08  6:04     ` Yang Li
2024-07-08  6:11       ` Krzysztof Kozlowski
2024-07-08  6:32         ` Yang Li [this message]
2024-07-08  7:32           ` Krzysztof Kozlowski
2024-07-08  8:21             ` Yang Li
2024-07-08  9:10               ` Krzysztof Kozlowski
2024-07-08  9:36                 ` Bartosz Golaszewski
2024-07-05 11:13 ` [PATCH 2/3] power: sequenceing: Add power sequence for Amlogic " Yang Li via B4 Relay
2024-07-05 13:46   ` Bartosz Golaszewski
2024-07-10  3:00     ` Yang Li
2024-07-07 13:02   ` Krzysztof Kozlowski
2024-07-08  7:41     ` Yang Li
2024-07-05 11:13 ` [PATCH 3/3] MAINTAINERS: Add an entry for Amlogic WCN power sequence Yang Li via B4 Relay
2024-07-07 13:04   ` Krzysztof Kozlowski
2024-07-08  6:34     ` Yang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91e42fbc-712e-44b4-8200-23aaf1fade43@amlogic.com \
    --to=yang.li@amlogic.com \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®