From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bean Huo <beanhuo@micron.com>,
Peter Wang <peter.wang@mediatek.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] scsi: ufs: Allow RTT negotiation
Date: Thu, 16 May 2024 08:28:18 -0600 [thread overview]
Message-ID: <91e9322b-9304-4cb7-a1be-1f43208800e8@acm.org> (raw)
In-Reply-To: <20240516055124.24490-2-avri.altman@wdc.com>
On 5/15/24 23:51, Avri Altman wrote:
> void ufshcd_fixup_dev_quirks(struct ufs_hba *hba,
> const struct ufs_dev_quirk *fixups)
> {
> @@ -8278,6 +8312,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
> if (hba->ext_iid_sup)
> ufshcd_ext_iid_probe(hba, desc_buf);
>
> + ufshcd_rtt_set(hba, desc_buf);
> +
Why does this call occur in ufs_get_device_desc()? ufshcd_rtt_set() sets
a device parameter. Shouldn't this call be moved one level up into
ufshcd_device_params_init()?
Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2024-05-16 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 5:51 [PATCH v4 0/3] " Avri Altman
2024-05-16 5:51 ` [PATCH v4 1/3] " Avri Altman
2024-05-16 14:28 ` Bart Van Assche [this message]
2024-05-16 15:21 ` Avri Altman
2024-05-16 16:04 ` Bart Van Assche
2024-05-16 23:56 ` Avri Altman
2024-05-16 5:51 ` [PATCH v4 2/3] scsi: ufs: Allow platform vendors to set rtt Avri Altman
2024-05-16 14:12 ` Bart Van Assche
2024-05-16 15:23 ` Avri Altman
2024-05-16 5:51 ` [PATCH v4 3/3] scsi: ufs: sysfs: Make max_number_of_rtt read-write Avri Altman
2024-05-16 14:17 ` Bart Van Assche
2024-05-16 15:31 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91e9322b-9304-4cb7-a1be-1f43208800e8@acm.org \
--to=bvanassche@acm.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®