From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E604C4743C for ; Mon, 21 Jun 2021 12:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 462236134F for ; Mon, 21 Jun 2021 12:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230121AbhFUMqM (ORCPT ); Mon, 21 Jun 2021 08:46:12 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3296 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbhFUMqK (ORCPT ); Mon, 21 Jun 2021 08:46:10 -0400 Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4G7plY3SyGz6H8Bq; Mon, 21 Jun 2021 20:30:33 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 21 Jun 2021 14:43:55 +0200 Received: from [10.47.93.67] (10.47.93.67) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 21 Jun 2021 13:43:54 +0100 Subject: Re: [PATCH v4 2/7] iommu/amd: Do not use flush-queue when NpCache is on To: Nadav Amit , Joerg Roedel CC: Robin Murphy , , , Nadav Amit , Jiajun Cao , Will Deacon , Lu Baolu References: <20210616100500.174507-1-namit@vmware.com> <20210616100500.174507-3-namit@vmware.com> From: John Garry Message-ID: <91ea2a97-2db6-3e10-9c2e-80f6a4e0f733@huawei.com> Date: Mon, 21 Jun 2021 13:37:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210616100500.174507-3-namit@vmware.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.93.67] X-ClientProxiedBy: lhreml747-chm.china.huawei.com (10.201.108.197) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/2021 11:04, Nadav Amit wrote: > - if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) > + if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) { > + if (!amd_iommu_unmap_flush) > + pr_warn("IOMMU batching is disabled due to virtualization"); This is missing the '\n', like the Intel driver. And, JFYI, we are also downgrading that same print to info level (in the Intel driver). Thanks, John > + > amd_iommu_np_cache = true; > + amd_iommu_unmap_flush = true;