mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, x86@kernel.org,
	linux-kernel@vger.kernel.org
Cc: Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 1/2] x86/xen: remove 32-bit Xen PV guest support
Date: Mon, 15 Jul 2019 11:44:42 -0400	[thread overview]
Message-ID: <91ed11a0-c97e-8caf-c71c-4595be4dbbb4@oracle.com> (raw)
In-Reply-To: <20190715113739.17694-2-jgross@suse.com>


> diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
> index 084de77a109e..d42737f31304 100644
> --- a/arch/x86/xen/Makefile
> +++ b/arch/x86/xen/Makefile
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
> -OBJECT_FILES_NON_STANDARD_xen-asm_$(BITS).o := y
> +OBJECT_FILES_NON_STANDARD_xen-asm_64.o := y
>  
>  ifdef CONFIG_FUNCTION_TRACER
>  # Do not profile debug and lowlevel utilities
> @@ -34,7 +34,7 @@ obj-$(CONFIG_XEN_PV)		+= mmu_pv.o
>  obj-$(CONFIG_XEN_PV)		+= irq.o
>  obj-$(CONFIG_XEN_PV)		+= multicalls.o
>  obj-$(CONFIG_XEN_PV)		+= xen-asm.o
> -obj-$(CONFIG_XEN_PV)		+= xen-asm_$(BITS).o
> +obj-$(CONFIG_XEN_PV)		+= xen-asm_64.o

We should be able to merge xen-asm_64.S into xen-asm.S, shouldn't we?


> @@ -1312,15 +1290,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  
>  	/* keep using Xen gdt for now; no urgent need to change it */
>  
> -#ifdef CONFIG_X86_32
> -	pv_info.kernel_rpl = 1;
> -	if (xen_feature(XENFEAT_supervisor_mode_kernel))
> -		pv_info.kernel_rpl = 0;
> -#else
>  	pv_info.kernel_rpl = 0;

Is kernel_rpl needed anymore?


-boris



  reply	other threads:[~2019-07-15 15:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 11:37 [PATCH 0/2] Remove " Juergen Gross
2019-07-15 11:37 ` [PATCH 1/2] x86/xen: remove " Juergen Gross
2019-07-15 15:44   ` Boris Ostrovsky [this message]
2019-07-16  3:52     ` Juergen Gross
2019-07-15 11:37 ` [PATCH 2/2] x86/paravirt: remove 32-bit support from PARAVIRT_XXL Juergen Gross
2019-07-15 12:32 ` [PATCH 0/2] Remove 32-bit Xen PV guest support Peter Zijlstra
2019-07-15 12:36   ` Juergen Gross
2019-07-15 16:34 ` Andi Kleen
2019-07-15 17:28   ` Andy Lutomirski
2019-07-15 17:39     ` [Xen-devel] " Andrew Cooper
2019-07-16  3:55       ` Juergen Gross
2019-07-15 17:42     ` Juergen Gross
2019-07-16  6:58     ` [Xen-devel] " Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91ed11a0-c97e-8caf-c71c-4595be4dbbb4@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®