From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE6B8304BCB for ; Wed, 14 Jan 2026 16:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406857; cv=none; b=gB2BnLuxDls++Rzx+sbalm+2UQ9UFoaf8PP313a8YQxL8qv9p7KZwVwhtd++8rW34CSjvNGgY6LBhNrSHy+HuY8HTGxSxVD8YtVPbZivpVEKUMwPA8LdYi4n8oHn7vVEaYM8cz18uEAHzy9AIicw9uxYLn7MPnsNiydaN8pkpnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406857; c=relaxed/simple; bh=crIAPxnbhzIoa/AG5x1rUP3CQywlzlls3hLs+gUF0TQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Scvb9NVLbzbMsmxmaw8bWZ6ynqwkkl22MEXxHbD/q89NemeQW6WKreozU2LpPjKLE1Rc8O5wL5gqEUSgrKbzakPS0FoeVs/oxx4XDRbz4Wc413vAYCYkoJV+Q2VFbmtbPMQvRQol2l+9n0IHHSSEGcPsOCL/jGAekLRQKfwrtzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=klZWVprR; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5ytVDuXZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=klZWVprR; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5ytVDuXZ; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="klZWVprR"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5ytVDuXZ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="klZWVprR"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5ytVDuXZ" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7EBB85CD18; Wed, 14 Jan 2026 16:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768406853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mMGZkEeIbQSKBHfnLxwg0gb5cMm28vAqSvWJF99tJRI=; b=klZWVprRWtKfDNa5jyn03ndqBWnAPph9kaxAbAPCuc4bCSwn6BmeatY5GGt2Ll43uTHgG1 WrItfKYxbA4x5GY0VMNvKDiH5AA6TYQ+KBPgLG4p8Y/vnQcEIa7RH0e41ctFtbexDE2tI+ thRMq/G1qLgDEK+F4xrzB1VqVyM8Zfk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768406853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mMGZkEeIbQSKBHfnLxwg0gb5cMm28vAqSvWJF99tJRI=; b=5ytVDuXZaovEqtHLQoefgwajZYYlQ7ff8pzbMRqyHD6ubDg1p+9RI/rCN7v+P5JAx9/+t6 pdV6F8JXrdhqK8Aw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768406853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mMGZkEeIbQSKBHfnLxwg0gb5cMm28vAqSvWJF99tJRI=; b=klZWVprRWtKfDNa5jyn03ndqBWnAPph9kaxAbAPCuc4bCSwn6BmeatY5GGt2Ll43uTHgG1 WrItfKYxbA4x5GY0VMNvKDiH5AA6TYQ+KBPgLG4p8Y/vnQcEIa7RH0e41ctFtbexDE2tI+ thRMq/G1qLgDEK+F4xrzB1VqVyM8Zfk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768406853; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mMGZkEeIbQSKBHfnLxwg0gb5cMm28vAqSvWJF99tJRI=; b=5ytVDuXZaovEqtHLQoefgwajZYYlQ7ff8pzbMRqyHD6ubDg1p+9RI/rCN7v+P5JAx9/+t6 pdV6F8JXrdhqK8Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 318F63EA63; Wed, 14 Jan 2026 16:07:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JRyECUW/Z2lMMgAAD6G6ig (envelope-from ); Wed, 14 Jan 2026 16:07:33 +0000 Message-ID: <91edf43f-108b-45ab-af7d-097097ff6c24@suse.de> Date: Wed, 14 Jan 2026 17:07:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/fb-helper: Add force parameter to stub function To: Matt Coster , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Jocelyn Falempe Cc: Frank Binns , Karolis Mituzas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260114-drm-fb-helper-stub-fix-v1-1-3a1934b42c93@imgtec.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260114-drm-fb-helper-stub-fix-v1-1-3a1934b42c93@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[imgtec.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,redhat.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[10]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.com:url] X-Spam-Level: X-Spam-Flag: NO Hi Am 14.01.26 um 15:57 schrieb Matt Coster: > The signature of drm_fb_helper_restore_fbdev_mode_unlocked() was modified > in commit 943240d342f14 ("drm/client: Pass force parameter to client > restore") to add a force parameter, but this was not added to the stub > equivalent for when CONFIG_DRM_FBDEV_EMULATION is not enabled. The only caller depends on CONFIG_DRM_FBDEV_EMULATION, so the stub should never be called. If possible, remove it entirely. Most of these stub functions are left overs from when fbdev emulation was less well isolated from the rest of DRM. Best regards Thomas > > Suggested-by: Karolis Mituzas > Fixes: 943240d342f14 ("drm/client: Pass force parameter to client restore") > Signed-off-by: Matt Coster > --- > include/drm/drm_fb_helper.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index dd9a18f8de5a7..eebb36a099698 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -333,7 +333,8 @@ static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > } > > static inline int > -drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > +drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > + bool force) > { > return 0; > } > > --- > base-commit: b91a565ed14fcf900b4d95e86882b4b763860986 > change-id: 20260114-drm-fb-helper-stub-fix-03f07bd2be61 > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)