mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
	<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Cc: <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>, <robh@kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version number in compatible string
Date: Thu, 14 Apr 2022 14:46:25 +0200	[thread overview]
Message-ID: <91ef84f9-4cac-c0aa-c717-7f1b3bc566fb@xilinx.com> (raw)
In-Reply-To: <20220414092252.12174-2-bharat.kumar.gogada@xilinx.com>



On 4/14/22 11:22, Bharat Kumar Gogada wrote:
> Removing unnecessary version number in compatible string.

I am missing reason for this in commit message.

> 
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> ---
>   Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> index 32f4641085bc..4ebcc838a1f6 100644
> --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> @@ -14,7 +14,7 @@ allOf:
>   
>   properties:
>     compatible:
> -    const: xlnx,versal-cpm-host-1.00
> +    const: xlnx,versal-cpm-host

And this is likely breaking compatibility for existing DTs.

M

>   
>     reg:
>       items:
> @@ -70,7 +70,7 @@ examples:
>                  #address-cells = <2>;
>                  #size-cells = <2>;
>                  cpm_pcie: pcie@fca10000 {
> -                       compatible = "xlnx,versal-cpm-host-1.00";
> +                       compatible = "xlnx,versal-cpm-host";
>                          device_type = "pci";
>                          #address-cells = <3>;
>                          #interrupt-cells = <1>;

  reply	other threads:[~2022-04-14 12:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14  9:22 [PATCH v1 0/3] Remove unnecessary version number Bharat Kumar Gogada
2022-04-14  9:22 ` [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version number in compatible string Bharat Kumar Gogada
2022-04-14 12:46   ` Michal Simek [this message]
2022-04-14 16:45     ` Bjorn Helgaas
2022-04-19 12:22       ` Bharat Kumar Gogada
2022-04-19 14:12         ` Rob Herring
2022-04-26  4:04           ` Bharat Kumar Gogada
2022-04-14  9:22 ` [PATCH v1 2/3] " Bharat Kumar Gogada
2022-04-14  9:22 ` [PATCH v1 3/3] dt-bindings: PCI: xilinx-cpm: Change reg property order Bharat Kumar Gogada
2022-04-14 12:47   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91ef84f9-4cac-c0aa-c717-7f1b3bc566fb@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=bharat.kumar.gogada@xilinx.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®