Re: [PATCH v5 06/13] drm/bridge: cdns-dsi: Check return value when getting default PHY config

[Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>]

On 19/10/2024 22:54, Aradhya Bhatia wrote:
> From: Aradhya Bhatia <a-bhatia1@ti.com>
> 
> Check for the return value of the phy_mipi_dphy_get_default_config()
> call, and incase of an error, return back the same.
> 
> Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
> ---
>   drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi

> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index 2fc24352d989..e4c0968313af 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -575,9 +575,11 @@ static int cdns_dsi_check_conf(struct cdns_dsi *dsi,
>   	if (ret)
>   		return ret;
>   
> -	phy_mipi_dphy_get_default_config(mode_clock * 1000,
> -					 mipi_dsi_pixel_format_to_bpp(output->dev->format),
> -					 nlanes, phy_cfg);
> +	ret = phy_mipi_dphy_get_default_config(mode_clock * 1000,
> +					       mipi_dsi_pixel_format_to_bpp(output->dev->format),
> +					       nlanes, phy_cfg);
> +	if (ret)
> +		return ret;
>   
>   	ret = cdns_dsi_adjust_phy_config(dsi, dsi_cfg, phy_cfg, mode, mode_valid_check);
>   	if (ret)