From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D111C73C7C for ; Wed, 10 Jul 2019 10:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED3C12054F for ; Wed, 10 Jul 2019 10:03:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="G1TmNNUZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbfGJKDc (ORCPT ); Wed, 10 Jul 2019 06:03:32 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45487 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfGJKDb (ORCPT ); Wed, 10 Jul 2019 06:03:31 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190710100329euoutp023eed425bcee719e6e7b4a692d7999f03~wA5UP6F6d1787017870euoutp02E for ; Wed, 10 Jul 2019 10:03:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190710100329euoutp023eed425bcee719e6e7b4a692d7999f03~wA5UP6F6d1787017870euoutp02E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1562753009; bh=05OMm3VSTi/89wp1oOwXoIF+99YdS1ZF43mBPBMGA4E=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=G1TmNNUZiXJgpwqPPyPQOjrIjoyTc5So/kWh6AXZOVc50jGcQhd2qDNJ94p7PAj7s bJn3XsT3CVfGiG2Oin9/OZHFGR3r7RCI+nK3pR0Xt8IW4DX9pOxKV+1TneChCucxNa sVMhxEBkkmx9+fioWFPUt8UaXHHy9bK/dWurELzw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190710100328eucas1p23ede1aa2c1baed33bde4a075181f9f9f~wA5TUiX3f1797817978eucas1p26; Wed, 10 Jul 2019 10:03:28 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 35.6E.04377.0F7B52D5; Wed, 10 Jul 2019 11:03:28 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190710100327eucas1p22155293a32da90454bf2559080a8e013~wA5SXvlfw1796417964eucas1p25; Wed, 10 Jul 2019 10:03:27 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190710100327eusmtrp14a2d7009dca3152c14d70669f797b532~wA5SJdnQf2175421754eusmtrp1b; Wed, 10 Jul 2019 10:03:27 +0000 (GMT) X-AuditID: cbfec7f4-113ff70000001119-ca-5d25b7f002d5 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 06.56.04140.FE7B52D5; Wed, 10 Jul 2019 11:03:27 +0100 (BST) Received: from [106.120.51.18] (unknown [106.120.51.18]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190710100326eusmtip16170632a9ff55b074bfe324aae6c82e6~wA5Rd6hGh0440304403eusmtip1M; Wed, 10 Jul 2019 10:03:26 +0000 (GMT) Subject: Re: [PATCH 0/3] add coupled regulators for Exynos5422/5800 To: Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , Chanwoo Choi , Kukjin Kim , Kyungmin Park , Mark Rutland , MyungJoo Ham , Nishanth Menon , Rob Herring , Stephen Boyd , Viresh Kumar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" From: Kamil Konieczny Message-ID: <91f65527-3440-90fd-4096-5824fba1df78@partner.samsung.com> Date: Wed, 10 Jul 2019 12:03:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTURzHO/exe11Or8vyRy9lJWHlowd0ohCj16iIwn/EsFp2U2lO2XRW Eq3IJ64ki2zJzNlTLHOK2kSDNVr5tkBFqUxnD2tgbJCVrZzXyP8+v+/v9zvnfOCwpPQ9vZhN UWXwapVCKROJqYbnP7rCJxpDE6Jyqn1xbWkNjfvdH2lcbuui8eXRLyTu7n7M4M4LXxlsHu2j 8WtLmQi79DaES7tbCfzQ9obBd/p7CTx0/r4If53sJHBOi43Bnr5aCtcNPxfFBMirjdVIbq4q EMnrbp+TX6qvQnL7QCMhd5mXHxDFi7ce55UpWl4dGX1UnDyZbyLS2/xPTbT0MDpU5FuIfFjg NsLVy3aiEIlZKXcfgbnLQAqFG8FPTx4lFC4Ew7Wt1L8VY6WBERr3EDjyxmcLJ4KSD99EhYhl F3DbYaolzLsQyIVB/+/vtHeG5CYp0I0/mTlJxG2CkcYOwssSbhf06IZoL1NcKEyNlCIvL+Ti oM1mpISZAHh5wzHDPtxBsOudjJdJLggGHeWEwMHQ6CybcQCugIXasUpCePYOcJvfzSosgHF7 PSPwUmgvKZrNs2Cs4hIjLF+cds77NtvYAs/svbTXjJzWqbFECvE2cHh+I28MnB8MOAOEN/jB lYbrpBBLID9XKkyHg/FPBy3wEij884guRjLDHDPDHBvDHBvD/3tvIaoKBfGZmtQkXrNexWdF aBSpmkxVUkRiWqoZTX+8do/d3YQsU8esiGORzFcCF1cmSGmFVnM61YqAJWWBktbdKxKkkuOK 02d4ddoRdaaS11jREpaSBUmy5w0fknJJigz+JM+n8+p/XYL1WaxDd8/nphfvm3hwRjv6Kfhm dJQ/tWupbdX8/Y/apiw72GLHBlNdPclYtYnRn2OzBo8qQ562Ny0/XBdVUxJS8natJGika9nO 2D2uF85svXT344jsJ8rmE36MPGaR6UWEO+dHfHCFniw+aI7rzRDrf40F+5oq955tfuVYcy23 Y3OsOtshozTJinWrSbVG8RdWaxm4dAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCIsWRmVeSWpSXmKPExsVy+t/xu7rvt6vGGkw9yWmxccZ6VovrX56z Wsw/co7Vov/xa2aL8+c3sFucbXrDbrHp8TVWi8u75rBZfO49wmgx4/w+Jou1R+6yWyy9fpHJ 4nbjCjaLNz/OMlm07j3CbvHv2kYWi80PjrE5CHqsmbeG0WPTqk42j81L6j36tqxi9Dh+YzuT x+dNcgFsUXo2RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2 CXoZPzoWMRWc4q/4sPcCewNjD08XIyeHhICJxLzFs9i7GLk4hASWMkq8P/yWHSIhLdF4ejUT hC0s8edaFxtE0WtGid67a1i6GDk4hAWcJf7s1QSpERHQlLj+9zsrSA2zwB8Wia7GGYwQDfcZ JT4sWg82lU3AXOLR9jNgU3kF3CQuNNxmBbFZBFQl/jwCaeDkEBWIkJh0bScLRI2gxMmZT8Bs ToFAieO9ENcxC6hL/Jl3iRnCFpe49WQ+E4QtL7H97RzmCYxCs5C0z0LSMgtJyywkLQsYWVYx iqSWFuem5xYb6RUn5haX5qXrJefnbmIExvi2Yz+37GDsehd8iFGAg1GJh1eiRSVWiDWxrLgy 9xCjBAezkgjvPnflWCHelMTKqtSi/Pii0pzU4kOMpkDPTWSWEk3OB6afvJJ4Q1NDcwtLQ3Nj c2MzCyVx3g6BgzFCAumJJanZqakFqUUwfUwcnFINjJPWrEi7+kF4f6BoutaKF8HT0jcszV/d PHW6yr1DG0yM11xUit7bvuzl21w9Yc3/S3JOHAh9G/3s8dPlezU6xH88s6+OeZ512KH6Sc+v w0o1ziZ9ovq2Asaf8x8sy5/5eSL/p2I95f6YF4lHvqTks8pGb4qdui90y7yVzzRyblrH8O3i OKX8Zb8SS3FGoqEWc1FxIgDKvMj4BwMAAA== X-CMS-MailID: 20190710100327eucas1p22155293a32da90454bf2559080a8e013 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190708141158eucas1p17d4b50978dbe1e5c876ce6d8f433cc95 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190708141158eucas1p17d4b50978dbe1e5c876ce6d8f433cc95 References: <20190708141140.24379-1-k.konieczny@partner.samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.07.2019 11:00, Krzysztof Kozlowski wrote: > On Mon, 8 Jul 2019 at 16:12, wrote: >> >> From: Kamil Konieczny >> >> Hi, >> >> The main purpose of this patch series is to add coupled regulators for >> Exynos5422/5800 to keep constrain on voltage difference between vdd_arm >> and vdd_int to be at most 300mV. In exynos-bus instead of using >> regulator_set_voltage_tol() with default voltage tolerance it should be >> used regulator_set_voltage_triplet() with volatege range, and this is >> already present in opp/core.c code, so it can be reused. While at this, >> move setting regulators into opp/core. >> >> This patchset was tested on Odroid XU3. >> >> The last patch depends on two previous. > > So you break the ABI... I assume that patchset maintains > bisectability. However there is no explanation why ABI break is needed > so this does not look good... Patchset is bisectable, first one is simple and do not depends on others, second depends on first, last depends on first and second. What do you mean by breaking ABI ? > Best regards, > Krzysztof > >> >> Regards, >> Kamil >> >> Kamil Konieczny (2): >> opp: core: add regulators enable and disable >> devfreq: exynos-bus: convert to use dev_pm_opp_set_rate() >> >> Marek Szyprowski (1): >> ARM: dts: exynos: add initial data for coupled regulators for >> Exynos5422/5800 >> >> arch/arm/boot/dts/exynos5420.dtsi | 34 ++-- >> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 4 + >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 + >> arch/arm/boot/dts/exynos5800.dtsi | 32 ++-- >> drivers/devfreq/exynos-bus.c | 172 +++++++----------- >> drivers/opp/core.c | 13 ++ >> 6 files changed, 120 insertions(+), 139 deletions(-) >> >> -- >> 2.22.0 -- Best regards, Kamil Konieczny Samsung R&D Institute Poland