From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F8A31DE88C for ; Mon, 6 Jan 2025 14:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736172498; cv=none; b=E1gU7RdtPoZ3pqXKu6VxyubnXJKlbBsQN0mLMSRnYRl7Ger3Wflr8g7GWRUnZdasmq7YCWACwJZChigopCL5o7UglfCZd/q8DYj8Sx8+J6FXgtMFi7BSP25iqyR94Y1hRbqZbla+lA9pZwWyXtTSBuEppDMwY2RwwztWSru3pg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736172498; c=relaxed/simple; bh=GbeZc7W6Q3I0MRY/HrXEVTv18jbZE/U2UUTXH/SitKM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=evjAYnjUR8rkUwtHPLecdKZuXovzfec0xZ1VOMxBkIGA1HOTa3B9cHZCJRomfEpC4C0kMhQXmStzPSJmmtSrdGNZT8bY2+ROEnzqgvsePd+qsWAMZ9SoFzmXGm1Vrn/7iOSCIGK2tcCt9R+KiCLCxy4xxW/hfOpYcglDSOJiV38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Sdha6wmb; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Sdha6wmb" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43634b570c1so103316365e9.0 for ; Mon, 06 Jan 2025 06:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736172494; x=1736777294; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ncYQpwQ9OCIQn9/rsFj5efsB71N9r4wzFE7cHZesHrU=; b=Sdha6wmbSsJT6PjOLlmv5nvTfSycR7Km3XSwaP/+LSJRXE+U6pOx8ID5ca/Mn+Nlpy OCMdFixf5WsxLW1rsdprmHQUSkdACHNUVb7E5kKdDUjq+pQJGQCwDum7uB+NgAnUOsOm Q2sEQYrDN37f6eVxOFCqxJJpKxK/i5iZHizGdHdrHwxgcCTDwdXeUDFhRAKcF1TF0ye5 O8sMBm6eSXLrVbDQzyvv6hdpK38hl0xnJrli60kKFbLLPm3IZFC1aN1AQ29DCZVRsh9A 9K7LGB96glp7AVY30iREQkdDwE+jnyTO/JA19BQ1aQXBGCOjm9gpgnaSTkxpEtZoy3PP 2bJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736172494; x=1736777294; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ncYQpwQ9OCIQn9/rsFj5efsB71N9r4wzFE7cHZesHrU=; b=tDP/yF7pEDBtREOa1TVBuBfrOiW9yyEYpyKN+DA5nXGsQZD1ZjsRDX1bX1tSXs/FuG zzeJfWz6adUswz3EouzOtJc0K7Ud5vJqOIkuDRFZULoB9Fb1M0j2yp+Q080u4XrJWljv vFspiem30lECuEYJIKkofP9Eej7SK6uqMg4FQ0OnJTBK56Y9ZtPiweykzLScsv/O88qA WwFt1HwLs/ZolyR+7W1wGcmbxeZxfmv2T5mFO0GWLW+Bp6J+ejtko/oQglvLiVGbfJss 1IP6Ogo162bJdZNuWYq26PZjazFFWRRchn2FkgrZzZn+P6gl3Bz5VIk38VW38e2h54Rk BQlQ== X-Forwarded-Encrypted: i=1; AJvYcCVmZ7w6tUi1K9dSHqkhRzCZBDcIVjtNICwo57xvs/0xeniv+d4iqLbdD5FOwkmtWwpdiuISctinFB9PeBc=@vger.kernel.org X-Gm-Message-State: AOJu0YwB0Bb8klazUzLm1zgDIjI7FQBEPhXCM5a7gQfGF8dHWRwdBqg4 rXMkKYmleUHWUCTcLya7qMTDEOz7IIfLvhsMC/1ZG1dBByI07QlAdaUe7Afpge0= X-Gm-Gg: ASbGncuhLgksRIpPshc+W/HRL+nHa0oWNER79v+nW/XrNRYBQb8dkfwkpfyzMqW6RSy uQzzQyAIIUR2MU9hZCFkNRQMrl9967eczgdhKcL1XtCpNmQ7xJYywb0TzxRZRP2EjxAAzV12dUU EJ1I+3wIRSGnpuHpjVvq4bexIIA+600a/7iaITT81Ur/jYvuEvAj+OAg9pF/wNkN7ojtDeNw5dG fCXDCWUnLS0R7vunA1IHIB5arSzddh2yClc+gWZzHdtP1lcc7cO/ID6gmjiNSi6I7FWaw== X-Google-Smtp-Source: AGHT+IHW3ETfqtBsOE2bHkob+eHNeS2Nwu8SpS7/ti4RMQCKSJ5YxWWSnX51+61lvx3mx4ntI21zUA== X-Received: by 2002:a5d:598d:0:b0:385:e013:39ef with SMTP id ffacd0b85a97d-38a221e30aemr43363039f8f.6.1736172494526; Mon, 06 Jan 2025 06:08:14 -0800 (PST) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a412f778esm33701910f8f.4.2025.01.06.06.08.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 06:08:14 -0800 (PST) Message-ID: <92009895-8b9e-43d5-99f0-efc43c4b09c8@linaro.org> Date: Mon, 6 Jan 2025 14:08:13 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] media: venus: venc: Ignore parm smaller than 1fps To: Ricardo Ribalda , Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Hans Verkuil , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , linux-arm-msm@vger.kernel.org References: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> <20250106-fix-cocci-v4-3-3c8eb97995ba@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250106-fix-cocci-v4-3-3c8eb97995ba@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/01/2025 13:40, Ricardo Ribalda wrote: > The driver uses "whole" fps in all its calculations (e.g. in > load_per_instance()). Return -EINVAL if the user provides a parm that > will result in 0 whole fps. > > Reported-by: Hans Verkuil > Closes: https://lore.kernel.org/linux-media/f11653a7-bc49-48cd-9cdb-1659147453e4@xs4all.nl/T/#m91cd962ac942834654f94c92206e2f85ff7d97f0 > Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files") > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/qcom/venus/venc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index c1c543535aaf..bd967d60c883 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -411,7 +411,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC; > do_div(us_per_frame, timeperframe->denominator); > > - if (!us_per_frame) > + if (!us_per_frame || us_per_frame > USEC_PER_SEC) > return -EINVAL; > > fps = (u64)USEC_PER_SEC; > Reviewed-by: Bryan O'Donoghue