From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.10 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793080234; b=n3xhbxVF+0P/Yk+SGLndgQJ5k3i6Gl+eSAroASfAgZCSi2OY9COM6ttPYOqMSrW4ntBy z6Pfov55r2vlZ4A1KP07AFXAtWOMLAgFgBC39Vy/D1D3dWzU3rf/ak1DAFxzSCw1YyIjt 6sR07FLL5n5hcZlSBUYriaRacJ7DAmMNTT8SNxTzSt2FjrlBE6PuVh2+CZUgOL57+8nxo xt4p8qNxgT8eem0pYc+RJ7yCc1smqQaKwtbHF5drFz44wjcXpEPNovqy2a9yf7gGNx7Tb ohpNI7z5zBfg7RzjTVX9Jnb7AevkcdTUtA0y+M+EwJWKJ8OtrbYI5PBwN2SS1W9o2Dg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793080234; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Message-ID:Date: MIME-Version:User-Agent:Subject:To:Cc:References:Content-Language: From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=FiRH3Muu0B1Y9IwpXTlmxS6fqN25x5lO7sXHc5scxXM=; b=Yllc/3qxNsSSPKZikzJWPOxkS1q1Lkl5vEJ7qUICdSi9uuZ0zbDD6wMaVb4G5WTonuan GU9f9GB9UJhBO2gKy3U0LdNiZXxbCYKJv66KJAk/QeCLOr5Jc22N7jkASVpfxY03uT2re Co6INWv30KsvzXHj27t1VPMqPBSvY7spfIpQRa/Kha5Ln5QVd9TGe2tOGd3oyPU//oXVo sxKr8qbCuYS+fUYUQFp8oiPYFXyOg+gdJPTfT6QDqgxnLUuCIwQ3zW0CM9mfVxIQtEW84 R0gfA2zyUVYyPcu+L+92WmqN++rxc0qNJ8rRYfJZ5OuLXa/FwATYLs/X+ZSIk75Q5Yg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=L2txWquY; arc=none smtp.remote-ip=198.175.65.10 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DDCC606A31B for ; Tue, 27 Oct 2026 05:50:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5DDCC606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=L2txWquY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793080233; x=1824616233; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SETQHDzPt1GmiSTU9RrxkHVE+UqvzxnrBAdylx1br/c=; b=L2txWquYjA5QIxFZM6kY8J1ehkeKZF5jEwtUHIw5AAxhs+wdqF6tw8ta H+osljR1YfVN9RlQRrnUWgcEtAwEWfqHYB6vViU4dODyFQLYnmdg5y395 E7gb5nLfIwDJ2JwekqzRhgghk6zwWitk4qEimTNBI9wb5cwdB9wlaWO+l ATi2aCaXlzysQ12nJkwzfsyNm+AyVGnCBDu5TUfgPuEZdIfVmXf0j90/Z CyNd5eQYkpBDT0L2G/ttF7pwF1/TtOpUIqULwL0Gn5cY736Pk2TPitVnh jooMBMutqutOZ25vaZYOuaiW+avJqKD1YFoyr5ko0E1fQJfqoor43wO0w Q==; X-CSE-ConnectionGUID: Jiy+QdGNTHONQ3bOU2l73w== X-CSE-MsgGUID: fLucjSkpTsS/OA3qzyOCwQ== X-IronPort-AV: E=McAfee;i="6800,10657,11947"; a="1662496" X-IronPort-AV: E=Sophos;i="6.27,180,1787036400"; d="scan'208";a="1662496" Received: from fmviesa012.fm.intel.com ([10.60.135.152]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2026 22:50:33 -0700 X-CSE-ConnectionGUID: /+pnNvTcSsaJGOR5nZ3ZkQ== X-CSE-MsgGUID: FSn+z2DXRvmlhnmMgtaC6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,180,1787036400"; d="scan'208";a="6207789" Received: from unknown (HELO [10.238.0.97]) ([10.238.0.97]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2026 22:49:41 -0700 Message-ID: <920718ed-16a5-426e-9407-6ed37181615b@intel.com> Date: Tue, 27 Oct 2026 13:49:38 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 02/15] x86/tdx: Add TDCM hypercall wrapper for TDX Connect To: "Duan, Zhenzhong" , "x86@kernel.org" , "linux-coco@lists.linux.dev" , "linux-kernel@vger.kernel.org" Cc: "dave.hansen@linux.intel.com" , "tglx@kernel.org" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "Hansen, Dave" , "kas@kernel.org" , "Edgecombe, Rick P" , "jgg@nvidia.com" , "nicolinc@nvidia.com" , "aik@amd.com" , "aneesh.kumar@kernel.org" , "seanjc@google.com" , "pbonzini@redhat.com" , "yilun.xu@linux.intel.com" , "Gao, Chao" , "Verma, Vishal L" , "Tian, Kevin" , "Peng, Chao P" References: <20260924041032.1096569-1-zhenzhong.duan@intel.com> <20260924041032.1096569-3-zhenzhong.duan@intel.com> <023f3254-c368-4ef6-89b2-8bbacb42d89d@intel.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/27/2026 11:28 AM, Duan, Zhenzhong wrote: >>> Abstract the underlying leaf call and pass the shared buffer physical >>> address as a decrypted mapping. Add a runtime page alignment check >>> for the buffer to enforce correct usage. >> This doesn't match the implementation. The code only WARNs instead of >> enforcing >> correct usage. > You mean below code? > > static void tdx_devsec_unlock(struct pci_tsm *tsm) > { > struct tdx_devsec *tdevsec = to_tdx_devsec(tsm); > struct device_evidence *evidence = tsm->evidence; > > if (WARN_ON(tdx_tdi_unbind_dev(tdevsec))) > return; > > I think the unlock() callback should be defined with a return value so > userspace could catch the error. No. I meant just the code of tdx_hcall_tdcm() +u64 tdx_hcall_tdcm(u16 devid, void *buf, size_t size, u8 vector) +{ + WARN_ON_ONCE(!PAGE_ALIGNED(buf) || !PAGE_ALIGNED(size)); + + return _tdx_hypercall(TDVMCALL_TDCM, devid, cc_mkdec(virt_to_phys(buf)), size, vector); +} it warns on the unaligned buf and size, but the unaligned data are still consumed.