From: Krzysztof Kozlowski <krzk@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org
Cc: "Alexandru Ardelean" <alexandru.ardelean@analog.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: trivial-devices: Drop adi,adp5585 and adi,adp5585-02
Date: Tue, 21 May 2024 21:02:19 +0200 [thread overview]
Message-ID: <920c3b0d-86ed-4616-989c-0d493a189c91@kernel.org> (raw)
In-Reply-To: <20240520195942.11582-2-laurent.pinchart@ideasonboard.com>
On 20/05/2024 21:59, Laurent Pinchart wrote:
> The Analog Devices ADP5585 is a multi-function device that requires
> non-trivial DT bindings. To prepare for proper support of the device,
> drop the related compatible strings from trivial-devices.yaml. They were
> added by mistake, without any user in the mainline kernel, neither in
> device tree sources nor in drivers.
>
> Fixes: e5dddbedfe09 ("dt-bindings: add ADP5585/ADP5589 entries to trivial-devices")
I don't see a bug there. Just because there are no users, it is not yet
a bug.
This should be squashed with next patch so you keep compatibles documented.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-21 19:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 19:59 [PATCH 0/5] ADP5585 GPIO expander, PWM and keypad controller support Laurent Pinchart
2024-05-20 19:59 ` [PATCH 1/5] dt-bindings: trivial-devices: Drop adi,adp5585 and adi,adp5585-02 Laurent Pinchart
2024-05-21 19:02 ` Krzysztof Kozlowski [this message]
2024-05-21 19:44 ` Laurent Pinchart
2024-05-20 19:59 ` [PATCH 2/5] dt-bindings: Add bindings for the Analog Devices ADP5585 Laurent Pinchart
2024-05-21 19:05 ` Krzysztof Kozlowski
2024-05-21 19:43 ` Laurent Pinchart
2024-05-22 6:57 ` Krzysztof Kozlowski
2024-05-22 7:20 ` Krzysztof Kozlowski
2024-05-22 7:22 ` Laurent Pinchart
2024-05-22 7:40 ` Krzysztof Kozlowski
2024-05-23 23:16 ` Laurent Pinchart
2024-05-28 15:12 ` Rob Herring
2024-05-28 18:08 ` Laurent Pinchart
2024-05-28 22:02 ` Saravana Kannan
2024-05-28 22:21 ` Laurent Pinchart
2024-05-20 19:59 ` [PATCH 3/5] mfd: adp5585: Add Analog Devices ADP5585 core support Laurent Pinchart
2024-05-23 8:29 ` Bough Chen
2024-05-23 20:18 ` Laurent Pinchart
2024-05-20 19:59 ` [PATCH 4/5] gpio: adp5585: Add Analog Devices ADP5585 support Laurent Pinchart
2024-05-28 11:54 ` Linus Walleij
2024-05-28 12:27 ` Laurent Pinchart
2024-05-28 18:09 ` Laurent Pinchart
2024-05-20 19:59 ` [PATCH 5/5] pwm: " Laurent Pinchart
2024-05-21 8:51 ` Uwe Kleine-König
2024-05-21 10:09 ` Laurent Pinchart
2024-05-21 13:05 ` Uwe Kleine-König
2024-05-22 10:13 ` Laurent Pinchart
2024-05-22 10:23 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=920c3b0d-86ed-4616-989c-0d493a189c91@kernel.org \
--to=krzk@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®