From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 057B923AB88; Tue, 16 Jun 2026 19:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781638767; cv=none; b=GvYvtJwQJcp7XHyakPgftw3hD6VBNjxMsJhehC/m5cdrfiIVK+adBMHuAetFbUlGVvpArZIcCC2Cmw9mzdbfk3zRLzMRxW1WDIYbLUqV5wy7Z8XbWy1iaroBLqMiF2euqPGXRpA0T5Y0i4Q8iHQkpx0U5LFaonOjLyw2Cn9i14g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781638767; c=relaxed/simple; bh=MJhp1IRR0FbFmfsL0S1GqLz1h1QFMhqJUYwuO8eBnZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ai4uYsYxJdcUjJ9edrkKuL2LUjiOLRzVpRL21TlWW7LZVSn3DOO3aEi/2COFwUzOIzfLcKXwWAPoSukETxGqh/rym5MMzWA36LLDN3FZYYtezM8LbV+Bvu7yDn/V+MvsWOjjDKjNlM9ZQW84vxB5yqDtfRT+qZs5/69nMPpLzNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=v8atiQAm; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="v8atiQAm" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jmJ3865OUTvY13XqaIlNu/kLAlTETRik+w6P+e58M/o=; b=v8atiQAmAJ5deTFtTfcyrOM3nc lnLDJn9qKKJdVU6JAaKzH0xCO3a1F/mGueyADWUYdZ2PjRY4JejBzZQgAgtuEnN4SOtRw0IbO7/HK mTKWw4AO/kkeGmcFCZs/f+LtaUkmdIo7TINXzVb7ThMasqMHgHyoQ38Wgkbqfa05i5X0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wZZcv-0081Xm-Tg; Tue, 16 Jun 2026 21:39:13 +0200 Date: Tue, 16 Jun 2026 21:39:13 +0200 From: Andrew Lunn To: han.junyang@zte.com.cn Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ran.ming@zte.com.cn, han.chengfei@zte.com.cn, zhang.yanze@zte.com.cn Subject: Re: [PATCH net-next v6 1/2] dinghai: add ZTE network driver support Message-ID: <920cc3b1-af5e-4ce8-bfa2-520c1ba53904@lunn.ch> References: <20260616212106742_trNLb7r-FL04eDlJO8tT@zte.com.cn> <20260616213057452I2KLm3mVgWYl_SUTy_YYS@zte.com.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616213057452I2KLm3mVgWYl_SUTy_YYS@zte.com.cn> > +++ b/drivers/net/ethernet/zte/dinghai/en_pf.h > +static inline void *dh_core_alloc_priv(struct dh_core_dev *dh_dev, > + size_t size) > +{ > + void *priv = kzalloc(size, GFP_KERNEL); > + > + if (priv) > + dh_dev->priv = priv; > + return priv; > +} > + > +static inline void dh_core_free_priv(struct dh_core_dev *dh_dev) > +{ > + kfree(dh_dev->priv); > +} It is unusual for these to be inline functions in a header. Why is this? Andrew