From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF22B435529 for ; Mon, 10 Aug 2026 18:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385539; cv=none; b=pTAQniT8+KCDcz6ocMbSYv4zlMosV/H/yiioMpR5fBNnI0+RQTOaz7TNMtZbMpPGpaFJoWB4SijqQR7CBODodqWZiSzQDg6D9ESV26aud5n5iJtMHRWlJrlxExZ1p67W2E/823gIq2Y2wrvi4m0+Wq2diWdveS4EyMR+usTcqM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385539; c=relaxed/simple; bh=bG3LJpjkYmT6FBZfH9s4KWN3hchwrzKsnI6tFBWtiCI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V9mX6AmZDC5OtzH/RYqp/y/UUXfgBGVq6geGqxxIE2xQoR37N7YQbQ3VxTmNDZzvsbte4MxwQmMCJazdXdZn3++Yv7t1Khu8dwotST8G9s+GJVcicL14NOWa4hLNOKatXH8BfSyeAuurhXIscjhBephASGNS4MKuDN29u5cdiSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ff2yZfLB; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ff2yZfLB" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38fdeaed181so2804075a91.1 for ; Mon, 10 Aug 2026 11:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385537; x=1786990337; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZsNf5bjfoDgYvX/JyiuMylIj+fn5WBmscP8FbbD1RRw=; b=Ff2yZfLB1Nkf7WuF2TJU1lwEWEyXjML/Xmvp3r9zNnNRf7nyvGs0m8OGEIxoWLhQEF U1eW5a7Q9IM9xAaUiTnA9NdiFGpewqNCK8A61NAKBGyL27AkNal1fI2JRw1GxMhhWhaO 4kkSHTAYx9u+2Wkz+NynX+wtA7kA0jSGTzH44L5QCpR/wHLEeRMhDbWyYTQVrL1Llp42 IGRnCg+QLvKqK58hdLWvH4Qm7lbeqTQbppfVDlNisBGGp3Xi4K/xS8DKRt0Kg5vnS8D7 ieSuorFDIp6L9Iqe/kFcATgyYnFbcMRQLMc/RmV/6hQ2UJyVFSBMux7Qb9jbUIOsHajA nq+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385537; x=1786990337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZsNf5bjfoDgYvX/JyiuMylIj+fn5WBmscP8FbbD1RRw=; b=Hc4YpMpE6widT4RbHqvUhAbotEFyJlaDDxPcJVrj06ZGIRGl2RQREc5+LJllsOfOP8 JP49/7vL9eTpUJ8VzI8P4hesrWsbxCgwWJFivcLTjY3wax2IoTbjh6YqqmBt5PVIoDiV Jo98yw1N0B8XTu6Q8F7qioJIieWMO/X7jbC/NZnJnVPvDTRGpMht6eMcM9ty1t5YSK61 ULeM8qcjCA3vMSj/afWAL579c6eUBXsNmnA9L29KoCZ+QTjB5gN/qaRbXqHk8n3KZ2DH YG+SZ8BPRA01toBekvDSCyTRVh2tGIUxOo5ArBNEV2N5fd7i/avYiCUqtOHtvm203QtD wswg== X-Forwarded-Encrypted: i=1; AHgh+RqlibjHlTiLlq7SuTGqrWvoNcC5tAVhRFj8aSjwAl1hoPTzVqVfNs0lkxF6fDgpP5TjhirtOXF1X5AfpII=@vger.kernel.org X-Gm-Message-State: AOJu0YzQl9jxKgWcHiBdfHXrcj3q8ZHImL7rHC4NsyZcUdJ2UCRz5uIk 9Igat6EPxVOsUFjw2fRVumo9kKtkDvQFZPQhlLVT5XvONKb1W7exQE2p X-Gm-Gg: AR+sD12DJBzgUDgFaAOgDPiActezU8KL3EnW5lV70WP+ZyaHuSPORo8tXRI5o9zUBUT eH7OZTUSEeB4yoOKHdWOSUv676ySKG67HdrW0t7e2jpZbVv8W18wgyZ4kX3ov9UjQrYYqdESeVA K8/gVSbZhOhc5IPkztGks396twX55ZlQoTWDSiqjLfVxlUt9oXJ0PvGQmbGCVZ8b04rI95qhl1i mFCFbu0xmlnHYwPImag2zadkVGSDHrY2GawpRHjNfa7WPiVqBTlW3yqUg1Atp6CxTc/uTT93JF5 cVpXgPCMOwJ/wrCXNjQdby7e7zJ8gCjIxurkNoLoUSXaBTVE4dI7+2uK1yi1i5cB4UkcQjE9ZAN qE3zeQSi+mJi1u0yzYI0afyUt5FUUqEBYewxu0M1lCwy6HGUGrEemzSpALg3nzNrHzzVLqL16OW Z2T25azSzaG7I5J9V1ZLbFkqnPdaoebYcz0BDybU1hNZtySeKV9wEFG6HBBAz6V4U= X-Received: by 2002:a17:90b:224a:b0:383:5a16:bd70 with SMTP id 98e67ed59e1d1-392cca92597mr3389754a91.16.1786385537188; Mon, 10 Aug 2026 11:12:17 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:12:16 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v3 15/34] dmaengine: pch_dma: convert tasklet to dmaengine BH Date: Mon, 10 Aug 2026 11:09:16 -0700 Message-ID: <920e972b55af0bcebe09383f5f00cf5dc75e5cf6.1786384168.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dmaengine BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/pch_dma.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c index bf805f1024f6..eb372aa328a6 100644 --- a/drivers/dma/pch_dma.c +++ b/drivers/dma/pch_dma.c @@ -91,7 +91,6 @@ struct pch_dma_chan { struct dma_chan chan; void __iomem *membase; enum dma_transfer_direction dir; - struct tasklet_struct tasklet; unsigned long err_status; spinlock_t lock; @@ -665,9 +664,10 @@ static int pd_device_terminate_all(struct dma_chan *chan) return 0; } -static void pdc_tasklet(struct tasklet_struct *t) +static void pdc_tasklet(struct dma_chan *c) { - struct pch_dma_chan *pd_chan = from_tasklet(pd_chan, t, tasklet); + struct pch_dma_chan *pd_chan = container_of(c, struct pch_dma_chan, + chan); unsigned long flags; if (!pdc_is_idle(pd_chan)) { @@ -707,7 +707,7 @@ static irqreturn_t pd_irq(int irq, void *devid) if (sts0 & DMA_STATUS0_ERR(i)) set_bit(0, &pd_chan->err_status); - tasklet_schedule(&pd_chan->tasklet); + dmaengine_schedule_bh(&pd_chan->chan); ret0 = IRQ_HANDLED; } } else { @@ -715,7 +715,7 @@ static irqreturn_t pd_irq(int irq, void *devid) if (sts2 & DMA_STATUS2_ERR(i)) set_bit(0, &pd_chan->err_status); - tasklet_schedule(&pd_chan->tasklet); + dmaengine_schedule_bh(&pd_chan->chan); ret2 = IRQ_HANDLED; } } @@ -877,7 +877,7 @@ static int pch_dma_probe(struct pci_dev *pdev, INIT_LIST_HEAD(&pd_chan->queue); INIT_LIST_HEAD(&pd_chan->free_list); - tasklet_setup(&pd_chan->tasklet, pdc_tasklet); + dmaengine_init_bh(&pd_chan->chan, pdc_tasklet); list_add_tail(&pd_chan->chan.device_node, &pd->dma.channels); } @@ -930,7 +930,7 @@ static void pch_dma_remove(struct pci_dev *pdev) device_node) { pd_chan = to_pd_chan(chan); - tasklet_kill(&pd_chan->tasklet); + dmaengine_kill_bh(&pd_chan->chan); } dma_pool_destroy(pd->pool); -- 2.43.0