From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011051.outbound.protection.outlook.com [52.101.52.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B395733A9C1 for ; Tue, 28 Apr 2026 16:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.51 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777393781; cv=fail; b=bwXJwSXKeBhEK+aWBd9NuAfiq+DK1hCLWR8RofhC3bEUwyKkj+hpKYtkSTOSn+zkU0wsfp9csSLWzQHapTnxGQ9bpEnLeTVEC7Qe75Y7hjSvTYptOMlXQbgSXVgPuY7o7R+0cWGRH4zhJ1SHwN5InY2iQO0xwdY8JUf74t2yDGY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777393781; c=relaxed/simple; bh=8uCmqcjgiCIXEWH4+7zxwAYolbsnQaAtM4ArPNh36mY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=WYU9Ort62rw2tiY+dr/OtguhPuoCgjYVPhfj/ZaiUX2jmaBWblfEIXZOH3tS9dxeieLfSIrSlLzbcIkj4VgMGLCDu3AoyrUk6sOocNR68k1brFcCSPjzIxLQ+H+E+FjdeYWFch40jPCPYIswT9ebi7JDg9oFbX3+E2Yb6KHYaWc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=sIodUHoQ; arc=fail smtp.client-ip=52.101.52.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="sIodUHoQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O59ae1XtNqHRZXncO4XIktOTfxRqS2X3VrqQBgsUoMupgC56+EM2hPkv4St8/ci1XDH1Jl9Y+juuJm0uN4vE0i66s+mFYb1zVkqDrQwDT4Yab8r1Q2wVBh8CSS6GfM0pzmFeFaeBLLqSiaxZ2VwxkWqZ4ulV2Qmd+QM7SzbNRz/KLzyfbWQ8ZB4EM+nfZFPEVAVGTfTJ4UC2ehwqI1LixGUNg9tOhIkjS0uUV7lc6cDSn6zkpZIgYo8Nt0M2fkwBoZL47u2klTKKNHotOfDH7efsn/RuStuDU7kvlj9UkBB428DqXobdR6ee2DQpS3BKKZAu70MXJuWJA2xF5VINfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gyVkOTv1BZQ3hT382IIO4kxP7uMZ4HtwtTSM/2iAJcQ=; b=FOdqK+gMJpUBD9M6fKEoAhoy1rxni1tKDafgbocmRL7Nmin5zcH882/iDfzF39Y8Zd5qnGJR2sRdjyw8FNJMUQSGW9RxbPMtcUemIPtqTfiYPZp1dJgjdyyVIupQZltIAHzdsQsGrzdXRM5GoXt3AVoxdjtzoKoSlov/0IEMcN/Km54ayIAhDC8roC92mZViJ04LRT0j73AHJgxkrGAchhVKKojCCXKnmd4TUDTWfiA5vF++FtnZX0y71Q7+titw2y32qm5veO85CKVOcfIKmn0W7HcthOV1n+uz96x/ISHj0yWwUNpbgHVbEgPGNgRXYUoWv8NPXIKn3Z3Gc1G1qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nvidia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gyVkOTv1BZQ3hT382IIO4kxP7uMZ4HtwtTSM/2iAJcQ=; b=sIodUHoQNQxfD113FgEghgccpg9lemlGDVvOFBfBKNATcUFNKwbkkCkO5BOnHmg5M9ezVMDyya/tLCzqo6SP37evbbXbTxm1NNJms1ajCR3OaOmRDyNXj4GrBD7L5Us859dL1CD8oEqDSLtvXbFhTyDVRXeZgPC09NImULzIJW0= Received: from PH3PEPF000040AE.namprd05.prod.outlook.com (2603:10b6:518:1::59) by CYYPR12MB8654.namprd12.prod.outlook.com (2603:10b6:930:c9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr 2026 16:29:30 +0000 Received: from CY4PEPF0000E9D5.namprd05.prod.outlook.com (2a01:111:f403:f912::5) by PH3PEPF000040AE.outlook.office365.com (2603:1036:903:49::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.26 via Frontend Transport; Tue, 28 Apr 2026 16:29:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CY4PEPF0000E9D5.mail.protection.outlook.com (10.167.241.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Tue, 28 Apr 2026 16:29:29 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 28 Apr 2026 11:29:29 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 28 Apr 2026 11:29:29 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Tue, 28 Apr 2026 11:29:23 -0500 Message-ID: <9212f983-913f-4a90-867a-90649e7612b7@amd.com> Date: Tue, 28 Apr 2026 21:59:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] sched/fair: Drop redundant RCU read lock in NOHZ kick path To: Andrea Righi , Ingo Molnar , "Peter Zijlstra" , Juri Lelli , "Vincent Guittot" CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , References: <20260428144352.3575863-1-arighi@nvidia.com> <20260428144352.3575863-2-arighi@nvidia.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260428144352.3575863-2-arighi@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D5:EE_|CYYPR12MB8654:EE_ X-MS-Office365-Filtering-Correlation-Id: 908ef38a-efd6-4fff-2747-08dea543527a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|82310400026|376014|36860700016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: owUuvMr+jf28IcTq2bk13kadi5gsBbmbLq764Pe9Oc8pwU6Arm5mgdJgXHZRBMLEcy+fUQHSyHZsYmM+t6rIi1y1f3M+mAQW5xql32PrQWsJhLzPo/w12SgI1+wL8CFle2pJ4FuQNcBLxhuKN3OFId++r8aCljpshORKsny07s6AbIjX728UeXAfigyQKFfhA9Y9AMucUwk6GN03R5ASETk2inKEeIA2tMCB4ijYPu6xxTY2avnIVvgXggA1XwT5kAtT1B3cmKjelxcSvAChN1WL2hNW9p5lhBnhQr0WgYAXq7VDv2LetVppbzW6VTuvHrsItVndZZQwFQaDpTEg4UmwA/LRbP420PjXPKLKaX7kXmwY3+4ZyKg34bXHuBoCyOIwd43va3y9De6XRTR/nMpnEY/EMdNTsYLhyejSVzuQ0jNck2kIWO0w24m1UgAi7FhexSUYAGokir5RM7ZZHZgxQ0dicCZ3Xz65T83tf2VOlNaqs6YXCUI2lnzdiSNNKW/reFf7EomdfbbC5U3UauD5cruen2hFOPsXSomo1NYgO9ivH3s013sGEivGYHWJtlVWroQ1USn6QMHgWs/fk1V9QOvqYcf16xY72xJJaOpopdhhLx/7f8YneSZ36SYzb0/7RqSbwBB7rgBD0sCwj2TiedHrnTNlDs9DPu44JNoNzLzhngPB0F3FSb/I7frRpFR2Hli/sTzf+OaKjnhAeUN9awv0Aex5oazUR2xpLJpmwpS5Ui3llUIcolKwPO6E9NZGDSmsha4HHSIaUGHGkA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(82310400026)(376014)(36860700016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: i6HqkGiBhcoIFKxKOs4/PPUaoEWqs+6urCZ7NwQNFq5ToRaDEyWi5gwjsfzjztp3IgP6LszrcDtp1IOvlmcM0jFANAYeb8WCVBXRckGi1ovo27KQlbeS9zQeU5zMEY2TqcQ/Gx9aAn0nidbvzdxs0JUx/WUZ35FWlfKf7bppYDLCR+20heySv7Juov0lw0Nuc6GJBNNY8kqC/dPsXZhbQlldtu6/UAV6vP2CiFtr87Yy6YXYBzCOayAUBP9zXSbmF0zENzb01Sb2Z7KCvQ8nbyhJF2460G+sJRqcJ6gtOjmy0oa/ss+sdUhqB+gig24voMZSTHgx8NrPDcTi0POIhvIHn7ESLfGTEzhP/Av4FkCKxz0bDabMedmuUAh63WF65hVvdchDTUUVD3ICnml4WcV3C0bACL1BpHr4D7jQBBJJ3R4/pbXsh6jlxfD3ZO5w X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 16:29:29.7390 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 908ef38a-efd6-4fff-2747-08dea543527a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8654 Hello Andrea, On 4/28/2026 8:11 PM, Andrea Righi wrote: > nohz_balancer_kick() is reached from sched_balance_trigger(), which is > called from sched_tick(). sched_tick() runs with IRQs disabled, so the > additional rcu_read_lock/unlock() used around sched_domain accesses in > this path is redundant. Rely on the existing IRQ-disabled context (and > the rcu_dereference_all() checking) instead. nit. Perhaps a small note like below in case there is a follow-up: set_cpu_sd_state_idle() is called from idle entry path after the IRQs have been disabled making the rcu_dereference_all() check sufficient. > > No functional change intended. > > Suggested-by: K Prateek Nayak > Signed-off-by: Andrea Righi Thank you for cleaning these bits up. Feel free to include: Reviewed-by: K Prateek Nayak -- Thanks and Regards, Prateek