From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57ADEC43381 for ; Mon, 25 Feb 2019 13:01:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C2662146F for ; Mon, 25 Feb 2019 13:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551099666; bh=69FnVARUlyMQ26CJ/uzzs5CRY5xq7v3TahGsjA7jn38=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=GMRbVZ0zZVPxqLOT969dst2tX3PiWXZQ+Q0duXdrsrXiFI6J3Y6SSiDnUxQBNNOmw j8UYV9vpq8uElkZTkndGcZU3WUfPXOmRvwUMet/Bnt9ddMbc2AvjEV40uC2v+GsBni 17mg6c5FDpYzWjP4HA0H1Ob1+6cDbusrRLQ9D7tQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727034AbfBYNBE (ORCPT ); Mon, 25 Feb 2019 08:01:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:52706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbfBYNBE (ORCPT ); Mon, 25 Feb 2019 08:01:04 -0500 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0237220842; Mon, 25 Feb 2019 13:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551099663; bh=69FnVARUlyMQ26CJ/uzzs5CRY5xq7v3TahGsjA7jn38=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QZEXiY6uunLHmxTlqhuR/97yKDBVIc9VkZG+jNit9OdJZ6vaV9cGuEnHSF9k7fqUn p8YdM9Yz91Ib6Thr/RPGO2TMdre3QEE38A7Eq555PVeM7UN4n0PIqobSYVozRmKKJR BXqLKXqXOHEDg14QNFQa0uHEa7ubPLtDBSoYHkIA= Subject: Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033 To: Juerg Haefliger Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@redhat.com, mhiramat@kernel.org, linux-kselftest@vger.kernel.org, shuah References: <20190222091021.10178-1-juergh@canonical.com> <20190222205351.743-1-juergh@canonical.com> <20190222205351.743-3-juergh@canonical.com> <20190223132551.5afc02bb@smeagol> From: shuah Message-ID: <92139bfa-0538-f912-a164-f962b37856ee@kernel.org> Date: Mon, 25 Feb 2019 06:00:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190223132551.5afc02bb@smeagol> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/19 5:25 AM, Juerg Haefliger wrote: > On Fri, 22 Feb 2019 15:46:03 -0700 > shuah wrote: > >> On 2/22/19 1:53 PM, Juerg Haefliger wrote: >>> The \e sequence character is not POSIX. Fix that by using \033 instead. >>> >>> Acked-by: Steven Rostedt (VMware) >>> Acked-by: Masami Hiramatsu >>> Signed-off-by: Juerg Haefliger >>> --- >>> tools/testing/selftests/ftrace/ftracetest | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest >>> index 20c9c0ad8682..136387422b00 100755 >>> --- a/tools/testing/selftests/ftrace/ftracetest >>> +++ b/tools/testing/selftests/ftrace/ftracetest >>> @@ -161,10 +161,10 @@ color_green= >>> color_blue= >>> # If stdout exists and number of colors is eight or more, use them >>> if [ -t 1 -a "$ncolors" -ge 8 ]; then >>> - color_reset="\e[0m" >>> - color_red="\e[31m" >>> - color_green="\e[32m" >>> - color_blue="\e[34m" >>> + color_reset="\033[0m" >>> + color_red="\033[31m" >>> + color_green="\033[32m" >>> + color_blue="\033[34m" >>> fi >>> >>> strip_esc() { >>> >> >> Which release is this patch based on? >> >> This one failed to apply to linux-kselftest next - I resolved a minor >> merge conflict and applied it. Please review to make sure it looks good. > > Looks good. It didn't apply cleanly because you don't have > https://lore.kernel.org/lkml/20190220153706.24686-1-juergh@canonical.com/T/#u > Sorry about not copying you on that patch. Want me to resend? > > ...Juerg > Yes. Please. thanks, -- Shuah