From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E813D332B for ; Mon, 30 Mar 2026 13:19:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774876754; cv=none; b=BK85bpyRGFLefOJ+CFI8UeHBbAk3zZY7QNRkQCe2e2P3IAL1PehW3Fkf22F/EFfsQjUs4chiy5A+LJyx8jHbWeVcxtjBNMm5N/XMoB2EKLIOCYrPe+VoW4eVjYXyl52O5CmCeOoeSOQfZHKHphGnJ+ba7WgPNXTo/gnZJqw6Wo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774876754; c=relaxed/simple; bh=fa0YDhKwhZ5+jDZZzT8LMkH3gOrvByVwmZV0YEiz/uA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WsR8XMzyty0dFNjvviUkbU0nyKKjnZBS7e6xGNKc2YNa7MvTIsdMeKXiv4e34Cl1IQCSfKNyPAaHit3fzOTaHdHNDpPtcMOzUyuj+N5/Qstfoo3gZBv9iVVyyOApX4kBEIjf9B+qctsdWLBPOzSLTZ+gQRXJODE9aYWw7+TySbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B2k1iVls; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cMMkKS3A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B2k1iVls"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cMMkKS3A" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UBEFI61402699 for ; Mon, 30 Mar 2026 13:19:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gp/uAhNpvhPnAUsObjj3qF3uuB/aBnDtd70JcAQP+kc=; b=B2k1iVls70uAYgIk snrpdmdAwIqq5Ojpgb5vsRnNgpo4fqn4ZmsyTwxCfeX/nPSyMl12kudsfhVzHIKS SiI+xOKGVgq4E7iAMRWpLAUccqXRDmaIa5PnMfcp6rXrNo0UIgTOd+oKkcnDLpc8 3743izqBfYbNMM7NR8eUXeeIUW4ky2xY6MiyPUfCpIaqGnsODOuUAlKj+1MngQEE GDHXLTtVPvjC6kiEAuzeLGL6T4W2FKAE+rqv/3IZu/VUjgssMVZpGOWCYEmUzvO1 2dVtrZBmYaf7GTSGl/qmoYi4Qoyr4PoPV89I8d3GHUjSjuKGEOPsQv9/Oquz9+yV UdYbTQ== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7r4h8k2s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 13:19:11 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-953b34649a3so21141241.1 for ; Mon, 30 Mar 2026 06:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774876751; x=1775481551; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gp/uAhNpvhPnAUsObjj3qF3uuB/aBnDtd70JcAQP+kc=; b=cMMkKS3AcTvUhMpFBh9tvpDQnK443y+t8cMR6PEZbv6VOE/CMmD+r4QiFIlkkcpFYY bMRVEcfP6EcAKe2KZo9CgbkoIhepk/JRq8rf6htlmPnPY/xfMtRfDHb5xbegXRs0h5Qz aAziCFMeWdh+olLqRU4CjlDD8gW/0HvN0a9umMrJ+OYPE4j2kroFHufJyJSTqKQSpDim TWvTZCuy+wGIO2oPasiW4OKAfqg8Hw62P3kVpLJNE1ERI9UEMwMmloXL0CkWh3W+piNu h4B8+KZWfQo6Nu/TPxip13FT2oQVxrsNBv68ts8vaMEgph3419uZAcyhDfJFFj3G3NzA Gotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774876751; x=1775481551; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gp/uAhNpvhPnAUsObjj3qF3uuB/aBnDtd70JcAQP+kc=; b=jxeIT1KtZLwisxowTzDHup+1Lh4Jzzzcmaf7MbQzGBMSTLyDxvHvD8dFbIhrkG2KoZ PmdBDIrLTb61zyJMJph2hv/JeEP2ZVsVzZVW8BZpKKRImVp+WOiQQ3BDHKefGfUwvzsE wHamky3Wy70FaoeogDQNZgOP45/4HdVdbGVasJUGdNQ/x2XlSBRPScjI03ZVA6YvVt4B HFTJ19B3IHVRWKHP1HqAovT556lZIjerxs/TEreG2b0+xxFw/DLsHfVCBNE+CNk8PhXo RzpEMnEBgOoLlwTN1/aQGsKkuM3MHvpPLG/n+7J9DVsuAPg7lKA4SDVocJ87pwxF0xQm BxXQ== X-Forwarded-Encrypted: i=1; AJvYcCXMCxg902TR2QE/m6/PCFlRyp0dA93mHc6r1F7Wcl0m2E2X5dCTZ/AqKtkZaudKwO0F5s4oYbng4yh6tSM=@vger.kernel.org X-Gm-Message-State: AOJu0YyUoFI9PBpjx5XivBBqQC0k7GAm8A+EmyvV9fUkp3ApCus/HTNO ya6pKuFh+VVyBlTD7xZbAdQKcFjnwl2I0okiAmiKtVs1KCJhvfkuHfvLhgeO09IctSyAxEPuwV8 BlMQ8QygJ+k1arCT38bwuFGqnO28D4DyAGYuAQ0+w2kUr6AFNaPFQ3uTFsGlVyMnhFQY= X-Gm-Gg: ATEYQzz28tw45RspboJy750r6UtB6jBVm40XV38vAF6Y4P8ljfGcRi9gBh32BpAiph6 cvVhxzCy1QDo1OA3q3eDE/HkQHkRkcy82F+xG8k6bGUF+SKHmUbP92tjYcqEwgC/NHSjiVV4xt3 kZIvu/hE2xZj3OTvim1qinMSkpjGhZnqSxRMsRBgDXq5ClQCQg8ehRpS0NHmQw8cxwKepCSGWAs ZAd0ZmSg2lgmjagMPsUdxXd7lnjfqZSXNmlBCG8RtwHFoo76VDFEKS2BM4ew+iYrj7UdNbCG4+z l26aNiz1+CYhkpbOr1bpLX8KHHecCvnzYhkm1pNxDhKCskYKxPJipZdWsSJtZ5tX8t5gEVjeoWe 6q7XJutVKfFX7L3aX2yq5JaWQMM+2z60IxhoQn/PLhdpNWapHwo7l1k7cBncBLvvIKMDo8NElDz q/gWo= X-Received: by 2002:a05:6102:5cc:b0:602:9acb:64ed with SMTP id ada2fe7eead31-604f92f2a6dmr1649195137.7.1774876750965; Mon, 30 Mar 2026 06:19:10 -0700 (PDT) X-Received: by 2002:a05:6102:5cc:b0:602:9acb:64ed with SMTP id ada2fe7eead31-604f92f2a6dmr1649182137.7.1774876750536; Mon, 30 Mar 2026 06:19:10 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38c838e171fsm15451261fa.37.2026.03.30.06.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 06:19:09 -0700 (PDT) Message-ID: <9214ca24-77a0-4597-9c28-12574452fdd9@oss.qualcomm.com> Date: Mon, 30 Mar 2026 15:19:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/6] arm64: dts: qcom: talos: Add QSPI support To: Viken Dadhaniya , Dmitry Baryshkov Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260324-spi-nor-v1-0-3efe59c1c119@oss.qualcomm.com> <20260324-spi-nor-v1-3-3efe59c1c119@oss.qualcomm.com> <34cifkyw3pgky4nhcu4jwf2uveszre23kvesr7ksyjvmqhfspo@avsvwa3quvsp> <9d7c5d36-c981-43ed-a08b-3b75c25fad1e@oss.qualcomm.com> <20062190-609a-4977-99be-c27df90ff321@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20062190-609a-4977-99be-c27df90ff321@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDEwMyBTYWx0ZWRfXz+7t6JPJbQTY 7I35IHe4N7AA3+OnpgZVKY7vNqdwCeuO6HpOych46jgWFFHK0HYF2QKZtogcacBA3ymzFuONIFI d1RTGr2fi1cAI9LqB5CmJV2/lwfs8bepuonyPgRE/raIL/P8EmsodGw8dIaT4AzHGVlps3QQLUG VgJA4sHtk57kagNzJu9JvNqbxS4huxua5dHTsuxqpYBWId0fUq14yfQ5bSiwFk0uV+fEA//rQi6 GPMbznKDp0DRwouX5xWkfDZELSMbWFqzdWwuYPBZo9GBrdetmRYFukkcZSPZKG8VhPINpsf76UM J7OerK1+UIrMAeiu8chcQe4PLpoVxqbM+iKcuRpnHPEWm27X5Fdi+VRGihoSXSYapp0miL8bt27 J8565FNFX+XHh28n9qViQjk4YVcpswQ+4Eb3wg2IO0O20RnmwWB4NmxaSuT7HfQwTmhbO1RN2BD Z0iJsbhUKYPa3Tr//iw== X-Proofpoint-ORIG-GUID: Fu9UKTYU5rWYa-OVHfndqX1ENiF7jGvM X-Authority-Analysis: v=2.4 cv=PI0COPqC c=1 sm=1 tr=0 ts=69ca784f cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=_JphER5ef4O4mSyQYpUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-GUID: Fu9UKTYU5rWYa-OVHfndqX1ENiF7jGvM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300103 On 3/30/26 1:23 PM, Viken Dadhaniya wrote: > > > On 3/25/2026 3:02 PM, Konrad Dybcio wrote: >> On 3/24/26 9:51 PM, Dmitry Baryshkov wrote: >>> On Tue, Mar 24, 2026 at 06:43:20PM +0530, Viken Dadhaniya wrote: >>>> The Talos (QCS615) platform includes a QSPI controller used for accessing >>>> external flash storage. Add the QSPI OPP table, TLMM pinmux entries, and >>>> the QSPI controller node to enable support for this hardware. >>>> >>>> Signed-off-by: Viken Dadhaniya >>>> --- >>>> arch/arm64/boot/dts/qcom/talos.dtsi | 80 +++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 80 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi >>>> index 75716b4a58d6..fd727924b8ca 100644 >>>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi >>>> @@ -530,6 +530,25 @@ cdsp_smp2p_in: slave-kernel { >>>> >>>> }; >>>> >>>> + qspi_opp_table: opp-table-qspi { >>> >>> Why is it not defined inside the QSPI device itself? >> >> The QSPI device has #address-cells = <1>, so we'd get: >> >> Warning (spi_bus_reg): /soc@0/spi@88dc000/opp-table-qspi: missing or empty reg property >> >> Konrad > > Yes, I am seeing the same warning when the OPP table is placed inline > under the QSPI node. > > Given that opp-table nodes are not addressable bus devices and therefore > do not define a reg property, what would be your preferred way to model > this while keeping the DT warning‑free? > > Would placing the OPP table as a sibling of the QSPI node (for example > under the same &soc scope) and referencing it via operating-points-v2 be > acceptable in this case, even though there is only a single QSPI instance? I personally don't mind it being in the place where the current version of the patch puts it, Krzysztof? Konrad