From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2062.outbound.protection.outlook.com [40.107.236.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F6BB14D430 for ; Wed, 18 Dec 2024 06:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.62 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734503189; cv=fail; b=n/pyALku/RXG94rs+lq8jyMdX+qshI+8ibxFKLeEFEA/anLN2yPkQHig30UKKQ/Sw3V8mpwsVbsL8wp+c2twJtvk47QAEcGumULb4MbjkQSa3wivdApUUUn10D8I+GsHdNeeis7/ANV8vr+lhFABy6dpXvFV5L1LxMWgrktdE5Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734503189; c=relaxed/simple; bh=Kyewfxnanskq3p0L6swwn9KhZQSSmUOu4lY8tr4skkk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=F8J3q2/qmfo//wdo5B9Heuwcfonyo3KYrnrU2dROfSlnoHcmP1zAg0w43z4Gat0y1CO0pHxhDpgTPtA30rB6KFEZzESCflyMSGMaFPrDZoI5srV7fPfVtIZepYC6T0vfI1u4gAZ0YttncygKzOWCctpafLc3yk/kO0MYtO6pW+Y= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=HcMCMEo9; arc=fail smtp.client-ip=40.107.236.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="HcMCMEo9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nQRC1u27W30bv4BIFjubwP0nah8eG7V87EsZQFCJZwQr4Rv862mWM6uL0k8lAesntmBRW7vCVHcy8F+sXelw0JzLM1jRVcGJ5vemqSYcAKrmcFVzHOfDcLQVg8QceCWAxe9RQLMDrgp4yx35COWb8EYKKrt2PdhjXenc2KCy9SEhcpAcNo98/m33FI2l7KX/fou04exDqjKbx2kMrZ9stTEIxZyT1xR7LE1xiYIYHfcVT9S8nhpax0Qeeb70f4qh/s7P4kedP+undibt9aN9r0zXPOX0QGnZWNBUfMJqPXuHrovRRHHBFIcPqsV7XKaJRGSW8xi8aMLWoOxGsr+mRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mrViMbzNUvaMCJjkcFVyQpIXw+4Ajqd59SqMx5OL4lc=; b=v7C4CerCnGZRoja6lM9IMLVNi/2ljvEaDa2Z7/iOmpfF59H03mT/QFD3ZY60BwGU7Qq0iZ2WLNwbYV+v8/qmXBch2EWXn+xLlvqVoWgKUkqao6PI/PiE6+RkvJdKdkNmoeyd1jPEYfLu5r8yzPY8FIZuzInqXVnCt46FvSJ2+NOcMxTzjRbJTTNtB497YQ0Z55fyUBYg2+jcOeB/eGfRqDS7fZJe8uQ5Yy7NWOmi/vgEAcZ+8EQc2j3YQKRuM8UwJ6qrtdx/X5Fnse1b5tjek4/CAoPQm0dQMAnKzyEqec4PSBbkUFtVOyxOtrKXgMMPKR8v2DITBQszrsrK4FXAMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bytedance.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mrViMbzNUvaMCJjkcFVyQpIXw+4Ajqd59SqMx5OL4lc=; b=HcMCMEo9Wy1JxeapShOAm/Ue3AN6zDXuQzP/hM1TC+3s07mlKpqrQ+dt8YONN8WqxaiL8+5Tt3yy7Yjl8LFJ1p5Cgx8LuQMmZ7RhgH5JJBnJV8gmEAzNyDmPj1/DfdK0pw6dL+JpHD4eFPCZHP1zG6wgpTXvodB2u4oacRUpSt0= Received: from MN0P221CA0014.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::34) by IA1PR12MB8493.namprd12.prod.outlook.com (2603:10b6:208:447::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.21; Wed, 18 Dec 2024 06:26:25 +0000 Received: from BL02EPF0001A100.namprd03.prod.outlook.com (2603:10b6:208:52a:cafe::cd) by MN0P221CA0014.outlook.office365.com (2603:10b6:208:52a::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.23 via Frontend Transport; Wed, 18 Dec 2024 06:26:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A100.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8251.15 via Frontend Transport; Wed, 18 Dec 2024 06:26:24 +0000 Received: from [10.136.34.246] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 18 Dec 2024 00:26:21 -0600 Message-ID: <92168453-ecf0-4849-970d-4c19a5a610dc@amd.com> Date: Wed, 18 Dec 2024 11:56:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] sched/fair: Ignore isolated cpus in update_numa_stat To: Chuyi Zhou , , , , , , , , , CC: , References: <20241216122357.1276382-1-zhouchuyi@bytedance.com> <20241216122357.1276382-3-zhouchuyi@bytedance.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20241216122357.1276382-3-zhouchuyi@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A100:EE_|IA1PR12MB8493:EE_ X-MS-Office365-Filtering-Correlation-Id: 02aa1e0e-833f-4847-8e59-08dd1f2ce5be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|1800799024|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZUdCaUNacXpMSythaitmeGpWdUwwYk1ZSWZScUZIbnkvanRtNHlTcEpJV0VD?= =?utf-8?B?b3ZpbUpTdGVTOS9jNnd1Ym9SdE40S0xnWk94SnR6V2t0TFlOellVWCtYbEV0?= =?utf-8?B?aHZlRjRoNmhPcy9mcVdTWkRSNFkyZCtkaVZyRWV6U3lrVmhScVUzd1VsNExG?= =?utf-8?B?cUJveW5aV05nMFBNWFovdW52VmFaajAvdU5hUGU3TlRYQ29raEhQYi9na2tL?= =?utf-8?B?ZUZ4bm9iNVNYdU9yQWx5THh1WEtWWDhON0xINmdqQ3JQWitPR3l4d3N5VVhR?= =?utf-8?B?NEYzSVVXa3NoUGx0Mjd0NzJ2VnRBdDh0dVRIenJvM3FMRVlXS1NZZkNJeTE1?= =?utf-8?B?N09US1RBMWZCMnVMN1Zsek1GQXozS0V3VG53Wk5KTnhqb2hSVGxtTzN1SHNr?= =?utf-8?B?R0hZVk9la1I0OC8zU0N4dEJVdGMwSW5NUkQzUUsxaDlkSENiV05VMzRyRysz?= =?utf-8?B?amYzZ1F4WEtxcDl0MjQvaDZoMGhBVUVtL1NjVERUYjY5cWFld29lc0UycmR3?= =?utf-8?B?QzEvYlViVlJLUFlpbHBaQU1DTzkvdWJ4ZlRPWFo0UVRlSEpFcWczS0Y2V0FN?= =?utf-8?B?aFVEYnZTa1FFWDYxd3JMQUhtWEpGeVJ2b1kyMmErdjd1cyt0ZkdUcXZLL2cz?= =?utf-8?B?NW03NUFMcEg3aVE5WTFNb21NemppeWk2Zlh1dC9iVmc3RFR6YllIY21ISWRy?= =?utf-8?B?RGRnMGp0aSsya3FrTE1lODZWeTVuTFhPRHkyMnRBbzhrWGc2KzFuTTEyYk4v?= =?utf-8?B?MzFLLy9QZ25vU3RieEl3cms3NGoxZ2xxUiswWldLb1E3RVBhWkhMR0lVa1A4?= =?utf-8?B?VGRQTW9ud3IxTFd6V2RYek1QK2FZNG1XWkhEMlRnNEVkcFlpVWRQNFE4c0tu?= =?utf-8?B?MndYN3JONzFaKzlqNXBNb3FzdlR1MUZ1NVkrYmpPdlhtS3dRdXV1bUVjdEdB?= =?utf-8?B?bmhLQmdvMndQTFlwTDhpcHJzbDJvQWhKdjdzdzdIdXBkWmxtZzZ1UTRJMDFW?= =?utf-8?B?K1VRN1kwZ0Npb3VkNDE0Mjh0WE5CQUFudy9VUWZoRjhydmYzTnJEVWtsVVFm?= =?utf-8?B?Y1BwcVlWVUZBakRmVDFJRGFXeVBpL1AwQWlaSUZ2bjFzT3phbFEwNCtCZHVu?= =?utf-8?B?Q1pqMTAzajBlenE1TE5XWDNMekhEcThmRjBDS3NyVHgwcVFGdlVVdk5yV3Bz?= =?utf-8?B?dytUQmFTMEdDVnIybWNhSFBETXdtOWRFUy9WUUNWdWdjVFliQWtkaDhwRHRu?= =?utf-8?B?YmN3Y2pTdmJmeWdOUVFCYk9pU3Nzeis4WW1PNlM5VkVJekpaY1FRdERhRW44?= =?utf-8?B?TWM5UHQ2cHhGdEFwY1VYYnJFVm5JK3ZXVzBKTFcvcHV6ck5GaFZkMWJjbGJ1?= =?utf-8?B?WkZZeXduRzJhUGRqc3M3MFlsd0l1QktTbUhaTFNBRmJlZTBJaVJsZ2lVNElW?= =?utf-8?B?VGtIbmJqdWR6c2dROWl5dnk1U0RXMjlXKzczNFNRSTFoV2hrWUhSZGp1MzE2?= =?utf-8?B?OGtnVitxRi9DUEh1MTRFSUNFeUMyRkQxdTdNaGtWZXY2eDJFU1pQcWx1QzRh?= =?utf-8?B?ellqTnBKVUd5K2tGc3BBS0lQeUZ0MzFTNlBnMzRvWE1kL0ZsNWtZVmU0enFG?= =?utf-8?B?cGQ0aW1XRWYwaTJsQ1Rrb3p3VzdpdTZVRWRpMjcyd2pHeCtRV1VwRENtOFFt?= =?utf-8?B?dklSNkdrNytzR2Qyb3lDc040bVg3WkRGYnhFd2dQdFhBOW9mYnY4UjhGeDlM?= =?utf-8?B?RUhxUjRJcUMycHE3bmFxM0FxWWZwR0kwQ2drN2gwSzNWM3d5eUdaQWw5VzZn?= =?utf-8?B?Zkg2N2FTL2pZWG1iOEhCaEtGaGxYVGtxN05Haml4Y1B3MXE0eUM5ZVE4Tmw4?= =?utf-8?B?MHUzUCt2dUg0SVhhekFBY3BTbytyTnZWV1N2SlAvSURHaHVsRzcvRy84WHhL?= =?utf-8?B?MXJtOVJFdFpVWjBMYVMyeGxtTXVCcVYrampjeG14MmZaV0FHQ2FGTWoyajRF?= =?utf-8?Q?UPg8/85Z68L3e3zSRO3ULkMrNYph9E=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(1800799024)(36860700013)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2024 06:26:24.9346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02aa1e0e-833f-4847-8e59-08dd1f2ce5be X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A100.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8493 Hello Chuyi, On 12/16/2024 5:53 PM, Chuyi Zhou wrote: > [..snip..] > @@ -2125,6 +2125,11 @@ static void update_numa_stats(struct task_numa_env *env, > for_each_cpu(cpu, cpumask_of_node(nid)) { Looking at sched_init_domains(), we only build sched domains only for active CPUs in housekeeping_cpumask(HK_TYPE_DOMAIN) so similar to the question on Patch 3, can we get away with just modifying this outer loop to: for_each_cpu_and(cpu, cpumask_of_node(nid), housekeeping_cpumask(HK_TYPE_DOMAIN)) { ... } Thoughts? -- Thanks and Regards, Prateek > struct rq *rq = cpu_rq(cpu); > > + /* skip isolated cpus' load */ > + if (!rcu_dereference(rq->sd)) > + continue; > + > + ns->weight++; > ns->load += cpu_load(rq); > ns->runnable += cpu_runnable(rq); > ns->util += cpu_util_cfs(cpu); > @@ -2144,8 +2149,6 @@ static void update_numa_stats(struct task_numa_env *env, > } > rcu_read_unlock(); > > - ns->weight = cpumask_weight(cpumask_of_node(nid)); > - > ns->node_type = numa_classify(env->imbalance_pct, ns); > > if (idle_core >= 0)