From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891AbdEDUdb (ORCPT ); Thu, 4 May 2017 16:33:31 -0400 Received: from mout.web.de ([212.227.17.12]:59988 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbdEDUd2 (ORCPT ); Thu, 4 May 2017 16:33:28 -0400 Subject: [PATCH 3/6] cxgb4vf: Adjust five checks for null pointers From: SF Markus Elfring To: netdev@vger.kernel.org, Casey Leedom , Ganesh Goudar Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <921bc451-3b7b-1d77-72eb-755061a7fe09@users.sourceforge.net> Date: Thu, 4 May 2017 22:33:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:LBbma2mK3MD7pGZs0rhn+JChllqVS/SlPekMC54tqvmjqJa3Q5l 6Dqe3bNLLdy6sclol7LznaWISoviLaYgMHDquYfDAXk1PBtspYqkAp2GLEAbtPKnOMnFOV8 o9/Q+CQTDy7pJrpfXVoqM7skzoJSWyvZL15w7Lh3wEOI6x/BLloH0E+3WbWgSknnbDeAr69 H4U7poWe6uGo2w6TYadDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9C+Hh4bXD/Q=:9uHfXe5YFtOAxTDi3OkLXz zD5ZS+WQ4GFMqTRmDlecQleorJdYVLJWE57FgKaLjSC08pFAfrTwPAX8LAGvmNd4X8QTXGukh julGuW4BWYlTuW71RgI7P7dTMoz5rpNGxbyBi69deHDI1ojxRF0M+WZoxZVHXMD+CITBSLP8X YiCgIGayYlKbWZWVNzO0XS18JTzY5jGN2hIS97g3MvOsqnk3TxbMYUiOz435CxS3B2hOtlK8L dQBRllGkH6wAQnar9/6Ka+emCkJ9IZx9H/0JPMo2GntOje1b1mV4q7/9gHWVTPOd0+oLRcjOU m7sFbX2e2PZbDEsNjHU79NA/FB8VSJczs7/RjyIf2cH2cD+Xp7CM+d6vBraR1P+xrU2qYRuaj yjb5EJRgJ9arDffDVXPWndi++OXlK6a16KjngpLCDbuTmotGf8zDRUf5CVjMv4/G2BPedpeup HFO9m/96/TmlKeSEosCQctAlOuKC5rovlvuzGm2GPxYz43nB8gSSvVCpF1i2tQuLnp4Bc0xSX WTPsyBLBgduH0yZ1/T6pfZ6I5jou8+4GhRmPS+1ajtJ5LvBz9fCUmbTJbht5g1wuztZdUJYub OZkytMDY8E5mObbE8Ogi+3Y94Wyez78i/WIyc1EAs7yVOwHV1J+J5HtCiCLYYwVESLpAeqYij Mok3I10A1fzoY6tEPN0zCDIxvaUosBR+yRqZMkQYYV/zxuvNbpNv1nHz+6u7YPWg4JRkjobgf eXRrBVFxUVK3dk5W/u6t5z1ytXYDWeM1pJQ822Ozik7PM+7F4FWEREhyb80rSjm83IC/1xpm1 MoK9YG+6R0u/olY/gQ1meXdVTG6Zg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 4 May 2017 21:20:25 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c index 9c2690aeb32b..682e844c5a7d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c @@ -491,7 +491,7 @@ static int fwevtq_handler(struct sge_rspq *rspq, const __be64 *rsp, break; } tq = s->egr_map[eq_idx]; - if (unlikely(tq == NULL)) { + if (unlikely(!tq)) { dev_err(adapter->pdev_dev, "Egress Update QID %d TXQ=NULL\n", qid); break; @@ -2939,7 +2939,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev, */ netdev = alloc_etherdev_mq(sizeof(struct port_info), MAX_PORT_QSETS); - if (netdev == NULL) { + if (!netdev) { t4vf_free_vi(adapter, viid); err = -ENOMEM; goto err_free_dev; @@ -3053,7 +3053,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev, for_each_port(adapter, pidx) { struct port_info *pi = netdev_priv(adapter->port[pidx]); netdev = adapter->port[pidx]; - if (netdev == NULL) + if (!netdev) continue; netif_set_real_num_tx_queues(netdev, pi->nqsets); @@ -3120,7 +3120,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev, err_free_dev: for_each_port(adapter, pidx) { netdev = adapter->port[pidx]; - if (netdev == NULL) + if (!netdev) continue; pi = netdev_priv(netdev); t4vf_free_vi(adapter, pi->viid); @@ -3197,7 +3197,7 @@ static void cxgb4vf_pci_remove(struct pci_dev *pdev) struct net_device *netdev = adapter->port[pidx]; struct port_info *pi; - if (netdev == NULL) + if (!netdev) continue; pi = netdev_priv(netdev); -- 2.12.2