From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbcAAMsP (ORCPT ); Fri, 1 Jan 2016 07:48:15 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:49938 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbcAAMsM (ORCPT ); Fri, 1 Jan 2016 07:48:12 -0500 From: Arnd Bergmann To: Jan Kara Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] udf: avoid uninitialized variable use Date: Fri, 01 Jan 2016 13:47:41 +0100 Message-ID: <9221187.T0u8gszVyj@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ny+982dcmGK9yRBtWnlNtKaWce2dLo05Y8lsXfsZV2IojAWHKyx 8iC/ZM6Ocf4bCwkKxiPrZQ80KDbuAfq/2UBQLezRg1chsRyOAuCx4b9SXLhLyOxDJRy2WbK 0h1mO1pXQd6VSmY2Di1CKbfYAWW9L8erB7gnppDfK4euRIKwn+wjvTU4ar6Y2cNhoNI+F7T XydHHrxNPb+9NmMo67NSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:f3HmU0mxECs=:NCik7xCYPFlNp1Xi2qDYaz andltUNUA2INi6aGKQlsGLHho9aNqYm2D7nvQWCuJfch76M7XdnJJCXlP4xRNunA+LMTE1DsZ ucOCxNEl6ti1JAzEvkoZX5Mh+I7rUs8aHmwf8XZFSgoKCUAz/XbFbA3UdA9bhaUkYaHmINQg6 1bV5H0ppRmWMLwZgiOBe0q+nga93DmHEwLQWzXGcGBg3lUIqzpGNzfKjQzfjZ1/CVnrmbEqVC /YSg30Xeif4CEgbZ0c7wT4HZrNWOHtJMP0Le0eyc5eEOLpMzGi+CmR9zgZtoGsnymLROmtzPS nZRbC+PRJNv3eXYtsu03SYrMDa3520ZqvLJm/JEmmvMycBtsLKVO9jlMXZXaidT5Iv/BAKH4O jASYUgpV+UTs0BMX/BSGhT36i0CM6JYUL512yq0u66+2KcqWZ9tPZTMoQSmAgfJ6TaHVcuDRY ehvxo7GqSkhipixdn7SDFe5+qy3KRTdJi2nmZ1mXBx9yCC14R8ZmEFRs8zHXFsMF+h/eJkTfb DXc2xHyO93n7cNKdW3ACQj4wWgq4ykRMkoDNsl9m7Mn/ezspst37KG0W7v2XuUOJ+AFRduhjt PDp6Hv1F8qQ6HWWqM3PuH8JmBaB/wDrxxxijCeTGhsae4xfeBin/4CCT0bvfJOZivCVWw68+h VUvAgmP+pw96ZQBE/gdHnoc/EFWMEEkipDJmedTadJMQ4zzClo83Kphde8fKxMXG/D3H091vo DS0NhRf1GPYY23cO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A new warning about a real bug has come up from a recent cleanup: fs/udf/inode.c: In function 'udf_setup_indirect_aext': fs/udf/inode.c:1927:28: warning: 'adsize' may be used uninitialized in this function [-Wmaybe-uninitialized] If the alloc_type is neither ICBTAG_FLAG_AD_SHORT nor ICBTAG_FLAG_AD_LONG, the value of adsize is undefined. This changes the code to use zero for adsize in that case, which may be the correct solution, though I have not looked at the code in enough detail to know if it should be something else instead. Signed-off-by: Arnd Bergmann Fixes: fcea62babc81 ("udf: Factor out code for creating indirect extent") --- Found on ARM randconfig kernels starting with yesterday's linux-next diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 5b83351041a4..a1cc074c656f 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1890,6 +1890,8 @@ int udf_setup_indirect_aext(struct inode *inode, int block, adsize = sizeof(struct short_ad); else if (UDF_I(inode)->i_alloc_type == ICBTAG_FLAG_AD_LONG) adsize = sizeof(struct long_ad); + else + adsize = 0; neloc.logicalBlockNum = block; neloc.partitionReferenceNum = epos->block.partitionReferenceNum;