From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9587C77B61 for ; Wed, 26 Apr 2023 00:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238446AbjDZAcd (ORCPT ); Tue, 25 Apr 2023 20:32:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236413AbjDZAca (ORCPT ); Tue, 25 Apr 2023 20:32:30 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6838918BB3; Tue, 25 Apr 2023 17:32:25 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33Q0N3Pc016261; Wed, 26 Apr 2023 00:32:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=YunddZJcyTOjmyH3rvwNLH8BQ3+aRcIpXYKVTSq1qqw=; b=JuMPk+XhFR02fccSZV5zZVbytKb8w+R2NWb8dOq6GGvhSPdWDS45U0FKaO3xSRHqIjCf mffoEI3eAuiZj2IK83vpvBmvcbA6U2s9u9qpVYSJE2PCF2sJnE2XBjh+apBRxnnJm3W2 vmbDPxCoYvgLubEUIPSjZSznvzJ+CZI/xlFoNJFgkkEHjf/z+P5Ij+x2B+J4RCv0k7Gs MoCjex7jM/udVMSXTwMcqdhWkS952k/+qKskYq+Wy6V24zEMSWvBgQmd26e/51Kr627Q Q0mck89cNHTnHzgjQnuMUuaYn4AaI9ialG4MvtRW7GVHLvFagTEeQmZCS7d8Vt8ae32S vA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q6bdra7wp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 00:32:12 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33Q0WBjb006190 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 00:32:11 GMT Received: from [10.110.124.105] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 25 Apr 2023 17:32:10 -0700 Message-ID: <922a08d3-4a6c-35e7-fdc1-c551243406b6@quicinc.com> Date: Tue, 25 Apr 2023 17:32:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v3 02/21] drm/msm/dpu: Remove TE2 block and feature from DPU >= 7.0.0 hardware Content-Language: en-US To: Marijn Suijten , Rob Clark , Dmitry Baryshkov , "Sean Paul" , David Airlie , Daniel Vetter , Adam Skladowski , Loic Poulain , Bjorn Andersson , "Kuogee Hsieh" , Robert Foss , Vinod Koul , Neil Armstrong CC: <~postmarketos/upstreaming@lists.sr.ht>, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , "Jami Kettunen" , , , , , Jordan Crouse , Jessica Zhang References: <20230411-dpu-intf-te-v3-0-693b17fe6500@somainline.org> <20230411-dpu-intf-te-v3-2-693b17fe6500@somainline.org> From: Abhinav Kumar In-Reply-To: <20230411-dpu-intf-te-v3-2-693b17fe6500@somainline.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: t5z5hFMYLghG8kofFCKXyvaYrnQh7MsD X-Proofpoint-ORIG-GUID: t5z5hFMYLghG8kofFCKXyvaYrnQh7MsD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-25_11,2023-04-25_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 mlxscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 mlxlogscore=781 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304260002 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/2023 4:05 PM, Marijn Suijten wrote: > No hardware beyond kona (sm8250) defines the TE2 PINGPONG sub-block > offset downstream. Even though neither downstream nor upstream utilizes > these registers in any way, remove the erroneous specification for > SC8280XP, SM8350 and SM8450 to prevent confusion. > > Note that downstream enables the PPSPLIT (split-FIFO) topology (single > LM for 2 PP and 2 INTF) based on the presence of a TE2 block. > > Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") > Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog") > Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") > Signed-off-by: Marijn Suijten > Reviewed-by: Konrad Dybcio > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Abhinav Kumar