From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B9A17B50F for ; Mon, 17 Nov 2025 14:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763388191; cv=none; b=H+yJSVElaGY8xtuicdTwTlM6BT6kqR59+vcEcKXfntSmrw2fdCyEBTSPTLXXz85y6qiU+joDC0p926S2cMqr5lOOzA+H/4p3dzy0HzcTXnAR4nucgqdLeoc96dIjN/zPBTMhxvw+OFSpaBcP3w449mOzRqfSl0OD6PHnbeIoysQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763388191; c=relaxed/simple; bh=zBQN61tksf2025UCtOB0ANMv1Fzpi+dfcrv4CPkZ9hc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VfNuLjQm8rFL3q8z2E0KUawjKXECHCHFP0eLjZrqQjugrAlfD9ns09ZOEfcVB2xnPTQ6qwA6IW4oUewSxftakCuTNcy26o6kuv5Yl6m8iw5O4W1ls5Mw5FBwSE+52j3vyM8liOt62sUi7lDzB9imiSXdarzSAkurP8rL1K4MmCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fDTM5GSl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BhouL75c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fDTM5GSl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BhouL75c" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHAKVqW3932982 for ; Mon, 17 Nov 2025 14:03:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A4gh/KiDMiXP6GtsBD0jV44i4prQwi2UZjkTQnAGpfo=; b=fDTM5GSlpZlpE+F/ Yll2WAWkbz5B8FIvh+LLqnK1wha3+V5evOq5StyQ7/yXVwQT99HwrK/QQ4DYrHib YtYZPmUrhDwQm775l1eMYeL7T7GtlcSFk7oBYn7+4zKsHI6uYcAVX9OQxSwoefKf GjtudtcbJIo83ojArDZNAUoHitTo40vVyCMMoa7qn+VvQ+tsj/XAetXK1E39DJGe 347eDqJ2DEZjLYzsHIsLIm15nbZSeUeOoQMsLTF8ZU1pYIgtJZXDewAui6xuE33p LG63nW6tGf1brkpBHO8HJtDS6ySSN5V9rFmrd2bcDUCkKiSzLN/dM+qUNgsYgVAp t+ki2Q== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ag1v90keu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 14:03:08 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5595ecf10deso307682e0c.3 for ; Mon, 17 Nov 2025 06:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763388188; x=1763992988; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A4gh/KiDMiXP6GtsBD0jV44i4prQwi2UZjkTQnAGpfo=; b=BhouL75cjtBzffRI1V7cgsDvabsC90vQvkhy/x8sfFV9mNLG8KxRwYIQf9rIO3LNYJ HR/xjOp53uhcdR/jiI8IWo0YVzeDvesZyyalA27d5vE8jClFteOQH1BTWWpgt4bafvgO 0ZU6FIjgdPVg5gMPHwdg1uPu8foF1itnVYqQ3+SlceH1lI7T7sj9EOiQ3fkZLY9QS+/8 GpM3LU2P7BA0c8lXlEhD5b4paWHAYq2ewxPCrrGuC58wpMabjjA+rVme4QU1Lc2Jw/o4 fHl0Y6QJe6OMXiy8vsLqWP1DcErSQl3zIWJeVzY2zm7aJ5ORpya2xJ8vmGogxJVAROu6 6jAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763388188; x=1763992988; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A4gh/KiDMiXP6GtsBD0jV44i4prQwi2UZjkTQnAGpfo=; b=mUu3Ys6Ts9JzSE00YvZf/3xT4Z9Rt0tmEfpCqAL0/daoZeIvpWPTYHYMU4Hw5qMD00 6fULz9JdSBl1cQF1PDEfDYE++no53ONdnWnDQe4YY7VwNVmmksfxv8Jh4KxLauarhSgc L8ESFa4WXcyhVYinYOg/MxVA0d3qKYF/Fr191TuNOUsF7ILYm+535O6VWjXAsGb6eM4V c9pH11pyunVYq1uJb/DJi7aTCiIDOceMxzfXLPKH78rtUpE8tp7cCm+fj5+8DceQPt/m PVU5P+BZLdEk1Q2vwxVPGaexFvYr97q/mS3bhPuZ6nzHsSkYvdzgTXK4YEBuvylDN9Ji bsnQ== X-Forwarded-Encrypted: i=1; AJvYcCWA2qVc+nQnbKVBXlRzTHPi5IEQ/2SygMd0fjZZWBKrr1XBUmvor1WZFUXPruEeENGLXFKdYgGHWaTEDKU=@vger.kernel.org X-Gm-Message-State: AOJu0YxTAJCBI8I+7qULDD8BlyWbF/lfwTvjjHRhRqsdEL8JCF7QEIMd ORmHqmKfDNGpRiDgVRe9ciWDHg/6daIzJ5OaGqUgZGFuOk2agJw33JHWt+kvDPlFDmBKIMCm1Ph PJFg+YQtDH4sFoqFjbii6w4rtaWBUKRNqEUqi+BYAAE5eQhUn0H29KOpDPnQbHYCHPVU= X-Gm-Gg: ASbGncutGbgxTNiU9X8MBeuvB5xNEBJngWe0sAJ1Ix2aH3ZTy/goTqhr60MTirN2ggn s0t4hiicgoACzo9VocxupGyVWi1oPm3/YyG+eog4s+UWiQqN2NmIRWpwV+S3rBLSPruXewtsHMF sPlixyzzJ3ZIVEseWpuevuikHV4HMisXJX8c2UjzpnaQNaGGgqO1hGwTrJ9Zl+n4MBK7C+z0AeY t/8njZHd8iq/J+DlHxcGFeiynickkzSSMHZKGK6vJrKuI7q4s1VlpG5Y0gQO8cCo48Kzsl4ak4R KcNlJ8O2DBTXjiPVLEt5hsnYc1ZhjP8HAOUysBIfR4WjzgYJa6oTfN1hbOndB5u3DLzHEpXiRcf Uyq4bxXVxIGIE1bPwA4nie4r5DYgX8QqZsRIEF86LzXCNU9GZcqBI1i4s X-Received: by 2002:ac5:c5ad:0:b0:55b:1668:8a76 with SMTP id 71dfb90a1353d-55b1ebefba4mr1296476e0c.2.1763388188159; Mon, 17 Nov 2025 06:03:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZZTHOOdfEqa9ER8hemxiu6HJtbROxsxg4EQg/rySnc9YSfY+WhVEbc35EghFcBXcleB9lbg== X-Received: by 2002:ac5:c5ad:0:b0:55b:1668:8a76 with SMTP id 71dfb90a1353d-55b1ebefba4mr1296341e0c.2.1763388186109; Mon, 17 Nov 2025 06:03:06 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a3f961bsm10428680a12.14.2025.11.17.06.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 06:03:04 -0800 (PST) Message-ID: <922abf06-c75f-45b6-9653-492a00d414bd@oss.qualcomm.com> Date: Mon, 17 Nov 2025 15:03:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/20] drm/msm/adreno: Support AQE engine To: Akhil P Oommen , Rob Clark , Bjorn Andersson , Konrad Dybcio , Sean Paul , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Jonathan Marek , Jordan Crouse , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Connor Abbott Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org References: <20251114-kaana-gpu-support-v3-0-92300c7ec8ff@oss.qualcomm.com> <20251114-kaana-gpu-support-v3-14-92300c7ec8ff@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251114-kaana-gpu-support-v3-14-92300c7ec8ff@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: HHl9my0b2B_5CKc_rlKMhrKX9RWlzS9_ X-Proofpoint-GUID: HHl9my0b2B_5CKc_rlKMhrKX9RWlzS9_ X-Authority-Analysis: v=2.4 cv=acVsXBot c=1 sm=1 tr=0 ts=691b2b1c cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Vi7wF31NLlcTFLqBoF4A:9 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDExOSBTYWx0ZWRfXzUsa9rSxrb96 f/75jxi7Qn7vuvYBhShF+jOWUh0OYrJUi3HWUETfC+5GpJYYT9bazUUfWdcbW5SXJzv4Z9HuNDh dFIeKs4gQ2xMsU+LwMBJpNwEEe83umdSxQ4F10XJbwFFlc0Sn0y+DO68EjHTBlR678GYSTcRCf0 c1YzjFHh2VCrBKhq7IjuicBKZO7kLH4QShVWhdw8JczMmQwdSDgxlb8e3Oeu6vqOSwHkbaT4j0t +kfgunasyeFetM2fpDffXAnq/fXc/wmA32S+iLfhAxv1uVyC5p/12weIg4M7ug3w7Us8c91A6M/ x4YO8fQhCMdAvM5nUu+Ic32YMpSQ4vjOlxUjUkEDc5LzOCDqH6lmp4422CIPBBy4sZsSaHRRvDv DBjVxLm5Nc8SGx+z5IVxW/XJxCcBJQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170119 On 11/14/25 12:29 AM, Akhil P Oommen wrote: > AQE (Applicaton Qrisc Engine) is a dedicated core inside CP which aides > in Raytracing related workloads. Add support for loading the AQE firmware > and initialize the necessary registers. > > Since AQE engine has dependency on preemption context records, expose > Raytracing support to userspace only when preemption is enabled. > > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 17 +++++++++++++++++ > drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 ++ > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 3 +++ > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + > 4 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 20dbdad6e2e8..ef79f4cfb80b 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -1104,6 +1104,23 @@ static int a6xx_ucode_load(struct msm_gpu *gpu) > } > } > > + if (!a6xx_gpu->aqe_bo && adreno_gpu->fw[ADRENO_FW_AQE]) { > + a6xx_gpu->aqe_bo = adreno_fw_create_bo(gpu, > + adreno_gpu->fw[ADRENO_FW_AQE], &a6xx_gpu->aqe_iova); > + > + if (IS_ERR(a6xx_gpu->aqe_bo)) { > + int ret = PTR_ERR(a6xx_gpu->aqe_bo); > + > + a6xx_gpu->aqe_bo = NULL; > + DRM_DEV_ERROR(&gpu->pdev->dev, > + "Could not allocate AQE ucode: %d\n", ret); > + > + return ret; > + } > + > + msm_gem_object_set_name(a6xx_gpu->aqe_bo, "aqefw"); You need to unpin and _put this in a6xx_destroy() Konrad