From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757009AbcBIOPs (ORCPT ); Tue, 9 Feb 2016 09:15:48 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:58262 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756375AbcBIOPq (ORCPT ); Tue, 9 Feb 2016 09:15:46 -0500 From: Arnd Bergmann To: Vlastimil Babka , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: mm, compaction: fix build errors with kcompactd Date: Tue, 09 Feb 2016 15:15:39 +0100 Message-ID: <9230470.QhrU67iB7h@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GxZywDQCJE+ykzXem/HiFbx3q/kENaDyY5w3GlCU8WzmwMbmSAd O72yIP0b1Y5Gk+1CE1uAtRpHXAHZIp2yaHmQ+pW/GkjgbsDdQvase/dfFO2GfKWhuA+JPig LuCFE3i0C3KS8w7Qs0On9z8BgsaAj7zGNMwIRQyJD6Fkc1FPEGIS52TMOtLnQ6ngT1g9BD8 hZJJ4eCZl6yrxYrHFuXkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:F3X6jJagdWg=:6eyW1wp/C+1iNFKQy4TaPY xtYkGbepTprNN0ZsoICRgTeAL+BQyg5aMHYjTwZN/HQw4jNkPkkawfZmEqXggg7lwtG1IFWpN 0rcfKWqsDJDQGvnMSanwJ41l0HyPjT9rzAWxAPEc4W+j+gTpcZfOlYTjCIL/9f70Lfrxv4N8E y6Bu9VVUgB58GkGHzVBZXUu8oyBAPqEeYirZGjVsVlsUQNzxER8QV8ggA6JS/j8w3GMR7N6WV 4EAbGGjiXZUTFfuaWP8w4UW6R08DUXgxQ7TJxSpkMJ7i0URRZPLd8URMb0vC7cYdzXN+2itb7 bUVuOpp2+QNwuRgMvONjTgwhAqjO15CHEEvHlpz18zL+r6+JHbIrPGC7PYGul4UTMq9mP2Emk pDkcD9lEH0GPQyp/kWlkSWhMkP93SMkKrlW6jiW5KTzPcS/40uObnJIwp4vsrPf+RG7sy4NFh XZFWQ8owe65RUNszuBNGG5o5a1poCOdyatC+JEl67zr73F8jtp+dE1XUIzpF3DCKw7io1l/d8 YQJ+aR4wQbL8XK1XvJQmK5ZPTCh2+3aj6b5oeezWecpd7GO0KbRtZiLlwC1PK0wm6XeqpQDhl pYwsUtagrk/+UEju6kpPjkkKKoueVBn39pHUM6yIx6kKkcWxC5/l9FSi9ZkOnvmhNWFjWHEPY HsAKWFos9plxJUMTGOvnr0cs8BWpipu5za6x5LmxjGtkeqdOmlAIRmRhip/7rWC0lz1r8BfMr kKe0U5YqmMJf5RIX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added kcompactd code introduces multiple build errors: include/linux/compaction.h:91:12: error: 'kcompactd_run' defined but not used [-Werror=unused-function] mm/compaction.c:1953:2: error: implicit declaration of function 'hotcpu_notifier' [-Werror=implicit-function-declaration] This marks the new empty wrapper functions as 'inline' to avoid unused-function warnings, and includes linux/cpu.h to get the hotcpu_notifier declaration. Fixes: 8364acdfa45a ("mm, compaction: introduce kcompactd") Signed-off-by: Arnd Bergmann --- I stumbled over this while trying out the mmots patches today for an unrelated reason. diff --git a/include/linux/compaction.h b/include/linux/compaction.h index 1367c0564d42..d7c8de583a23 100644 --- a/include/linux/compaction.h +++ b/include/linux/compaction.h @@ -88,15 +88,15 @@ static inline bool compaction_deferred(struct zone *zone, int order) return true; } -static int kcompactd_run(int nid) +static inline int kcompactd_run(int nid) { return 0; } -static void kcompactd_stop(int nid) +static inline void kcompactd_stop(int nid) { } -static void wakeup_kcompactd(pg_data_t *pgdat, int order, int classzone_idx) +static inline void wakeup_kcompactd(pg_data_t *pgdat, int order, int classzone_idx) { } diff --git a/mm/compaction.c b/mm/compaction.c index 67bb651c56b1..4cb1c2ef5abb 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -7,6 +7,7 @@ * * Copyright IBM Corp. 2007-2010 Mel Gorman */ +#include #include #include #include