From: David Hildenbrand <david@redhat.com>
To: Eric DeVolder <eric.devolder@oracle.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, ebiederm@xmission.com,
dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
nramas@linux.microsoft.com, thomas.lendacky@amd.com,
robh@kernel.org, efault@gmx.de, rppt@kernel.org,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
Subject: Re: [RFC v2 4/6] crash hp: generic crash hotplug support infrastructure
Date: Wed, 8 Dec 2021 14:38:22 +0100 [thread overview]
Message-ID: <9230f9cc-1001-e3ce-aa74-10b766c8cdb0@redhat.com> (raw)
In-Reply-To: <20211207195204.1582-5-eric.devolder@oracle.com>
> +#if defined(CONFIG_MEMORY_HOTPLUG)
> +static int crash_memhp_notifier(struct notifier_block *nb,
> + unsigned long val, void *v)
> +{
> + struct memory_notify *mhp = v;
> + unsigned long start, end;
> +
> + start = mhp->start_pfn << PAGE_SHIFT;
> + end = ((mhp->start_pfn + mhp->nr_pages) << PAGE_SHIFT) - 1;
> +
> + switch (val) {
> + case MEM_GOING_ONLINE:
> + crash_hotplug_handler(KEXEC_CRASH_HP_ADD_MEMORY,
> + start, end-start);
> + break;
> +
> + case MEM_OFFLINE:
> + case MEM_CANCEL_ONLINE:
> + crash_hotplug_handler(KEXEC_CRASH_HP_REMOVE_MEMORY,
> + start, end-start);
Any reason you don't handle this after the effects completely, meaning
MEM_ONLINE and MEM_OFFLINE?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-12-08 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 19:51 [RFC v2 0/6] crash: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2021-12-07 19:51 ` [RFC v2 1/6] crash: fix minor typo/bug in debug message Eric DeVolder
2021-12-07 19:52 ` [RFC v2 2/6] crash hp: Introduce CRASH_HOTPLUG configuration options Eric DeVolder
2021-12-07 19:52 ` [RFC v2 3/6] crash hp: definitions and prototype changes Eric DeVolder
2022-01-19 8:23 ` Baoquan He
2022-01-19 8:25 ` Baoquan He
2021-12-07 19:52 ` [RFC v2 4/6] crash hp: generic crash hotplug support infrastructure Eric DeVolder
2021-12-08 13:38 ` David Hildenbrand [this message]
2021-12-09 15:40 ` Eric DeVolder
2021-12-07 19:52 ` [RFC v2 5/6] crash hp: kexec_file changes for crash hotplug support Eric DeVolder
2021-12-07 19:52 ` [RFC v2 6/6] crash hp: Add x86 " Eric DeVolder
2022-01-05 14:25 ` [RFC v2 0/6] crash: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2022-01-10 8:04 ` Baoquan He
2022-01-10 19:59 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9230f9cc-1001-e3ce-aa74-10b766c8cdb0@redhat.com \
--to=david@redhat.com \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=efault@gmx.de \
--cc=eric.devolder@oracle.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nramas@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome